Re: RFR: 8348986: Improve coverage of enhanced exception messages [v11]

2025-05-26 Thread Alan Bateman
On Mon, 26 May 2025 21:44:32 GMT, Mark Sheppard wrote: > The point I was raising, is that the socket etc category was dropped under > the premise that it requires knowledge of the APIs used. Right, what is now "hostInfoExclSocket" is a confusing category and not easy to explain to anyone. Howe

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v11]

2025-05-26 Thread Mark Sheppard
On Mon, 26 May 2025 19:22:39 GMT, Alan Bateman wrote: >> src/java.base/share/classes/jdk/internal/util/Exceptions.java line 253: >> >>> 251: return; >>> 252: enhancedSocketExceptionText = >>> SecurityProperties.includedInExceptions("hostInfo"); >>> 253: enhancedNonSo

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v11]

2025-05-26 Thread Mark Sheppard
On Mon, 26 May 2025 10:31:39 GMT, Michael McMahon wrote: >> Hi, >> >> Enhanced exception messages are designed to hide sensitive information such >> as hostnames, IP >> addresses from exception message strings, unless the enhanced mode for the >> specific category >> has been explicitly enab

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v11]

2025-05-26 Thread Alan Bateman
On Mon, 26 May 2025 19:06:56 GMT, Mark Sheppard wrote: >> Michael McMahon has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 28 commits: >> >> - Merge branch 'master' into 8348986-exceptions >> - update >> - reduced number of new

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v11]

2025-05-26 Thread Mark Sheppard
On Mon, 26 May 2025 10:31:39 GMT, Michael McMahon wrote: >> Hi, >> >> Enhanced exception messages are designed to hide sensitive information such >> as hostnames, IP >> addresses from exception message strings, unless the enhanced mode for the >> specific category >> has been explicitly enab

Re: RFR: 8357268: Use JavaNioAccess.getBufferAddress rather than DirectBuffer.address() [v7]

2025-05-26 Thread Alan Bateman
On Mon, 26 May 2025 12:47:55 GMT, Per Minborg wrote: >> src/java.base/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java >> line 459: >> >>> 457: >>> 458: boolean pending = false; >>> 459: IOUtil.acquireScope(buf, true); >> >> Would you mind checking th

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v11]

2025-05-26 Thread Mark Sheppard
On Mon, 26 May 2025 10:31:39 GMT, Michael McMahon wrote: >> Hi, >> >> Enhanced exception messages are designed to hide sensitive information such >> as hostnames, IP >> addresses from exception message strings, unless the enhanced mode for the >> specific category >> has been explicitly enab

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v11]

2025-05-26 Thread Mark Sheppard
On Mon, 26 May 2025 10:31:39 GMT, Michael McMahon wrote: >> Hi, >> >> Enhanced exception messages are designed to hide sensitive information such >> as hostnames, IP >> addresses from exception message strings, unless the enhanced mode for the >> specific category >> has been explicitly enab

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v11]

2025-05-26 Thread Mark Sheppard
On Mon, 26 May 2025 10:31:39 GMT, Michael McMahon wrote: >> Hi, >> >> Enhanced exception messages are designed to hide sensitive information such >> as hostnames, IP >> addresses from exception message strings, unless the enhanced mode for the >> specific category >> has been explicitly enab

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v11]

2025-05-26 Thread Mark Sheppard
On Mon, 26 May 2025 10:31:39 GMT, Michael McMahon wrote: >> Hi, >> >> Enhanced exception messages are designed to hide sensitive information such >> as hostnames, IP >> addresses from exception message strings, unless the enhanced mode for the >> specific category >> has been explicitly enab

Re: RFR: 8357268: Use JavaNioAccess.getBufferAddress rather than DirectBuffer.address() [v8]

2025-05-26 Thread Alan Bateman
On Mon, 26 May 2025 14:22:10 GMT, Per Minborg wrote: >> This PR proposes to use `JavaNioAccess::getBufferAdress` rather than >> `DirectBuffer::address` so that `Buffer` instances backed by MemorySegment >> instances can be used in classes that were not covered by >> https://github.com/openjdk

Re: RFR: 8357268: Use JavaNioAccess.getBufferAddress rather than DirectBuffer.address() [v8]

2025-05-26 Thread Per Minborg
> This PR proposes to use `JavaNioAccess::getBufferAdress` rather than > `DirectBuffer::address` so that `Buffer` instances backed by MemorySegment > instances can be used in classes that were not covered by > https://github.com/openjdk/jdk/pull/25321 > > This PR passes tier1, tier2, and tier3

Re: RFR: 8356977: UTF-8 cleanups [v2]

2025-05-26 Thread Magnus Ihse Bursie
On Mon, 26 May 2025 08:10:19 GMT, Magnus Ihse Bursie wrote: >> I found a few other places in the code that can be cleaned up after the >> conversion to UTF-8. > > Magnus Ihse Bursie has updated the pull request incrementally with two > additional commits since the last revision: > > - Restore

Re: RFR: 8351412: Add AVX-512 intrinsics for ML-KEM [v7]

2025-05-26 Thread Ferenc Rakoczi
On Tue, 20 May 2025 19:10:45 GMT, Sean Mullan wrote: > Please also write a release note as the performance improvement is > significant. Thanks! Done. https://bugs.openjdk.org/browse/JDK-8357741 Release Note: ML-KEM Performance Improved - PR Comment: https://git.openjdk.org/jdk/p

Re: RFR: 8357268: Use JavaNioAccess.getBufferAddress rather than DirectBuffer.address() [v7]

2025-05-26 Thread Per Minborg
On Mon, 26 May 2025 07:51:32 GMT, Alan Bateman wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix copyright year > > src/java.base/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java > line 459: >

Re: RFR: 8356632: Fix remaining {@link/@linkplain} tags with refer to private/protected types in java.base [v3]

2025-05-26 Thread Nizar Benalla
On Fri, 23 May 2025 14:59:07 GMT, Nizar Benalla wrote: >> Please review this patch to fix some `javadoc` bugs in `java.base`. >> Certain `@link` tags used to refer to private fields instead of public APIs. >> >> A couple of `@see` tags in the [serialization >> page](https://download.java.net/ja

Integrated: 8356632: Fix remaining {@link/@linkplain} tags with refer to private/protected types in java.base

2025-05-26 Thread Nizar Benalla
On Sat, 17 May 2025 19:42:39 GMT, Nizar Benalla wrote: > Please review this patch to fix some `javadoc` bugs in `java.base`. > Certain `@link` tags used to refer to private fields instead of public APIs. > > A couple of `@see` tags in the [serialization > page](https://download.java.net/java/ea

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v11]

2025-05-26 Thread Daniel Fuchs
On Mon, 26 May 2025 10:31:39 GMT, Michael McMahon wrote: >> Hi, >> >> Enhanced exception messages are designed to hide sensitive information such >> as hostnames, IP >> addresses from exception message strings, unless the enhanced mode for the >> specific category >> has been explicitly enab

Re: RFR: 8356977: UTF-8 cleanups [v2]

2025-05-26 Thread Magnus Ihse Bursie
On Thu, 22 May 2025 21:43:20 GMT, Phil Race wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Restore MenuShortcut.java >> - Restore LocaleDataTest.java > > src/java.desktop/share/classes/java/awt/MenuShortc

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v11]

2025-05-26 Thread Michael McMahon
> Hi, > > Enhanced exception messages are designed to hide sensitive information such > as hostnames, IP > addresses from exception message strings, unless the enhanced mode for the > specific category > has been explicitly enabled. Enhanced exceptions were first introduced in > 8204233 in JD

Re: RFR: 8356977: UTF-8 cleanups [v2]

2025-05-26 Thread Magnus Ihse Bursie
> I found a few other places in the code that can be cleaned up after the > conversion to UTF-8. Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision: - Restore MenuShortcut.java - Restore LocaleDataTest.java - Changes

Re: RFR: 8357268: Use JavaNioAccess.getBufferAddress rather than DirectBuffer.address() [v7]

2025-05-26 Thread Alan Bateman
On Wed, 21 May 2025 13:42:39 GMT, Per Minborg wrote: >> This PR proposes to use `JavaNioAccess::getBufferAdress` rather than >> `DirectBuffer::address` so that `Buffer` instances backed by MemorySegment >> instances can be used in classes that were not covered by >> https://github.com/openjdk

Withdrawn: 8356980: Better handling of non-breaking space

2025-05-26 Thread Magnus Ihse Bursie
On Wed, 14 May 2025 15:11:24 GMT, Magnus Ihse Bursie wrote: > Non-breaking space characters are problematic. They look identical to the > normal space character, but is not. For that reason, it should never be typed > as an UTF-8 literal, but only by using unicode sequences. > > I have checked

Re: RFR: 8356980: Better handling of non-breaking space

2025-05-26 Thread Magnus Ihse Bursie
On Thu, 22 May 2025 21:26:08 GMT, Phil Race wrote: >> FYI, the style guide for France >> [recommends](https://fr.wikipedia.org/wiki/Espace_ins%C3%A9cable#En_France): >> >> - U+202F (Narrow No-Break Space NNBSP) preceding semicolon, question mark, >> and exclamation mark. >> - U+00A0 (No-Break

Re: RFR: 8357268: Use JavaNioAccess.getBufferAddress rather than DirectBuffer.address() [v7]

2025-05-26 Thread Alan Bateman
On Wed, 21 May 2025 13:42:39 GMT, Per Minborg wrote: >> This PR proposes to use `JavaNioAccess::getBufferAdress` rather than >> `DirectBuffer::address` so that `Buffer` instances backed by MemorySegment >> instances can be used in classes that were not covered by >> https://github.com/openjdk

Re: RFR: 8356977: UTF-8 cleanups

2025-05-26 Thread Magnus Ihse Bursie
On Thu, 15 May 2025 18:30:28 GMT, Naoto Sato wrote: >> I found a few other places in the code that can be cleaned up after the >> conversion to UTF-8. > > test/jdk/sun/text/resources/LocaleDataTest.java line 106: > >> 104: *FormatData/fr_FR/MonthNames/0=janvier >> 105: *Format