RFR: 8349550: Improve SASL random usage

2025-05-22 Thread Koushik Muthukrishnan Thirupattur
Check Digest-MD5 utilities SecureRandom Usage and update random usage with secure random - Commit messages: - 8349550: Check Digest-MD5 utilities SecureRandom Usage and update random usage with secure random - 8349550: Check Digest-MD5 utilities SecureRandom Usage and update rando

Re: RFR: 8357033: Reduce stateless session ticket size [v11]

2025-05-22 Thread Artur Barashev
> The stateless session ticket is included in the ClientHello message, either > in the stateless_ticket extension (pre-TLS1.3), or in the pre_shared_key > extension (TLS1.3). With the current construction, the ticket is often the > largest contributor to the ClientHello message size. For example

RFR: 8357592: Update output parsing in test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java

2025-05-22 Thread Matthew Donovan
In this PR, I updated the jarsigner compatibility test to handle minor differences in the output of jarsigner between versions. - Commit messages: - 8357592: Update output parsing in test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java Changes: https://git.openjd

Re: RFR: 8356977: UTF-8 cleanups

2025-05-22 Thread Phil Race
On Wed, 14 May 2025 14:23:31 GMT, Magnus Ihse Bursie wrote: > I found a few other places in the code that can be cleaned up after the > conversion to UTF-8. src/java.desktop/share/classes/java/awt/MenuShortcut.java line 49: > 47: * For example, a menu shortcut for "Ctrl+cyrillic ef" is create

Re: RFR: 8356980: Better handling of non-breaking space

2025-05-22 Thread Phil Race
On Thu, 15 May 2025 12:33:06 GMT, Raffaello Giulietti wrote: >>> maybe this is just a translation error and a simple space can be used >>> instead, like in all the other properties in these files? >> >> That seems unlikely. The pattern is used consistently in the French >> translations, where

Re: RFR: 8357033: Reduce stateless session ticket size [v9]

2025-05-22 Thread Bradford Wetmore
On Thu, 22 May 2025 19:23:22 GMT, Artur Barashev wrote: >> The stateless session ticket is included in the ClientHello message, either >> in the stateless_ticket extension (pre-TLS1.3), or in the pre_shared_key >> extension (TLS1.3). With the current construction, the ticket is often the >> la

Re: RFR: 8357033: Reduce stateless session ticket size [v10]

2025-05-22 Thread Artur Barashev
> The stateless session ticket is included in the ClientHello message, either > in the stateless_ticket extension (pre-TLS1.3), or in the pre_shared_key > extension (TLS1.3). With the current construction, the ticket is often the > largest contributor to the ClientHello message size. For example

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v25]

2025-05-22 Thread Bradford Wetmore
> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE > respectively. > > CSR is underway. > > Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK > API (jck:api/java_security jck:api/javax_crypto jck:api/javax_net > jck:api/javax_security jck:ap

Re: RFR: 8357268: Use JavaNioAccess.getBufferAddress rather than DirectBuffer.address() [v7]

2025-05-22 Thread Valerie Peng
On Wed, 21 May 2025 17:55:17 GMT, Valerie Peng wrote: >> src/java.base/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java >> line 459: >> >>> 457: >>> 458: boolean pending = false; >>> 459: NIO_ACCESS.acquireSession(buf); >> >> Here, we acquire the sess

Re: RFR: 8357033: Reduce stateless session ticket size [v9]

2025-05-22 Thread Artur Barashev
> The stateless session ticket is included in the ClientHello message, either > in the stateless_ticket extension (pre-TLS1.3), or in the pre_shared_key > extension (TLS1.3). With the current construction, the ticket is often the > largest contributor to the ClientHello message size. For example

Re: RFR: 8357033: Reduce stateless session ticket size [v7]

2025-05-22 Thread Artur Barashev
> The stateless session ticket is included in the ClientHello message, either > in the stateless_ticket extension (pre-TLS1.3), or in the pre_shared_key > extension (TLS1.3). With the current construction, the ticket is often the > largest contributor to the ClientHello message size. For example

Re: RFR: 8357268: Use JavaNioAccess.getBufferAddress rather than DirectBuffer.address() [v7]

2025-05-22 Thread Valerie Peng
On Wed, 21 May 2025 13:42:39 GMT, Per Minborg wrote: >> This PR proposes to use `JavaNioAccess::getBufferAdress` rather than >> `DirectBuffer::address` so that `Buffer` instances backed by MemorySegment >> instances can be used in classes that were not covered by >> https://github.com/openjdk

Re: RFR: 8356632: Fix remaining {@link/@linkplain} tags with refer to private/protected types in java.base [v2]

2025-05-22 Thread Chen Liang
On Thu, 22 May 2025 15:18:43 GMT, Nizar Benalla wrote: >> Please review this patch to fix some `javadoc` bugs in `java.base`. >> Certain `@link` tags used to refer to private fields instead of public APIs. >> >> A couple of `@see` tags in the [serialization >> page](https://download.java.net/ja

Re: RFR: 8357033: Reduce stateless session ticket size [v8]

2025-05-22 Thread Artur Barashev
> The stateless session ticket is included in the ClientHello message, either > in the stateless_ticket extension (pre-TLS1.3), or in the pre_shared_key > extension (TLS1.3). With the current construction, the ticket is often the > largest contributor to the ClientHello message size. For example

Re: RFR: 8357033: Reduce stateless session ticket size [v6]

2025-05-22 Thread Artur Barashev
> The stateless session ticket is included in the ClientHello message, either > in the stateless_ticket extension (pre-TLS1.3), or in the pre_shared_key > extension (TLS1.3). With the current construction, the ticket is often the > largest contributor to the ClientHello message size. For example

Re: RFR: 8356632: Fix remaining {@link/@linkplain} tags with refer to private/protected types in java.base [v2]

2025-05-22 Thread Nizar Benalla
> Please review this patch to fix some `javadoc` bugs in `java.base`. > Certain `@link` tags used to refer to private fields instead of public APIs. > > A couple of `@see` tags in the [serialization > page](https://download.java.net/java/early_access/jdk25/docs/api/serialized-form.html#java.lang.

RFR: 8357470: src/java.base/share/classes/sun/security/util/Debug.java implement the test for args.toLowerCase

2025-05-22 Thread Mikhail Yankelevich
* added an automated mixed case option * using multithreading now * added logs for simpler debug * added missing -Djava.security.auth.debug coverage - Commit messages: - JDK-8357470: src/java.base/share/classes/sun/security/util/Debug.java implement the test for args.toLowerCase Ch

Re: RFR: 8346436: Compilation with clang fails [v2]

2025-05-22 Thread Alexey Ivanov
On Fri, 3 Jan 2025 09:19:34 GMT, Jan Kratochvil wrote: >> clang-18.1.8-1.fc40.x86_64 >> Fedora 40 x86_64 >> fbd76ca8edd756ff2ebbc9f6477cc1a827df67b0 >> >> >> src/java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c:695:9: error: >> ignoring return value of function declared with 'warn_unused_r

Re: RFR: 8349400: Improve startup speed via eliminating nested classes [v2]

2025-05-22 Thread Shaojin Wen
On Mon, 14 Apr 2025 14:40:02 GMT, Roger Riggs wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> from @valeriepeng > > Looks ok; but will need to be re-opened. It would seem odd to approve a > closed PR. Sorry it too

Re: RFR: 8356893: Use "stdin.encoding" for reading System.in with InputStreamReader/Scanner

2025-05-22 Thread Volkan Yazici
On Wed, 21 May 2025 21:37:07 GMT, Roger Riggs wrote: >> There are several locations in the JDK source where `System.in` and >> `FileDescriptor.in` is read with `InputStreamReader` and `Scanner` using the >> default charset. As recommended by the recently merged >> [JDK-8356420](https://bugs.op

Withdrawn: 8356893: Use "stdin.encoding" for reading System.in with InputStreamReader/Scanner

2025-05-22 Thread Volkan Yazici
On Wed, 21 May 2025 20:56:31 GMT, Volkan Yazici wrote: > There are several locations in the JDK source where `System.in` and > `FileDescriptor.in` is read with `InputStreamReader` and `Scanner` using the > default charset. As recommended by the recently merged > [JDK-8356420](https://bugs.open