Re: RFR: 8341346: Add support for exporting TLS Keying Material [v18]

2025-05-16 Thread Bradford Wetmore
> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE > respectively. > > CSR is underway. > > Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK > API (jck:api/java_security jck:api/javax_crypto jck:api/javax_net > jck:api/javax_security jck:ap

Re: RFR: 8349151: Refactor test/java/security/cert/CertificateFactory/slowstream.sh to java test [v4]

2025-05-16 Thread Weijun Wang
On Fri, 9 May 2025 10:31:19 GMT, Mikhail Yankelevich wrote: >> Refactor test/java/security/cert/CertificateFactory/slowstream.sh to java >> test > > Mikhail Yankelevich has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelat

Re: RFR: 8349151: Refactor test/java/security/cert/CertificateFactory/slowstream.sh to java test [v4]

2025-05-16 Thread duke
On Fri, 9 May 2025 10:31:19 GMT, Mikhail Yankelevich wrote: >> Refactor test/java/security/cert/CertificateFactory/slowstream.sh to java >> test > > Mikhail Yankelevich has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelat

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v17]

2025-05-16 Thread Bradford Wetmore
> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE > respectively. > > CSR is underway. > > Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK > API (jck:api/java_security jck:api/javax_crypto jck:api/javax_net > jck:api/javax_security jck:ap

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v7]

2025-05-16 Thread Bradford Wetmore
On Wed, 7 May 2025 16:21:23 GMT, Weijun Wang wrote: >> Bradford Wetmore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updated to use the upcoming KDF (still in preview) + bits of JDK-8353578 >> for compilation) > > src/java.base/share

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v7]

2025-05-16 Thread Bradford Wetmore
On Thu, 8 May 2025 06:03:03 GMT, Bradford Wetmore wrote: >> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 1694: >> >>> 1692: >>> 1693: // ...now the final expand. >>> 1694: SecretKey key = hkdf.deriveKey(label, >> >> PKCS #11 is p

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v12]

2025-05-16 Thread Bradford Wetmore
On Fri, 16 May 2025 17:17:04 GMT, Bradford Wetmore wrote: >> How about adding a `String alg` parameter to `exportKeyingMaterialKey` like >> in the `KDF.deriveKey` API? > > As discussed with @seanjmullan / @wangweij , that is the direction I'll try. > It's not perfect, but a definite step in th

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v10]

2025-05-16 Thread Bradford Wetmore
On Tue, 13 May 2025 13:07:18 GMT, Weijun Wang wrote: >> It seems like it should be an exception, whatever you decide to do. The >> caller is asking for the keying material data, and the provider cannot >> fulfill that request, so I think explaining why it could not be done would >> be best rep

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v12]

2025-05-16 Thread Bradford Wetmore
On Thu, 15 May 2025 04:22:42 GMT, Bradford Wetmore wrote: >> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 1650: >> >>> 1648: emptyHash = md.digest(); >>> 1649: } catch (NoSuchAlgorithmException nsae) { >>> 1650: thr

RFR: 8357062: Update Public Suffix List to 823beb1

2025-05-16 Thread Weijun Wang
This is a routine update to synchronize with the [Mozilla Public Suffix List](https://github.com/publicsuffix/list) for JDK 25, matching commit 823beb1 from 2025-05-12. The test has been updated to reflect corresponding changes. - Commit messages: - the fix Changes: https://git.o

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v12]

2025-05-16 Thread Bradford Wetmore
On Fri, 16 May 2025 16:50:22 GMT, Sean Mullan wrote: >> Personally, I would like to give user the chance to specify the algorithm >> themselves. A "TlsExporterKeyingMaterial" key will not be accepted by an AES >> cipher. If you are not ready for this, I'd rather only provide the >> `exportKeyi

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v12]

2025-05-16 Thread Sean Mullan
On Thu, 15 May 2025 19:41:16 GMT, Weijun Wang wrote: >> From a previous comment: >> >> IIUC, the exported keying material can be used for any purpose or algorithm, >> so we really can't make an good educated guess what it might be. They could >> be Keys (Ciphers), byte array/value challenges,

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v5]

2025-05-16 Thread Artur Barashev
On Fri, 9 May 2025 14:39:53 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](http

Integrated: 8353888: Implement JEP 510: Key Derivation Function API

2025-05-16 Thread Weijun Wang
On Tue, 8 Apr 2025 18:14:53 GMT, Weijun Wang wrote: > Finalize the KDF API. This pull request has now been integrated. Changeset: 079fccfa Author:Weijun Wang URL: https://git.openjdk.org/jdk/commit/079fccfa9a03b890e698c52c689dea0f19f8fbee Stats: 209 lines in 18 files changed: 16

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v10]

2025-05-16 Thread Michael McMahon
> Hi, > > Enhanced exception messages are designed to hide sensitive information such > as hostnames, IP > addresses from exception message strings, unless the enhanced mode for the > specific category > has been explicitly enabled. Enhanced exceptions were first introduced in > 8204233 in JD

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v5]

2025-05-16 Thread Daniel Fuchs
On Fri, 9 May 2025 14:39:53 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](http

Re: RFR: 8298420: PEM API: Implementation (Preview) [v22]

2025-05-16 Thread Anthony Scarpino
> Hi all, > > I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a format > for encoding and decoding cryptographic keys and certificates. It will be > integrated into JDK24 as a Preview Feature. Preview features does not > permanently define the API and it is subject to cha