> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE
> respectively.
>
> CSR is underway.
>
> Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK
> API (jck:api/java_security jck:api/javax_crypto jck:api/javax_net
> jck:api/javax_security jck:ap
On Thu, 15 May 2025 20:42:39 GMT, Sean Mullan wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Merged with changes for JDK-8353578
>
> src/java.base/share/classes/javax/net/ssl/ExtendedSSLSession.java line 169:
On Thu, 15 May 2025 13:33:42 GMT, Ferenc Rakoczi wrote:
>> By using the AVX-512 vector registers the speed of the computation of the
>> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
>> approximately doubled.
>
> Ferenc Rakoczi has updated the pull request incrementally
On Thu, 15 May 2025 00:36:26 GMT, Sandhya Viswanathan
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Responding to comments by Sandhya.
>
> Another minor comment. Rest of the PR looks good to me.
> @sviswa7, t
On Fri, 9 May 2025 20:05:10 GMT, Weijun Wang wrote:
>> Finalize the KDF API.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> new algorithms in SunJCE
Updates look good. Thanks~
-
Marked as reviewed by valeriep
On Wed, 14 May 2025 04:03:44 GMT, Bradford Wetmore wrote:
>> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE
>> respectively.
>>
>> CSR is underway.
>>
>> Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK
>> API (jck:api/java_security jck:
On Wed, 14 May 2025 04:03:44 GMT, Bradford Wetmore wrote:
>> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE
>> respectively.
>>
>> CSR is underway.
>>
>> Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK
>> API (jck:api/java_security jck:
On Thu, 15 May 2025 04:26:30 GMT, Bradford Wetmore wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 1682:
>>
>>> 1680: // ...now the final expand.
>>> 1681: return (deriveKey ?
>>> 1682:
>>> hkdf.
On Tue, 13 May 2025 14:01:10 GMT, Artur Barashev wrote:
> > It is nice to refactor the common code for algorithm constraints checking
> > into a new class, `X509KeyManagerConstraints.java`, used by both
> > `SunX509KeyManagerImpl` and `X509KeyManagerImpl`. However, it looks like a
> > new syst
On Wed, 14 May 2025 14:23:31 GMT, Magnus Ihse Bursie wrote:
> I found a few other places in the code that can be cleaned up after the
> conversion to UTF-8.
test/jdk/sun/text/resources/LocaleDataTest.java line 106:
> 104: *FormatData/fr_FR/MonthNames/0=janvier
> 105: *FormatD
On Thu, 15 May 2025 01:59:50 GMT, Bradford Wetmore wrote:
>> test/jdk/javax/net/ssl/ExtendedSSLSession/ExportKeyingMaterialTests.java
>> line 62:
>>
>>> 60: * produced.
>>> 61: */
>>> 62: public class ExportKeyingMaterialTests extends SSLContextTemplate {
>>
>> What's the reason we don't use
On Thu, 15 May 2025 12:51:16 GMT, Artur Barashev wrote:
>> Sure.
>
> Also, the parentheses are not needed around `context != null`
If there's one things to know about me, it's my liberal use of parens. I want
my code to match my intent.
I plan to update the "missing" parens.
-
P
On Thu, 15 May 2025 03:37:57 GMT, Anthony Scarpino
wrote:
>> Hi all,
>>
>> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a
>> format for encoding and decoding cryptographic keys and certificates. It
>> will be integrated into JDK24 as a Preview Feature. Preview featur
On Thu, 1 May 2025 05:33:29 GMT, Volkan Yazici wrote:
> Document preconditions on certain `JavaLangAccess` methods that use
> operations either unsafe and/or without range checks.
This pull request has now been integrated.
Changeset: 8fcfddb2
Author:Volkan Yazici
Committer: Chen Liang
UR
On Mon, 12 May 2025 19:42:15 GMT, Volkan Yazici wrote:
>> Document preconditions on certain `JavaLangAccess` methods that use
>> operations either unsafe and/or without range checks.
>
> Volkan Yazici has updated the pull request with a new target base due to a
> merge or a rebase. The incremen
On Thu, 15 May 2025 00:36:26 GMT, Sandhya Viswanathan
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Responding to comments by Sandhya.
>
> Another minor comment. Rest of the PR looks good to me.
@sviswa7, tha
On Mon, 12 May 2025 19:42:15 GMT, Volkan Yazici wrote:
>> Document preconditions on certain `JavaLangAccess` methods that use
>> operations either unsafe and/or without range checks.
>
> Volkan Yazici has updated the pull request with a new target base due to a
> merge or a rebase. The incremen
On Mon, 12 May 2025 19:42:15 GMT, Volkan Yazici wrote:
>> Document preconditions on certain `JavaLangAccess` methods that use
>> operations either unsafe and/or without range checks.
>
> Volkan Yazici has updated the pull request with a new target base due to a
> merge or a rebase. The incremen
On Wed, 14 May 2025 16:04:31 GMT, Sandhya Viswanathan
wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Responding to comments by Sandhya.
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_kyber.cpp line 893:
>
>> 891
> By using the AVX-512 vector registers the speed of the computation of the
> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
> approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with one additional
commit since the last revision:
Respons
On Thu, 15 May 2025 00:27:31 GMT, Bradford Wetmore wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 1727:
>>
>>> 1725:
>>> 1726: // context length must fit in 2 unsigned bytes.
>>> 1727: if ((context != null) && context.length >= 65536) {
>
On Thu, 15 May 2025 09:17:42 GMT, Magnus Ihse Bursie wrote:
>>> So, this exactly reverses what was done in the fix for JDK-8301991
>>
>> No, it doesn't. I still agree with that fix -- the overwhelming majority of
>> characters should indeed be UTF-8 instead of unicode sequences.
>>
>> This is
On Mon, 12 May 2025 19:42:15 GMT, Volkan Yazici wrote:
>> Document preconditions on certain `JavaLangAccess` methods that use
>> operations either unsafe and/or without range checks.
>
> Volkan Yazici has updated the pull request with a new target base due to a
> merge or a rebase. The incremen
On Thu, 15 May 2025 03:18:30 GMT, Naoto Sato wrote:
>> maybe this is just a translation error and a simple space can be used
>> instead, like in all the other properties in these files?
>
> Maybe, but sometimes it is intentional. CLDR has once switched normal spaces
> to NBSP/NNBSP for certain
On Thu, 8 May 2025 14:51:24 GMT, Leo Korinth wrote:
> This change tries to add timeout to individual testcases so that I am able to
> run them with a timeout factor of 1 in the future (JDK-8260555).
>
> The first commit changes the timeout factor to 0.7, so that I can run tests
> and test the
On Thu, 15 May 2025 09:16:10 GMT, Magnus Ihse Bursie wrote:
>> Maybe, but sometimes it is intentional. CLDR has once switched normal spaces
>> to NBSP/NNBSP for certain locales
>> (https://unicode-org.atlassian.net/browse/CLDR-14032). And we cannot tell if
>> it is intentional or not.
>
>> So,
On Thu, 8 May 2025 14:51:24 GMT, Leo Korinth wrote:
> This change tries to add timeout to individual testcases so that I am able to
> run them with a timeout factor of 1 in the future (JDK-8260555).
>
> The first commit changes the timeout factor to 0.7, so that I can run tests
> and test the
27 matches
Mail list logo
