Re: RFR: 8353578: Refactor existing usage of internal HKDF impl to use the KDF API [v7]

2025-05-05 Thread Bradford Wetmore
On Thu, 1 May 2025 18:49:33 GMT, Valerie Peng wrote: >> This PR removes the internal JSSE HKDF impl and changes to use the KDF API >> for the HKDF support from JCA/JCE providers. >> >> This is just code refactoring. Known-answer regression test for the internal >> JSSE HKDF impl is removed as

Re: RFR: 8353888: Implement JEP 510: Key Derivation Function API [v6]

2025-05-05 Thread Valerie Peng
On Fri, 2 May 2025 18:49:34 GMT, Weijun Wang wrote: >> Finalize the KDF API. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > fine tuning debug log and exception message Looks good. - Marked as reviewed by vale

Re: RFR: 8353888: Implement JEP 510: Key Derivation Function API [v6]

2025-05-05 Thread Weijun Wang
On Mon, 5 May 2025 20:04:46 GMT, Valerie Peng wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fine tuning debug log and exception message > > test/jdk/com/sun/crypto/provider/KDF/HKDFSaltIKMTest.java line 26: > >>

Re: RFR: 8353888: Implement JEP 510: Key Derivation Function API [v6]

2025-05-05 Thread Valerie Peng
On Fri, 2 May 2025 18:49:34 GMT, Weijun Wang wrote: >> Finalize the KDF API. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > fine tuning debug log and exception message test/jdk/com/sun/crypto/provider/KDF/HKDFSaltIKMTest.j

Re: RFR: 8298420: PEM API: Implementation (Preview) [v12]

2025-05-05 Thread Sean Mullan
On Thu, 17 Apr 2025 21:39:31 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/java/security/PEMDecoder.java line 377: >> >>> 375: * {@code provider} will occur during decoding. >>> 376: * >>> 377: * If {@code params} is {@code null}, a new instance is >>> returned wit

Re: RFR: 8298420: PEM API: Implementation (Preview) [v15]

2025-05-05 Thread Weijun Wang
On Fri, 2 May 2025 06:09:52 GMT, Anthony Scarpino wrote: >> Hi all, >> >> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a >> format for encoding and decoding cryptographic keys and certificates. It >> will be integrated into JDK24 as a Preview Feature. Preview features

Re: RFR: 8298420: PEM API: Implementation (Preview) [v15]

2025-05-05 Thread Sean Mullan
On Fri, 2 May 2025 06:09:52 GMT, Anthony Scarpino wrote: >> Hi all, >> >> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a >> format for encoding and decoding cryptographic keys and certificates. It >> will be integrated into JDK24 as a Preview Feature. Preview features

Re: RFR: 8272875: Change the default key manager to PKIX [v3]

2025-05-05 Thread Artur Barashev
On Mon, 5 May 2025 08:50:07 GMT, Daniel Jeliński wrote: > Well, technically the current 1ms takes into account both the client side and > the server side of the handshake. Last time I checked, they were more or less > evenly split. The 1ms slowdown will happen entirely on the server side, so >

Re: RFR: 8298420: PEM API: Implementation (Preview) [v15]

2025-05-05 Thread Sean Mullan
On Fri, 2 May 2025 06:09:52 GMT, Anthony Scarpino wrote: >> Hi all, >> >> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a >> format for encoding and decoding cryptographic keys and certificates. It >> will be integrated into JDK24 as a Preview Feature. Preview features

Re: RFR: 8272875: Change the default key manager to PKIX [v3]

2025-05-05 Thread Daniel Jeliński
On Tue, 29 Apr 2025 21:51:00 GMT, Artur Barashev wrote: >> The current key manager is SunX509, which is configured in the >> java.security. The SunX509 algorithm does not check the local certificate. >> The PKIX algorithm should be preferred now so that the default key manager >> could be more