RFR: 8353197: Document preconditions for JavaLangAccess methods

2025-04-30 Thread Volkan Yazici
Document preconditions on certain `JavaLangAccess` methods that use operations either unsafe and/or without range checks. - Commit messages: - Improve `JavaLangAccess` documentation Changes: https://git.openjdk.org/jdk/pull/24982/files Webrev: https://webrevs.openjdk.org/?repo=jd

Re: RFR: 8183348: Better cleanup for jdk/test/sun/security/pkcs12/P12SecretKey.java

2025-04-30 Thread Rajan Halade
On Thu, 17 Apr 2025 09:51:40 GMT, Mikhail Yankelevich wrote: > * Changed the test to use scratch directory > * Cleaned up the imports test/jdk/sun/security/pkcs12/P12SecretKey.java line 68: > 66: > 67: // temporary files are created in scratch directory > 68: final File ksFile

Re: RFR: 8201778: Speed up test javax/net/ssl/DTLS/PacketLossRetransmission.java

2025-04-30 Thread Rajan Halade
On Mon, 17 Mar 2025 13:19:55 GMT, Fernando Guallini wrote: > The test `javax/net/ssl/DTLS/PacketLossRetransmission` takes about ~2 to > complete. The reason is that, in multiple scenarios, the server/client socket > times out after 10 seconds waiting to receive a DatagramPacket that has been

Re: RFR: 8354235: Test javax/net/ssl/SSLSocket/Tls13PacketSize.java failed with java.net.SocketException: An established connection was aborted by the software in your host machine

2025-04-30 Thread Rajan Halade
On Mon, 21 Apr 2025 18:42:55 GMT, Matthew Donovan wrote: > In this PR, I updated the default `serverAddress` field to use the loopback > interface. I also removed some unnecessary logic around creating the server > interface and the client connecting code. Marked as reviewed by rhalade (Review

Re: RFR: 8277424: javax/net/ssl/TLSCommon/TLSTest.java fails with connection refused

2025-04-30 Thread Rajan Halade
On Wed, 23 Apr 2025 10:19:51 GMT, Mikhail Yankelevich wrote: > I could not replicate the issue after more than 64000 runs. However, I have > done the following to increase stability and added logs in case this happens > again. > > Changes: > * Specifically binding the client to the loopback

Re: RFR: 8298420: PEM API: Implementation (Preview) [v14]

2025-04-30 Thread Anthony Scarpino
On Mon, 28 Apr 2025 17:18:05 GMT, Weijun Wang wrote: >> I view this as an advanced feature for experienced users. The list is large >> and algorithm-dependent. For example an EC private key PEM could be >> PrivateKey.class, ECPrivateKey.class, PEMRecord.class, >> PKCS8EncodedKeySpec.class.

Re: RFR: 8298420: PEM API: Implementation (Preview) [v14]

2025-04-30 Thread Anthony Scarpino
On Fri, 25 Apr 2025 12:41:34 GMT, Weijun Wang wrote: >> Anthony Scarpino has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - javadoc updates >> - code review comments > > src/java.base/share/classes/sun/security/ec/ECKeyFactory.java line

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v2]

2025-04-30 Thread Bradford Wetmore
> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE > respectively. > > CSR is underway. > > Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK > API (jck:api/java_security jck:api/javax_crypto jck:api/javax_net > jck:api/javax_security jck:ap

Re: RFR: 8347938: Switch to latest ML-KEM private key encoding

2025-04-30 Thread Mark Powers
On Wed, 30 Apr 2025 15:43:31 GMT, Weijun Wang wrote: > The private key encoding formats of ML-KEM and ML-DSA are updated to match > the latest IETF drafts at: > https://datatracker.ietf.org/doc/html/draft-ietf-lamps-dilithium-certificates-08 > and > https://datatracker.ietf.org/doc/html/draft

Re: RFR: 8353888: Implement JEP 510: Key Derivation Function API [v4]

2025-04-30 Thread Weijun Wang
> Finalize the KDF API. Weijun Wang has updated the pull request incrementally with two additional commits since the last revision: - add a positive debug log and update exception message - enhancing exception messages and debug outputs - Changes: - all: https://git.openjdk.org

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v3]

2025-04-30 Thread Bradford Wetmore
> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE > respectively. > > CSR is underway. > > Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK > API (jck:api/java_security jck:api/javax_crypto jck:api/javax_net > jck:api/javax_security jck:ap

Re: RFR: 8353578: Refactor existing usage of internal HKDF impl to use the KDF API [v6]

2025-04-30 Thread Bradford Wetmore
On Tue, 29 Apr 2025 21:44:26 GMT, Valerie Peng wrote: >> This PR removes the internal JSSE HKDF impl and changes to use the KDF API >> for the HKDF support from JCA/JCE providers. >> >> This is just code refactoring. Known-answer regression test for the internal >> JSSE HKDF impl is removed as

RFR: 8341346: Add support for exporting TLS Keying Material

2025-04-30 Thread Bradford Wetmore
Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE respectively. CSR is underway. Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK API (jck:api/java_security jck:api/javax_crypto jck:api/javax_net jck:api/javax_security jck:api/org_ietf jck:a

Re: RFR: 8351412: Add AVX-512 intrinsics for ML-KEM [v2]

2025-04-30 Thread Leonid Mesnik
On Wed, 30 Apr 2025 07:48:32 GMT, Ferenc Rakoczi wrote: >> By using the AVX-512 vector registers the speed of the computation of the >> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be >> approximately doubled. > > Ferenc Rakoczi has updated the pull request incrementally

Re: RFR: 8347938: Switch to latest ML-KEM private key encoding

2025-04-30 Thread Mark Powers
On Wed, 30 Apr 2025 15:43:31 GMT, Weijun Wang wrote: > The private key encoding formats of ML-KEM and ML-DSA are updated to match > the latest IETF drafts at: > https://datatracker.ietf.org/doc/html/draft-ietf-lamps-dilithium-certificates-08 > and > https://datatracker.ietf.org/doc/html/draft

Re: RFR: 8353578: Refactor existing usage of internal HKDF impl to use the KDF API [v6]

2025-04-30 Thread Sean Mullan
On Wed, 30 Apr 2025 18:25:35 GMT, Valerie Peng wrote: >> src/java.base/share/classes/sun/security/ssl/ServerHello.java line 624: >> >>> 622: >>> 623: SSLKeyDerivation handshakeKD = ke.createKeyDerivation(shc); >>> 624: SecretKey handshakeSecret = handshakeKD.deriveKey( >

Re: RFR: 8315487: Security Providers Filter [v22]

2025-04-30 Thread Martin Balao
> In addition to the goals, scope, motivation, specification and requirement > notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would > like to describe the most relevant decisions taken during the implementation > of this enhancement. These notes are organized by feature,

Re: RFR: 8353578: Refactor existing usage of internal HKDF impl to use the KDF API [v6]

2025-04-30 Thread Valerie Peng
On Wed, 30 Apr 2025 15:49:16 GMT, Sean Mullan wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add comment about not using the same HKDF instance. > > src/java.base/share/classes/sun/security/ssl/ServerHello.java li

Integrated: 8350498: Remove two Camerfirma root CA certificates

2025-04-30 Thread Rajan Halade
On Tue, 22 Apr 2025 20:27:04 GMT, Rajan Halade wrote: > The change is to remove two Camerfirma root certificates which are terminated > and no longer in use. These two roots are removed from `cacerts` truststore. > Distrust of these roots is also removed as these roots will no longer be > trus

Re: RFR: 8352728: InternalError loading java.security due to Windows parent folder permissions

2025-04-30 Thread Francisco Ferrari Bihurriet
On Tue, 15 Apr 2025 07:46:52 GMT, Alan Bateman wrote: >> Hi, this is a proposal to fix 8352728. >> >> The main idea is to replace >> [`java.nio.file.Path::toRealPath`](https://docs.oracle.com/en/java/javase/24/docs/api/java.base/java/nio/file/Path.html#toRealPath(java.nio.file.LinkOption...)) >

Re: RFR: 8355779: When no "signature_algorithms_cert" extension is present we do not apply certificate scope constraints to algorithms in "signature_algorithms" extension [v2]

2025-04-30 Thread duke
On Mon, 28 Apr 2025 22:34:24 GMT, Artur Barashev wrote: >> Per TLSv1.3 RFC: >> >> >>If no "signature_algorithms_cert" extension is >>present, then the "signature_algorithms" extension also applies to >>signatures appearing in certificates. >> >> >> When no "signature_algorithms_ce

Re: RFR: 8272875: Change the default key manager to PKIX [v3]

2025-04-30 Thread Artur Barashev
On Tue, 29 Apr 2025 21:51:00 GMT, Artur Barashev wrote: >> The current key manager is SunX509, which is configured in the >> java.security. The SunX509 algorithm does not check the local certificate. >> The PKIX algorithm should be preferred now so that the default key manager >> could be more

Re: RFR: 8353578: Refactor existing usage of internal HKDF impl to use the KDF API [v6]

2025-04-30 Thread Sean Mullan
On Tue, 29 Apr 2025 21:44:26 GMT, Valerie Peng wrote: >> This PR removes the internal JSSE HKDF impl and changes to use the KDF API >> for the HKDF support from JCA/JCE providers. >> >> This is just code refactoring. Known-answer regression test for the internal >> JSSE HKDF impl is removed as

RFR: 8347938: Switch to latest ML-KEM private key encoding

2025-04-30 Thread Weijun Wang
The private key encoding formats of ML-KEM and ML-DSA are updated to match the latest IERTF drafts at: https://datatracker.ietf.org/doc/html/draft-ietf-lamps-dilithium-certificates-08 and https://datatracker.ietf.org/doc/html/draft-ietf-lamps-kyber-certificates-10. New security/system properti

Re: RFR: 8353578: Refactor existing usage of internal HKDF impl to use the KDF API [v6]

2025-04-30 Thread Sean Mullan
On Tue, 29 Apr 2025 21:44:26 GMT, Valerie Peng wrote: >> This PR removes the internal JSSE HKDF impl and changes to use the KDF API >> for the HKDF support from JCA/JCE providers. >> >> This is just code refactoring. Known-answer regression test for the internal >> JSSE HKDF impl is removed as

Re: RFR: 8353001: Remove leftover Security Manager parsing code in sun.security.util.Debug [v3]

2025-04-30 Thread Koushik Muthukrishnan Thirupattur
> The private marshal() method in sun.security.util.Debug still contains code > to parse "permission=" and "codebase=" options. These > sub-options were part of the "access" option which was removed in JDK 24 as > part of JEP 486, so this code can be removed. Koushik Muthukrishnan Thirupattur h

Re: RFR: 8353578: Refactor existing usage of internal HKDF impl to use the KDF API [v6]

2025-04-30 Thread Sean Mullan
On Tue, 29 Apr 2025 21:44:26 GMT, Valerie Peng wrote: >> This PR removes the internal JSSE HKDF impl and changes to use the KDF API >> for the HKDF support from JCA/JCE providers. >> >> This is just code refactoring. Known-answer regression test for the internal >> JSSE HKDF impl is removed as

Re: RFR: 8349910: Implement HTTP/3 for the HTTP Client API [v3]

2025-04-30 Thread Daniel Fuchs
On Wed, 30 Apr 2025 10:19:54 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for >> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976). >> >> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Clien

Re: RFR: 8230016: re-visit test sun/security/pkcs11/Serialize/SerializeProvider.java [v3]

2025-04-30 Thread Mikhail Yankelevich
> Provider is now added to the Security before the test Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: removed unneeded check - Changes: - all: https://git.openjdk.org/jdk/pull/24750/files - new: https://git.

Re: RFR: 8230016: re-visit test sun/security/pkcs11/Serialize/SerializeProvider.java [v3]

2025-04-30 Thread Mikhail Yankelevich
On Tue, 29 Apr 2025 19:02:38 GMT, Sean Mullan wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> removed unneeded check > > test/jdk/sun/security/pkcs11/Serialize/SerializeProvider.java line 51: > >> 49: >> 5

Re: RFR: 8353578: Refactor existing usage of internal HKDF impl to use the KDF API [v6]

2025-04-30 Thread Sean Mullan
On Tue, 29 Apr 2025 21:44:26 GMT, Valerie Peng wrote: >> This PR removes the internal JSSE HKDF impl and changes to use the KDF API >> for the HKDF support from JCA/JCE providers. >> >> This is just code refactoring. Known-answer regression test for the internal >> JSSE HKDF impl is removed as

Re: RFR: 8230016: re-visit test sun/security/pkcs11/Serialize/SerializeProvider.java [v2]

2025-04-30 Thread Mikhail Yankelevich
> Provider is now added to the Security before the test Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: changed to check for null provider - Changes: - all: https://git.openjdk.org/jdk/pull/24750/files - new:

Re: RFR: 8355779: When no "signature_algorithms_cert" extension is present we do not apply certificate scope constraints to algorithms in "signature_algorithms" extension [v2]

2025-04-30 Thread Sean Mullan
On Mon, 28 Apr 2025 22:34:24 GMT, Artur Barashev wrote: >> Per TLSv1.3 RFC: >> >> >>If no "signature_algorithms_cert" extension is >>present, then the "signature_algorithms" extension also applies to >>signatures appearing in certificates. >> >> >> When no "signature_algorithms_ce

Re: RFR: 8044609: javax.net.debug options not working and documented as expected [v13]

2025-04-30 Thread Sean Coffey
On Wed, 30 Apr 2025 13:01:45 GMT, Sean Coffey wrote: >> The `javax.net.debug` TLS debug option is buggy since TLSv1.3 implementation >> was introduced many years ago. >> >> Where "ssl" was previously a value to obtain all TLS debug traces (except >> network type dumps, verbose data), it now pr

Re: RFR: 8044609: javax.net.debug options not working and documented as expected [v13]

2025-04-30 Thread Sean Coffey
> The `javax.net.debug` TLS debug option is buggy since TLSv1.3 implementation > was introduced many years ago. > > Where "ssl" was previously a value to obtain all TLS debug traces (except > network type dumps, verbose data), it now prints only a few lines for a > standard client TLS connectio

Re: RFR: 8044609: javax.net.debug options not working and documented as expected [v12]

2025-04-30 Thread Sean Coffey
> The `javax.net.debug` TLS debug option is buggy since TLSv1.3 implementation > was introduced many years ago. > > Where "ssl" was previously a value to obtain all TLS debug traces (except > network type dumps, verbose data), it now prints only a few lines for a > standard client TLS connectio

Re: RFR: 8353001: Remove leftover Security Manager parsing code in sun.security.util.Debug [v2]

2025-04-30 Thread Sean Mullan
On Wed, 30 Apr 2025 03:21:19 GMT, Koushik Muthukrishnan Thirupattur wrote: >> The private marshal() method in sun.security.util.Debug still contains code >> to parse "permission=" and "codebase=" options. These >> sub-options were part of the "access" option which was removed in JDK 24 as >>

Re: RFR: 8349910: Implement HTTP/3 for the HTTP Client API [v3]

2025-04-30 Thread Daniel Fuchs
> Hi, > > Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for > the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976). > > The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Client > API](https://bugs.openjdk.org/browse/JDK-8350588) > > Th

Re: RFR: 8351412: Add AVX-512 intrinsics for ML-KEM [v2]

2025-04-30 Thread Ferenc Rakoczi
> By using the AVX-512 vector registers the speed of the computation of the > ML-KEM algorithms (key generation, encapsulation, decapsulation) can be > approximately doubled. Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision: Removed