Re: RFR: 8272875: Change the default key manager to PKIX [v3]

2025-04-29 Thread Daniel Jeliński
On Tue, 29 Apr 2025 21:51:00 GMT, Artur Barashev wrote: >> The current key manager is SunX509, which is configured in the >> java.security. The SunX509 algorithm does not check the local certificate. >> The PKIX algorithm should be preferred now so that the default key manager >> could be more

Re: RFR: 8353578: Refactor existing usage of internal HKDF impl to use the KDF API [v6]

2025-04-29 Thread Daniel Jeliński
On Tue, 29 Apr 2025 21:44:26 GMT, Valerie Peng wrote: >> This PR removes the internal JSSE HKDF impl and changes to use the KDF API >> for the HKDF support from JCA/JCE providers. >> >> This is just code refactoring. Known-answer regression test for the internal >> JSSE HKDF impl is removed as

Re: RFR: 8353001: Remove leftover Security Manager parsing code in sun.security.util.Debug [v2]

2025-04-29 Thread Koushik Muthukrishnan Thirupattur
> The private marshal() method in sun.security.util.Debug still contains code > to parse "permission=" and "codebase=" options. These > sub-options were part of the "access" option which was removed in JDK 24 as > part of JEP 486, so this code can be removed. Koushik Muthukrishnan Thirupattur h

Re: RFR: 8353578: Refactor existing usage of internal HKDF impl to use the KDF API [v6]

2025-04-29 Thread Weijun Wang
On Tue, 29 Apr 2025 21:44:26 GMT, Valerie Peng wrote: >> This PR removes the internal JSSE HKDF impl and changes to use the KDF API >> for the HKDF support from JCA/JCE providers. >> >> This is just code refactoring. Known-answer regression test for the internal >> JSSE HKDF impl is removed as

Re: RFR: 8272875: Change the default key manager to PKIX [v3]

2025-04-29 Thread Anthony Scarpino
On Tue, 29 Apr 2025 21:51:00 GMT, Artur Barashev wrote: >> The current key manager is SunX509, which is configured in the >> java.security. The SunX509 algorithm does not check the local certificate. >> The PKIX algorithm should be preferred now so that the default key manager >> could be more

Re: RFR: 8351113: RC2ParameterSpec throws IllegalArgumentException when offset is negative [v3]

2025-04-29 Thread Sean Mullan
On Tue, 29 Apr 2025 22:11:20 GMT, Mark Powers wrote: >> This is a side issue, but it looks like this API can also throw >> `IndexOutOfBoundsException` if an offset is input which causes >> `System.arraycopy` (on line 112) to access the iv out of range. Please check >> and file a separate issue

Re: RFR: 8351113: RC2ParameterSpec throws IllegalArgumentException when offset is negative [v3]

2025-04-29 Thread Mark Powers
On Tue, 29 Apr 2025 18:16:47 GMT, Sean Mullan wrote: >> done > > This is a side issue, but it looks like this API can also throw > `IndexOutOfBoundsException` if an offset is input which causes > `System.arraycopy` (on line 112) to access the iv out of range. Please check > and file a separate

Re: RFR: 8272875: Change the default key manager to PKIX [v3]

2025-04-29 Thread Artur Barashev
> The current key manager is SunX509, which is configured in the java.security. > The SunX509 algorithm does not check the local certificate. The PKIX > algorithm should be preferred now so that the default key manager could be > more robust. > > Compatibility considerations: > > 1) Customers

Re: RFR: 8353578: Refactor existing usage of internal HKDF impl to use the KDF API [v6]

2025-04-29 Thread Valerie Peng
> This PR removes the internal JSSE HKDF impl and changes to use the KDF API > for the HKDF support from JCA/JCE providers. > > This is just code refactoring. Known-answer regression test for the internal > JSSE HKDF impl is removed as the test vectors are already covered by the HKDF > impl in

Re: RFR: 8272875: Change the default key manager to PKIX [v2]

2025-04-29 Thread Artur Barashev
On Tue, 29 Apr 2025 19:58:42 GMT, Sean Mullan wrote: >> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Skip explicit KeyPair initialization and let the provider default set it > > test/jdk/javax/rmi/ssl/SSLSocketParameter

Re: RFR: 8272875: Change the default key manager to PKIX [v2]

2025-04-29 Thread Artur Barashev
On Tue, 29 Apr 2025 18:51:58 GMT, Sean Mullan wrote: >> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Skip explicit KeyPair initialization and let the provider default set it > > test/jdk/sun/security/tools/keytool/Print

Integrated: 8355262: Test sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java failed: accept timed out

2025-04-29 Thread Artur Barashev
On Thu, 24 Apr 2025 17:57:33 GMT, Artur Barashev wrote: > I wasn't able to reproduce the issue. Most likely it was caused by unusually > high CPU load in test environment. Increasing the server's "accept" call > time-out value from 5 to 10 seconds to make the test more robust. This pull reques

Re: RFR: 8272875: Change the default key manager to PKIX [v2]

2025-04-29 Thread Sean Mullan
On Thu, 24 Apr 2025 18:30:00 GMT, Artur Barashev wrote: >> The current key manager is SunX509, which is configured in the >> java.security. The SunX509 algorithm does not check the local certificate. >> The PKIX algorithm should be preferred now so that the default key manager >> could be more

Re: RFR: 8355262: Test sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java failed: accept timed out

2025-04-29 Thread duke
On Thu, 24 Apr 2025 17:57:33 GMT, Artur Barashev wrote: > I wasn't able to reproduce the issue. Most likely it was caused by unusually > high CPU load in test environment. Increasing the server's "accept" call > time-out value from 5 to 10 seconds to make the test more robust. @artur-oracle Y

Re: RFR: 8353001: Remove leftover Security Manager parsing code in sun.security.util.Debug

2025-04-29 Thread Sean Mullan
On Thu, 17 Apr 2025 17:32:03 GMT, Koushik Muthukrishnan Thirupattur wrote: > The private marshal() method in sun.security.util.Debug still contains code > to parse "permission=" and "codebase=" options. These > sub-options were part of the "access" option which was removed in JDK 24 as > part

Re: RFR: 8354305: SHAKE128 and SHAKE256 MessageDigest algorithms [v3]

2025-04-29 Thread Weijun Wang
On Tue, 29 Apr 2025 17:50:01 GMT, Valerie Peng wrote: > Update CSR with the new names, e.g. with the output length suffix? Thanks for reminding. Done. - PR Comment: https://git.openjdk.org/jdk/pull/24576#issuecomment-2839977324

Integrated: 8351113: RC2ParameterSpec throws IllegalArgumentException when offset is negative

2025-04-29 Thread Mark Powers
On Thu, 24 Apr 2025 17:22:22 GMT, Mark Powers wrote: > [JDK-8351113](https://bugs.openjdk.org/browse/JDK-8351113) This pull request has now been integrated. Changeset: c2485d5f Author:Mark Powers URL: https://git.openjdk.org/jdk/commit/c2485d5f7dd00eaed34a5d309276114eb4c78cb0 Stats:

Re: RFR: 8230016: re-visit test sun/security/pkcs11/Serialize/SerializeProvider.java

2025-04-29 Thread Sean Mullan
On Fri, 18 Apr 2025 10:15:06 GMT, Mikhail Yankelevich wrote: > Provider is now added to the Security before the test test/jdk/sun/security/pkcs11/Serialize/SerializeProvider.java line 51: > 49: > 50: if (Security.getProvider(p.getName()) != p) { > 51: throw new SkippedExce

RFR: 8351412: Add AVX-512 intrinsics for ML-KEM

2025-04-29 Thread Ferenc Rakoczi
By using the AVX-512 vector registers the speed of the computation of the ML-KEM algorithms (key generation, encapsulation, decapsulation) can be approximately doubled. - Commit messages: - 8351412: Add AVX-512 intrinsics for ML-KEM Changes: https://git.openjdk.org/jdk/pull/24953/

Re: RFR: 8272875: Change the default key manager to PKIX [v2]

2025-04-29 Thread Sean Mullan
On Thu, 24 Apr 2025 18:30:00 GMT, Artur Barashev wrote: >> The current key manager is SunX509, which is configured in the >> java.security. The SunX509 algorithm does not check the local certificate. >> The PKIX algorithm should be preferred now so that the default key manager >> could be more

Re: RFR: 8351113: RC2ParameterSpec throws IllegalArgumentException when offset is negative [v3]

2025-04-29 Thread Sean Mullan
On Tue, 29 Apr 2025 16:22:43 GMT, Mark Powers wrote: >> src/java.base/share/classes/javax/crypto/spec/RC2ParameterSpec.java line 107: >> >>> 105: if (offset < 0) { >>> 106: throw new ArrayIndexOutOfBoundsException("offset is >>> negative"); >>> 107: } >> >> Move the

Re: RFR: 8351113: RC2ParameterSpec throws IllegalArgumentException when offset is negative [v5]

2025-04-29 Thread Sean Mullan
On Tue, 29 Apr 2025 17:51:26 GMT, Mark Powers wrote: >> [JDK-8351113](https://bugs.openjdk.org/browse/JDK-8351113) > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > third comment from Sean LGTM. But see my one comment about a

Re: RFR: 8355262: Test sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java failed: accept timed out

2025-04-29 Thread Bradford Wetmore
On Thu, 24 Apr 2025 17:57:33 GMT, Artur Barashev wrote: > I wasn't able to reproduce the issue. Most likely it was caused by unusually > high CPU load in test environment. Increasing the server's "accept" call > time-out value from 5 to 10 seconds to make the test more robust. LGTM. -

Re: RFR: 8354305: SHAKE128 and SHAKE256 MessageDigest algorithms [v3]

2025-04-29 Thread Valerie Peng
On Mon, 28 Apr 2025 14:48:34 GMT, Weijun Wang wrote: >> Add 2 `MessageDigest` algorithms. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > test alias usage Update CSR with the new names, e.g. with the output length suffix?

Re: RFR: 8351113: RC2ParameterSpec throws IllegalArgumentException when offset is negative [v5]

2025-04-29 Thread Mark Powers
> [JDK-8351113](https://bugs.openjdk.org/browse/JDK-8351113) Mark Powers has updated the pull request incrementally with one additional commit since the last revision: third comment from Sean - Changes: - all: https://git.openjdk.org/jdk/pull/24854/files - new: https://git.op

Re: RFR: 8351113: RC2ParameterSpec throws IllegalArgumentException when offset is negative [v4]

2025-04-29 Thread Mark Powers
On Tue, 29 Apr 2025 16:52:09 GMT, Sean Mullan wrote: >> Mark Powers has updated the pull request incrementally with one additional >> commit since the last revision: >> >> second comment from Sean > > test/jdk/java/security/spec/RC2ParameterSpec/InvalidArrayIndex.java line 4: > >> 2: * Copy

Re: RFR: 8351113: RC2ParameterSpec throws IllegalArgumentException when offset is negative [v4]

2025-04-29 Thread Sean Mullan
On Tue, 29 Apr 2025 16:26:35 GMT, Mark Powers wrote: >> [JDK-8351113](https://bugs.openjdk.org/browse/JDK-8351113) > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > second comment from Sean test/jdk/java/security/spec/RC2Para

Re: RFR: 8351113: RC2ParameterSpec throws IllegalArgumentException when offset is negative [v3]

2025-04-29 Thread Mark Powers
On Tue, 29 Apr 2025 13:08:36 GMT, Sean Mullan wrote: >> Mark Powers has updated the pull request incrementally with one additional >> commit since the last revision: >> >> comment from Sean > > src/java.base/share/classes/javax/crypto/spec/RC2ParameterSpec.java line 107: > >> 105: if

Re: RFR: 8351113: RC2ParameterSpec throws IllegalArgumentException when offset is negative [v4]

2025-04-29 Thread Mark Powers
> [JDK-8351113](https://bugs.openjdk.org/browse/JDK-8351113) Mark Powers has updated the pull request incrementally with one additional commit since the last revision: second comment from Sean - Changes: - all: https://git.openjdk.org/jdk/pull/24854/files - new: https://git.o

Re: RFR: 8350498: Remove two Camerfirma root CA certificates

2025-04-29 Thread Sean Mullan
On Tue, 22 Apr 2025 20:27:04 GMT, Rajan Halade wrote: > The change is to remove two Camerfirma root certificates which are terminated > and no longer in use. These two roots are removed from `cacerts` truststore. > Distrust of these roots is also removed as these roots will no longer be > trus

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v9]

2025-04-29 Thread Michael McMahon
> Hi, > > Enhanced exception messages are designed to hide sensitive information such > as hostnames, IP > addresses from exception message strings, unless the enhanced mode for the > specific category > has been explicitly enabled. Enhanced exceptions were first introduced in > 8204233 in JD

Re: RFR: 8351113: RC2ParameterSpec throws IllegalArgumentException when offset is negative [v3]

2025-04-29 Thread Sean Mullan
On Mon, 28 Apr 2025 21:05:26 GMT, Mark Powers wrote: >> [JDK-8351113](https://bugs.openjdk.org/browse/JDK-8351113) > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > comment from Sean src/java.base/share/classes/javax/crypto/s

Re: [Bug] NPE thrown from SASL GSSAPI impl on Java 11+ when TLS is used with QOP auth-int against Active Directory

2025-04-29 Thread Osipov, Michael (IN IT IN)
On 2025-04-28 10:22, Osipov, Michael (IN IT IN) wrote: > Hi folks, > Hi Max, > > please assess the following bug I have found in Java 11+, it does not exist > in Java 8. I have tried the following most versions on Azul Zulu/ > OpenJDK: 8, 11, 17, 21, 24 on multiple platforms. Searched JBS as wel