On Sat, 26 Apr 2025 04:54:10 GMT, Bradford Wetmore wrote:
> Minor error in the `SSLSessionImpl` comments as to how the class is
> "serialized. Fix the ordering.
>
> Do a little cleaning on the class on some obvious errors.
>
> No testing needed.
This pull request has now been integrated.
Cha
On Sat, 26 Apr 2025 04:54:10 GMT, Bradford Wetmore wrote:
> Minor error in the `SSLSessionImpl` comments as to how the class is
> "serialized. Fix the ordering.
>
> Do a little cleaning on the class on some obvious errors.
>
> No testing needed.
Marked as reviewed by ascarpino (Reviewer).
--
On Sat, 26 Apr 2025 04:54:10 GMT, Bradford Wetmore wrote:
> Minor error in the `SSLSessionImpl` comments as to how the class is
> "serialized. Fix the ordering.
>
> Do a little cleaning on the class on some obvious errors.
>
> No testing needed.
Looks good
-
PR Review: https://g
Minor error in the `SSLSessionImpl` comments as to how the class is
"serialized. Fix the ordering.
Do a little cleaning on the class on some obvious errors.
No testing needed.
-
Commit messages:
- 8355637: SSLSessionImpl's "serialization" list documentation is incorrectly
ordered
On Fri, 25 Apr 2025 18:40:17 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/sun/security/ssl/KAKeyDerivation.java line 131:
>>
>>> 129:
>>> 130: // derive handshake secret
>>> 131: return hkdf.deriveKey(type, HKDFParameterSpec.ofExtract()
>>
>> The line above m
> This PR removes the internal JSSE HKDF impl and changes to use the KDF API
> for the HKDF support from JCA/JCE providers.
>
> This is just code refactoring. Known-answer regression test for the internal
> JSSE HKDF impl is removed as the test vectors are already covered by the HKDF
> impl in
> [JDK-8351113](https://bugs.openjdk.org/browse/JDK-8351113)
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
need test
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24854/files
- new: https://git.openjdk.org/jdk/
On Thu, 24 Apr 2025 16:59:45 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
>> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>>
>> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Clien
On Thu, 24 Apr 2025 16:59:45 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
>> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>>
>> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Clien
On Thu, 24 Apr 2025 16:59:45 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
>> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>>
>> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Clien
On Thu, 24 Apr 2025 16:59:45 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
>> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>>
>> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Clien
On Fri, 25 Apr 2025 15:41:09 GMT, Weijun Wang wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Undo the special workaround for JSSE in PKCS11 HKDF impl.
>
> src/java.base/share/classes/sun/security/ssl/PreSharedKeyE
On Fri, 25 Apr 2025 15:36:26 GMT, Weijun Wang wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Undo the special workaround for JSSE in PKCS11 HKDF impl.
>
> src/java.base/share/classes/sun/security/ssl/KAKeyDerivati
On Fri, 25 Apr 2025 10:40:47 GMT, Daniel Jeliński wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Undo the special workaround for JSSE in PKCS11 HKDF impl.
>
> src/java.base/share/classes/com/sun/crypto/provider/DH
On Thu, 17 Apr 2025 21:35:36 GMT, Valerie Peng wrote:
>> This PR removes the internal JSSE HKDF impl and changes to use the KDF API
>> for the HKDF support from JCA/JCE providers.
>>
>> This is just code refactoring. Known-answer regression test for the internal
>> JSSE HKDF impl is removed as
On Fri, 25 Apr 2025 14:56:56 GMT, Mikhail Yankelevich
wrote:
>> Sergey Kuksenko has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update AESExtraBench.java
>
> test/micro/org/openjdk/bench/javax/crypto/full/AESExtraBench.java line 59:
>
> Benchmark modification/extension shouldn't affect the behavior of other
> benchmarks.
> Precisely: [JDK-8344144](https://bugs.openjdk.org/browse/JDK-8344144)
> modified AESBench in that way, which caused significant changes in the
> behavior of other benchmarks that extend AESBench.
Sergey Ku
On Thu, 24 Apr 2025 23:23:50 GMT, Sergey Kuksenko wrote:
> Benchmark modification/extension shouldn't affect the behavior of other
> benchmarks.
> Precisely: [JDK-8344144](https://bugs.openjdk.org/browse/JDK-8344144)
> modified AESBench in that way, which caused significant changes in the
> be
> Hi,
>
> Enhanced exception messages are designed to hide sensitive information such
> as hostnames, IP
> addresses from exception message strings, unless the enhanced mode for the
> specific category
> has been explicitly enabled. Enhanced exceptions were first introduced in
> 8204233 in JD
On Thu, 17 Apr 2025 15:51:09 GMT, Anthony Scarpino
wrote:
>> Hi all,
>>
>> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a
>> format for encoding and decoding cryptographic keys and certificates. It
>> will be integrated into JDK24 as a Preview Feature. Preview featur
On Thu, 17 Apr 2025 21:35:36 GMT, Valerie Peng wrote:
>> This PR removes the internal JSSE HKDF impl and changes to use the KDF API
>> for the HKDF support from JCA/JCE providers.
>>
>> This is just code refactoring. Known-answer regression test for the internal
>> JSSE HKDF impl is removed as
On Fri, 21 Mar 2025 12:00:57 GMT, Fernando Guallini
wrote:
>> The following tests are marked with @ignore (not running):
>>
>> - sun/security/ssl/SSLSocketImpl/SetClientMode.java: it checks that setting
>> the clientMode after the handshake has begun is not permitted, but this was
>> failing
22 matches
Mail list logo
