Re: RFR: 8272875: Change the default key manager to PKIX

2025-04-23 Thread Anthony Scarpino
On Fri, 18 Apr 2025 17:04:56 GMT, Artur Barashev wrote: > The current key manager is SunX509, which is configured in the java.security. > The SunX509 algorithm does not check of the local certificate. The PKIX > algorithm should be preferred now so that the default key manager could be > more

Re: RFR: 8298420: PEM API: Implementation (Preview) [v14]

2025-04-23 Thread Weijun Wang
On Thu, 17 Apr 2025 15:51:09 GMT, Anthony Scarpino wrote: >> Hi all, >> >> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a >> format for encoding and decoding cryptographic keys and certificates. It >> will be integrated into JDK24 as a Preview Feature. Preview featur

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug [v5]

2025-04-23 Thread Bradford Wetmore
On Thu, 17 Apr 2025 15:25:36 GMT, Sean Coffey wrote: >> Breaking the parent JDK-8044609 JBS issue into sub tasks. >> >> This patch addresses the main issue which is that `javax.net.debug=ssl ` >> option is completely broken since TLSv1.3 support was introduced. This >> patch should be easier

Re: RFR: 8325513: Export method for Cipher [v5]

2025-04-23 Thread Weijun Wang
> Add `Cipher::exportKey` API. Weijun Wang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision: - Merge bra

Re: RFR: 8350830: Values converted incorrectly when reading TLS session tickets [v3]

2025-04-23 Thread Anthony Scarpino
On Mon, 14 Apr 2025 12:54:31 GMT, Nibedita Jena wrote: >> Session resumption without server side state was added under >> [JDK-8211018](https://bugs.openjdk.org/browse/JDK-8211018). >> While it is TLSv1.2 session resumption, the client hello message is being >> parsed in SSLSessionImpl for each

Integrated: 8353478: Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithms

2025-04-23 Thread Sergey Kuksenko
On Tue, 1 Apr 2025 21:41:57 GMT, Sergey Kuksenko wrote: > Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithms. This pull request has now been integrated. Changeset: 35716647 Author:Sergey Kuksenko URL: https://git.openjdk.org/jdk/commit/35716647b531f0c20f980313

Re: RFR: 8354469: Keytool exposes the password in plain text when command is piped using | grep [v4]

2025-04-23 Thread Weijun Wang
> Add more description on password handling into the keytool man page. A link > to the man page is now added to the keytool help screen. > > When keytool output is redirected into a file or file, a warning is shown: > > $ keytool -genkeypair | type > > Warning: password will be echoed because o

Re: RFR: 8354469: Keytool exposes the password in plain text when command is piped using | grep [v2]

2025-04-23 Thread Weijun Wang
On Wed, 23 Apr 2025 13:54:37 GMT, Mikhail Yankelevich wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> hide warning when password is piped into the command; enhance test > > test/jdk/sun/security/tools/keytool/EchoP

Re: RFR: 8353478: Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithms [v3]

2025-04-23 Thread Eric Caspole
On Wed, 9 Apr 2025 19:34:24 GMT, Sergey Kuksenko wrote: >> Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithms. > > Sergey Kuksenko has updated the pull request incrementally with three > additional commits since the last revision: > > - Update SignatureBench.java > >

Re: RFR: 8354469: Keytool exposes the password in plain text when command is piped using | grep [v3]

2025-04-23 Thread Weijun Wang
> Add more description on password handling into the keytool man page. A link > to the man page is now added to the keytool help screen. > > When keytool output is redirected into a file or file, a warning is shown: > > $ keytool -genkeypair | type > > Warning: password will be echoed because o

Re: RFR: 8354469: Keytool exposes the password in plain text when command is piped using | grep [v2]

2025-04-23 Thread Mikhail Yankelevich
On Wed, 23 Apr 2025 13:39:00 GMT, Weijun Wang wrote: >> Add more description on password handling into the keytool man page. A link >> to the man page is now added to the keytool help screen. >> >> When keytool output is redirected into a file or file, a warning is shown: >> >> $ keytool -genk

Re: RFR: 8354469: Keytool exposes the password in plain text when command is piped using | grep [v2]

2025-04-23 Thread Weijun Wang
> Add more description on password handling into the keytool man page. A link > to the man page is now added to the keytool help screen. > > When keytool output is redirected into a file or file, a warning is shown: > > $ keytool -genkeypair | type > > Warning: password will be echoed because o

Re: RFR: 8349910: Implement HTTP/3 for the HTTP Client API

2025-04-23 Thread Jaikiran Pai
On Tue, 22 Apr 2025 18:55:28 GMT, Artur Barashev wrote: >> Hi, >> >> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for >> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976). >> >> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Cli

Re: RFR: 8349910: Implement HTTP/3 for the HTTP Client API

2025-04-23 Thread Artur Barashev
On Wed, 23 Apr 2025 08:03:02 GMT, Jaikiran Pai wrote: >> `MD5NotAllowedInTLS13CertificateSignature` contains an example. > > A lot of (existing) HttpClient tests in `test/jdk/java/net/httpclient` > currently use this `SimpleSSLContext` construct to read the `testkeys` > keystore that's availabl

Re: RFR: 8354469: Keytool exposes the password in plain text when command is piped using | grep

2025-04-23 Thread Mikhail Yankelevich
On Tue, 22 Apr 2025 22:43:08 GMT, Weijun Wang wrote: > Add more description on password handling into the keytool man page. A link > to the man page is now added to the keytool help screen. > > When keytool output is redirected into a file or file, a warning is shown: > > $ keytool -genkeypair

Re: RFR: 8349910: Implement HTTP/3 for the HTTP Client API

2025-04-23 Thread Michael McMahon
On Fri, 18 Apr 2025 18:47:52 GMT, Chen Liang wrote: >> Hi, >> >> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for >> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976). >> >> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Client

RFR: 8277424: javax/net/ssl/TLSCommon/TLSTest.java fails with connection refused

2025-04-23 Thread Mikhail Yankelevich
I could not replicate the issue after more than 64000 runs. However, I have done the following to increase stability and added logs in case this happens again. Changes: * Specifically binding the client to the loopback address * Added additional debug logging - Commit messages:

Re: RFR: 8349910: Implement HTTP/3 for the HTTP Client API

2025-04-23 Thread Jaikiran Pai
On Tue, 22 Apr 2025 19:11:24 GMT, Artur Barashev wrote: >> test/jdk/java/net/httpclient/http3/H3QuicTLSConnection.java line 96: >> >>> 94: //System.setProperty("javax.net.ssl.trustStore", KEYSTORE); >>> 95: //System.setProperty("javax.net.ssl.trustStorePassword", >>> PASSWORD);

Re: RFR: 8349910: Implement HTTP/3 for the HTTP Client API

2025-04-23 Thread Jaikiran Pai
On Tue, 22 Apr 2025 18:56:19 GMT, Artur Barashev wrote: >> Hi, >> >> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for >> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976). >> >> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Cli

Re: RFR: 8349910: Implement HTTP/3 for the HTTP Client API

2025-04-23 Thread Jaikiran Pai
On Tue, 22 Apr 2025 16:10:19 GMT, Artur Barashev wrote: >> Hi, >> >> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for >> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976). >> >> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Cli