Re: RFR: 8350807: Certificates using MD5 algorithm that are disabled by default are incorrectly allowed in TLSv1.3 when re-enabled [v10]

2025-04-15 Thread Artur Barashev
> MD5 algorithm is prohibited by TLSv1.3 RFC to be used in certificates: > > > Any endpoint receiving any certificate which it would need to > validate using any signature algorithm using an MD5 hash MUST abort > the handshake with a "bad_certificate" alert. > > > > The bug manifests itself wh

Re: RFR: 8350807: Certificates using MD5 algorithm that are disabled by default are incorrectly allowed in TLSv1.3 when re-enabled [v9]

2025-04-15 Thread Artur Barashev
> MD5 algorithm is prohibited by TLSv1.3 RFC to be used in certificates: > > > Any endpoint receiving any certificate which it would need to > validate using any signature algorithm using an MD5 hash MUST abort > the handshake with a "bad_certificate" alert. > > > > The bug manifests itself wh

Re: RFR: 8348732: SunJCE and SunPKCS11 have different PBE key encodings [v5]

2025-04-15 Thread Valerie Peng
> As part of [https://bugs.openjdk.org/browse/JDK-8301553](JDK-8301553), > SunPKCS11 provider added support for PBE SecretKeyFactories for > `HmacPBESHAxxx` and `PBEWithHmacSHAxxxAndAES_yyy`. These impls produce keys > whose encoding contains the PBKDF2 derived bytes. Given that SunJCE provider

Re: RFR: 8350807: Certificates using MD5 algorithm that are disabled by default are incorrectly allowed in TLSv1.3 when re-enabled [v8]

2025-04-15 Thread Artur Barashev
> MD5 algorithm is prohibited by TLSv1.3 RFC to be used in certificates: > > > Any endpoint receiving any certificate which it would need to > validate using any signature algorithm using an MD5 hash MUST abort > the handshake with a "bad_certificate" alert. > > > > The bug manifests itself wh

Re: RFR: 8350807: Certificates using MD5 algorithm that are disabled by default are incorrectly allowed in TLSv1.3 when re-enabled [v7]

2025-04-15 Thread Artur Barashev
> MD5 algorithm is prohibited by TLSv1.3 RFC to be used in certificates: > > > Any endpoint receiving any certificate which it would need to > validate using any signature algorithm using an MD5 hash MUST abort > the handshake with a "bad_certificate" alert. > > > > The bug manifests itself wh

New candidate JEP: 510: Key Derivation Function API

2025-04-15 Thread Mark Reinhold
https://openjdk.org/jeps/510 Summary: Introduce an API for Key Derivation Functions (KDFs), which are cryptographic algorithms for deriving additional keys from a secret key and other data. - Mark

Re: RFR: 8350807: Certificates using MD5 algorithm that are disabled by default are incorrectly allowed in TLSv1.3 when re-enabled [v6]

2025-04-15 Thread Artur Barashev
> MD5 algorithm is prohibited by TLSv1.3 RFC to be used in certificates: > > > Any endpoint receiving any certificate which it would need to > validate using any signature algorithm using an MD5 hash MUST abort > the handshake with a "bad_certificate" alert. > > > > The bug manifests itself wh

Re: RFR: 8325448: Hybrid Public Key Encryption [v15]

2025-04-15 Thread Sean Mullan
On Fri, 11 Apr 2025 20:41:13 GMT, Weijun Wang wrote: >> Implement HPKE as defined in https://datatracker.ietf.org/doc/rfc9180/. >> ![hpke](https://github.com/user-attachments/assets/4edc5d08-ef52-44c5-b5d5-e8890c2d2fce) > > Weijun Wang has updated the pull request incrementally with one additiona

Re: RFR: 8325448: Hybrid Public Key Encryption [v15]

2025-04-15 Thread Sean Mullan
On Mon, 14 Apr 2025 19:37:44 GMT, Sean Mullan wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> toString, exportData, spec in HPKEParameters must have algorithm >> identifiers specified > > src/java.base/share/classe

Re: RFR: 8352728: InternalError loading java.security due to Windows parent folder permissions [v2]

2025-04-15 Thread Francisco Ferrari Bihurriet
> Hi, this is a proposal to fix 8352728. > > The main idea is to replace > [`java.nio.file.Path::toRealPath`](https://docs.oracle.com/en/java/javase/24/docs/api/java.base/java/nio/file/Path.html#toRealPath(java.nio.file.LinkOption...)) > by > [`java.io.File::getCanonicalPath`](https://docs.orac

Re: RFR: 8328914: Document the java.security.debug property in javadoc [v18]

2025-04-15 Thread Sean Mullan
On Tue, 15 Apr 2025 18:02:43 GMT, Koushik Muthukrishnan Thirupattur wrote: >> java.security.debug is a widely used debug system property for JDK security >> libs. It's time to capture details about this property via javadoc. >> >> > src="https://github.com/user-attachments/assets/555f034a-57fb

Re: RFR: 8348732: SunJCE and SunPKCS11 have different PBE key encodings [v4]

2025-04-15 Thread Valerie Peng
On Tue, 15 Apr 2025 15:31:38 GMT, Francisco Ferrari Bihurriet wrote: > Looks good to me, but please note I'm not a Reviewer. Thanks much for the detailed review and suggestions~ - PR Comment: https://git.openjdk.org/jdk/pull/24068#issuecomment-2807097351

Re: RFR: 8349721: Add aarch64 intrinsics for ML-KEM [v7]

2025-04-15 Thread Ferenc Rakoczi
On Tue, 15 Apr 2025 15:09:16 GMT, Ferenc Rakoczi wrote: >> @adinn Hi, Andrew, >> I think I addressed all of your comment improvement comments, in most cases >> I just changed them as you suggested. Thanks a lot for the thorough review! > >> @ferakocz >> >> Hi Ferenc, >> >> Sorry, but I still

Re: RFR: 8349721: Add aarch64 intrinsics for ML-KEM [v11]

2025-04-15 Thread Ferenc Rakoczi
> By using the aarch64 vector registers the speed of the computation of the > ML-KEM algorithms (key generation, encapsulation, decapsulation) can be > approximately doubled. Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision: Fixed a

Re: RFR: 8328914: Document the java.security.debug property in javadoc [v18]

2025-04-15 Thread Koushik Muthukrishnan Thirupattur
> java.security.debug is a widely used debug system property for JDK security > libs. It's time to capture details about this property via javadoc. > > src="https://github.com/user-attachments/assets/555f034a-57fb-4ac0-a157-511757cb8dc2"; > /> > > > > NOTE : We are adding a new html file (si

Re: RFR: 8350807: Certificates using MD5 algorithm that are disabled by default are incorrectly allowed in TLSv1.3 when re-enabled [v3]

2025-04-15 Thread Artur Barashev
On Tue, 15 Apr 2025 14:30:22 GMT, Sean Mullan wrote: >> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update Copyright > > test/jdk/sun/security/ssl/SignatureScheme/MD5NotAllowedInTLS13CertificateSignature.java > line 5

Re: RFR: 8350807: Certificates using MD5 algorithm that are disabled by default are incorrectly allowed in TLSv1.3 when re-enabled [v5]

2025-04-15 Thread Artur Barashev
> MD5 algorithm is prohibited by TLSv1.3 RFC to be used in certificates: > > > Any endpoint receiving any certificate which it would need to > validate using any signature algorithm using an MD5 hash MUST abort > the handshake with a "bad_certificate" alert. > > > > The bug manifests itself wh

Re: RFR: 8350661: PKCS11 HKDF throws ProviderException when requesting a 31-byte AES key [v2]

2025-04-15 Thread Martin Balao
On Tue, 15 Apr 2025 16:04:26 GMT, Francisco Ferrari Bihurriet wrote: >> BTW, I don't like the partial "Tls" string comparison much because it's >> making an assumption about the algorithm name. > > A new `PCKK_TLSKEY` pseudo key type looks good to me. Alternatively, and just > thinking out lou

Re: RFR: 8349721: Add aarch64 intrinsics for ML-KEM [v8]

2025-04-15 Thread Ferenc Rakoczi
> By using the aarch64 vector registers the speed of the computation of the > ML-KEM algorithms (key generation, encapsulation, decapsulation) can be > approximately doubled. Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision: Clarifi

Re: RFR: 8350661: PKCS11 HKDF throws ProviderException when requesting a 31-byte AES key [v2]

2025-04-15 Thread Martin Balao
On Tue, 15 Apr 2025 13:20:34 GMT, Martin Balao wrote: >> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11SecretKeyFactory.java >> line 240: >> >>> 238: putKeyInfo(new KeyInfo("TlsPremasterSecret", >>> PCKK_TLSPREMASTER)); >>> 239: putKeyInfo(new KeyInfo("TlsRsaPrem

Re: RFR: 8349721: Add aarch64 intrinsics for ML-KEM [v7]

2025-04-15 Thread Andrew Dinn
On Thu, 10 Apr 2025 13:19:05 GMT, Ferenc Rakoczi wrote: >> By using the aarch64 vector registers the speed of the computation of the >> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be >> approximately doubled. > > Ferenc Rakoczi has updated the pull request incrementally

Re: RFR: 8328914: Document the java.security.debug property in javadoc [v16]

2025-04-15 Thread Sean Mullan
On Thu, 10 Apr 2025 05:09:52 GMT, Koushik Muthukrishnan Thirupattur wrote: >> java.security.debug is a widely used debug system property for JDK security >> libs. It's time to capture details about this property via javadoc. >> >> ![image](https://github.com/user-attachments/assets/b8a589d1-69

Re: RFR: 8349721: Add aarch64 intrinsics for ML-KEM [v9]

2025-04-15 Thread Ferenc Rakoczi
> By using the aarch64 vector registers the speed of the computation of the > ML-KEM algorithms (key generation, encapsulation, decapsulation) can be > approximately doubled. Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision: Uncomme

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v6]

2025-04-15 Thread Daniel Fuchs
On Tue, 15 Apr 2025 14:35:28 GMT, Michael McMahon wrote: >> Hi, >> >> Enhanced exception messages are designed to hide sensitive information such >> as hostnames, IP >> addresses from exception message strings, unless the enhanced mode for the >> specific category >> has been explicitly enab

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v6]

2025-04-15 Thread Michael McMahon
> Hi, > > Enhanced exception messages are designed to hide sensitive information such > as hostnames, IP > addresses from exception message strings, unless the enhanced mode for the > specific category > has been explicitly enabled. Enhanced exceptions were first introduced in > 8204233 in JD

Re: RFR: 8349721: Add aarch64 intrinsics for ML-KEM [v7]

2025-04-15 Thread Andrew Dinn
On Mon, 14 Apr 2025 12:26:09 GMT, Ferenc Rakoczi wrote: >> @ferakocz Hi Ferenc. Thank you for adjusting the code as requested and even >> more so for the extra clean-ups you added which I very much appreciate. >> >> I have added suggestions for some extra/modified commenting to clarify >> cert

Re: RFR: 8350661: PKCS11 HKDF throws ProviderException when requesting a 31-byte AES key [v2]

2025-04-15 Thread Martin Balao
On Fri, 11 Apr 2025 23:46:49 GMT, Martin Balao wrote: >>> What I have found with Tls* keys is that they are in the map but we need to >>> translate their pseudo-mechanism to a valid one (`CKK_GENERIC_SECRET`). Is >>> that enough for #24393? >> >> What I found is that there are more "TlsXXX" th

Re: RFR: 8348732: SunJCE and SunPKCS11 have different PBE key encodings [v4]

2025-04-15 Thread Francisco Ferrari Bihurriet
On Mon, 14 Apr 2025 19:07:06 GMT, Valerie Peng wrote: >> As part of [https://bugs.openjdk.org/browse/JDK-8301553](JDK-8301553), >> SunPKCS11 provider added support for PBE SecretKeyFactories for >> `HmacPBESHAxxx` and `PBEWithHmacSHAxxxAndAES_yyy`. These impls produce keys >> whose encoding co

Re: RFR: 8350661: PKCS11 HKDF throws ProviderException when requesting a 31-byte AES key [v2]

2025-04-15 Thread Martin Balao
On Mon, 14 Apr 2025 18:53:12 GMT, Francisco Ferrari Bihurriet wrote: >> Martin Balao has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Algorithm and key size checking before derivation. Mechanism >> normalization for TLS. >> - Minor i

Re: RFR: 8350807: Certificates using MD5 algorithm that are disabled by default are incorrectly allowed in TLSv1.3 when re-enabled [v4]

2025-04-15 Thread Artur Barashev
> MD5 algorithm is prohibited by TLSv1.3 RFC to be used in certificates: > > > Any endpoint receiving any certificate which it would need to > validate using any signature algorithm using an MD5 hash MUST abort > the handshake with a "bad_certificate" alert. > > > > The bug manifests itself wh

Re: RFR: 8350661: PKCS11 HKDF throws ProviderException when requesting a 31-byte AES key [v2]

2025-04-15 Thread Francisco Ferrari Bihurriet
On Tue, 15 Apr 2025 13:23:06 GMT, Martin Balao wrote: >> I like this idea but the downside I see is that we would need string >> comparison in `P11KDF::getDerivedKeyType` to allow TLS keys. What if we >> merge all `PCKK_TLSPREMASTER`, `PCKK_TLSRSAPREMASTER` and `PCKK_TLSMASTER` >> into `PCKK_T

Re: RFR: 8350807: Certificates using MD5 algorithm that are disabled by default are incorrectly allowed in TLSv1.3 when re-enabled [v3]

2025-04-15 Thread Sean Mullan
On Mon, 14 Apr 2025 15:19:18 GMT, Artur Barashev wrote: >> MD5 algorithm is prohibited by TLSv1.3 RFC to be used in certificates: >> >> >> Any endpoint receiving any certificate which it would need to >> validate using any signature algorithm using an MD5 hash MUST abort >> the handshake with a

Re: RFR: 8349721: Add aarch64 intrinsics for ML-KEM [v7]

2025-04-15 Thread Andrew Dinn
On Thu, 10 Apr 2025 13:19:05 GMT, Ferenc Rakoczi wrote: >> By using the aarch64 vector registers the speed of the computation of the >> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be >> approximately doubled. > > Ferenc Rakoczi has updated the pull request incrementally

Re: RFR: 8349721: Add aarch64 intrinsics for ML-KEM [v7]

2025-04-15 Thread Andrew Dinn
On Thu, 10 Apr 2025 13:19:05 GMT, Ferenc Rakoczi wrote: >> By using the aarch64 vector registers the speed of the computation of the >> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be >> approximately doubled. > > Ferenc Rakoczi has updated the pull request incrementally

Re: RFR: 8349721: Add aarch64 intrinsics for ML-KEM [v7]

2025-04-15 Thread Andrew Dinn
On Tue, 15 Apr 2025 15:09:16 GMT, Ferenc Rakoczi wrote: >> @adinn Hi, Andrew, >> I think I addressed all of your comment improvement comments, in most cases >> I just changed them as you suggested. Thanks a lot for the thorough review! > >> @ferakocz >> >> Hi Ferenc, >> >> Sorry, but I still

Re: RFR: 8350807: Certificates using MD5 algorithm that are disabled by default are incorrectly allowed in TLSv1.3 when re-enabled [v3]

2025-04-15 Thread Artur Barashev
On Tue, 15 Apr 2025 14:32:47 GMT, Sean Mullan wrote: >> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update Copyright > > test/jdk/sun/security/ssl/SignatureScheme/MD5NotAllowedInTLS13CertificateSignature.java > line 2

Re: RFR: 8350807: Certificates using MD5 algorithm that are disabled by default are incorrectly allowed in TLSv1.3 when re-enabled [v3]

2025-04-15 Thread Artur Barashev
On Tue, 15 Apr 2025 14:35:38 GMT, Sean Mullan wrote: >> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update Copyright > > test/jdk/sun/security/ssl/SignatureScheme/MD5NotAllowedInTLS13CertificateSignature.java > line 3

Re: RFR: 8349721: Add aarch64 intrinsics for ML-KEM [v10]

2025-04-15 Thread Ferenc Rakoczi
> By using the aarch64 vector registers the speed of the computation of the > ML-KEM algorithms (key generation, encapsulation, decapsulation) can be > approximately doubled. Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision: Accepte

Re: RFR: 8349721: Add aarch64 intrinsics for ML-KEM [v7]

2025-04-15 Thread Ferenc Rakoczi
On Mon, 14 Apr 2025 12:26:09 GMT, Ferenc Rakoczi wrote: >> @ferakocz Hi Ferenc. Thank you for adjusting the code as requested and even >> more so for the extra clean-ups you added which I very much appreciate. >> >> I have added suggestions for some extra/modified commenting to clarify >> cert

Re: RFR: 8349721: Add aarch64 intrinsics for ML-KEM [v7]

2025-04-15 Thread Andrew Dinn
On Thu, 10 Apr 2025 13:19:05 GMT, Ferenc Rakoczi wrote: >> By using the aarch64 vector registers the speed of the computation of the >> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be >> approximately doubled. > > Ferenc Rakoczi has updated the pull request incrementally

Re: RFR: 8349721: Add aarch64 intrinsics for ML-KEM [v7]

2025-04-15 Thread Andrew Dinn
On Thu, 10 Apr 2025 13:19:05 GMT, Ferenc Rakoczi wrote: >> By using the aarch64 vector registers the speed of the computation of the >> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be >> approximately doubled. > > Ferenc Rakoczi has updated the pull request incrementally

Re: RFR: 8350661: PKCS11 HKDF throws ProviderException when requesting a 31-byte AES key [v2]

2025-04-15 Thread Martin Balao
On Mon, 14 Apr 2025 17:44:53 GMT, Francisco Ferrari Bihurriet wrote: >> Martin Balao has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Algorithm and key size checking before derivation. Mechanism >> normalization for TLS. >> - Minor i

Re: RFR: 8328914: Document the java.security.debug property in javadoc [v17]

2025-04-15 Thread Sean Mullan
On Tue, 15 Apr 2025 07:50:00 GMT, Koushik Muthukrishnan Thirupattur wrote: >> java.security.debug is a widely used debug system property for JDK security >> libs. It's time to capture details about this property via javadoc. >> >> > src="https://github.com/user-attachments/assets/4aa9d5e7-0886

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v5]

2025-04-15 Thread Michael McMahon
On Mon, 14 Apr 2025 14:20:39 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> update to minimise code changes > > test/jdk/java/net/URI/Test.java line 29: > >> 27: * 7171415 6339649 69338

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v5]

2025-04-15 Thread Michael McMahon
On Mon, 14 Apr 2025 13:51:30 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> update to minimise code changes > > src/java.base/share/classes/java/net/Proxy.java line 102: > >> 100:

Re: RFR: 8328914: Document the java.security.debug property in javadoc [v17]

2025-04-15 Thread Koushik Muthukrishnan Thirupattur
> java.security.debug is a widely used debug system property for JDK security > libs. It's time to capture details about this property via javadoc. > > src="https://github.com/user-attachments/assets/a89943bb-9250-4e64-a8da-01a60ed993ef"; > /> > > > > > NOTE : We are adding a new html file

Re: RFR: 8352728: InternalError loading java.security due to Windows parent folder permissions

2025-04-15 Thread Alan Bateman
On Sat, 5 Apr 2025 02:36:43 GMT, Francisco Ferrari Bihurriet wrote: > Hi, this is a proposal to fix 8352728. > > The main idea is to replace > [`java.nio.file.Path::toRealPath`](https://docs.oracle.com/en/java/javase/24/docs/api/java.base/java/nio/file/Path.html#toRealPath(java.nio.file.LinkOp

Re: RFR: 8350830: Values converted incorrectly when reading TLS session tickets [v2]

2025-04-15 Thread Nibedita Jena
On Wed, 9 Apr 2025 14:13:41 GMT, Mikhail Yankelevich wrote: >> Nibedita Jena has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Minor change > > test/jdk/sun/security/ssl/SSLSessionImpl/ResumeClientTLS12withSNI.java line > 361: > >> 359: