Re: RFR: 8352728: InternalError loading java.security due to Windows parent folder permissions

2025-04-14 Thread Francisco Ferrari Bihurriet
On Thu, 10 Apr 2025 05:52:17 GMT, Alan Bateman wrote: >> Hi, this is a proposal to fix 8352728. >> >> The main idea is to replace >> [`java.nio.file.Path::toRealPath`](https://docs.oracle.com/en/java/javase/24/docs/api/java.base/java/nio/file/Path.html#toRealPath(java.nio.file.LinkOption...)) >

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug [v4]

2025-04-14 Thread Bradford Wetmore
On Mon, 14 Apr 2025 18:42:40 GMT, Sean Coffey wrote: >> Breaking the parent JDK-8044609 JBS issue into sub tasks. >> >> This patch addresses the main issue which is that `javax.net.debug=ssl ` >> option is completely broken since TLSv1.3 support was introduced. This >> patch should be easier

Re: RFR: 8325448: Hybrid Public Key Encryption [v15]

2025-04-14 Thread Sean Mullan
On Fri, 11 Apr 2025 20:41:13 GMT, Weijun Wang wrote: >> Implement HPKE as defined in https://datatracker.ietf.org/doc/rfc9180/. >> ![hpke](https://github.com/user-attachments/assets/4edc5d08-ef52-44c5-b5d5-e8890c2d2fce) > > Weijun Wang has updated the pull request incrementally with one additiona

Re: RFR: 8350661: PKCS11 HKDF throws ProviderException when requesting a 31-byte AES key [v2]

2025-04-14 Thread Francisco Ferrari Bihurriet
On Mon, 14 Apr 2025 19:01:00 GMT, Francisco Ferrari Bihurriet wrote: >> For the TlsXXX issue I check the pseudo-mechanism. That works if all >> algorithms are known to the map. I'll check how many we have and see what >> are the pros/cons of having them in the map. I prefer symmetric key >> a

Re: RFR: 8350661: PKCS11 HKDF throws ProviderException when requesting a 31-byte AES key [v2]

2025-04-14 Thread Francisco Ferrari Bihurriet
On Thu, 10 Apr 2025 23:54:03 GMT, Martin Balao wrote: >> Hi, >> >> I would like to request a review for the fix of JDK-8350661. In this fix, we >> translate the native PKCS 11 error code into an >> `InvalidAlgorithmParameterException`, as documented in the `KDF::deriveKey` >> API. With that s

Re: RFR: 8350661: PKCS11 HKDF throws ProviderException when requesting a 31-byte AES key [v2]

2025-04-14 Thread Francisco Ferrari Bihurriet
On Fri, 11 Apr 2025 23:36:17 GMT, Martin Balao wrote: >> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11HKDF.java line >> 246: >> >>> 244: alg.equalsIgnoreCase("Generic")) { >>> 245: return ki.keyType; >>> 246: } >> >> W

Re: RFR: 8348732: SunJCE and SunPKCS11 have different PBE key encodings [v4]

2025-04-14 Thread Valerie Peng
> As part of [https://bugs.openjdk.org/browse/JDK-8301553](JDK-8301553), > SunPKCS11 provider added support for PBE SecretKeyFactories for > `HmacPBESHAxxx` and `PBEWithHmacSHAxxxAndAES_yyy`. These impls produce keys > whose encoding contains the PBKDF2 derived bytes. Given that SunJCE provider

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug [v3]

2025-04-14 Thread Sean Coffey
On Thu, 10 Apr 2025 03:11:42 GMT, Bradford Wetmore wrote: >> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Incorporate latest review feedback > > Depending on the followup discussion of what `ssl` alone means. > > Howeve

Re: RFR: 8350582: Correct the parsing of the ssl value in javax.net.debug [v4]

2025-04-14 Thread Sean Coffey
> Breaking the parent JDK-8044609 JBS issue into sub tasks. > > This patch addresses the main issue which is that `javax.net.debug=ssl ` > option is completely broken since TLSv1.3 support was introduced. This patch > should be easier for backporting also. > > Wider corrections can be followe

Re: RFR: 8354053: Remove unused JavaIOFilePermissionAccess [v2]

2025-04-14 Thread Chen Liang
On Mon, 14 Apr 2025 16:14:03 GMT, Roger Riggs wrote: >> The JavaIOFilePermissionAccess interface is removed from SharedSecrets and >> its implementation (FilePermCompat.java) used by the test is moved to >> java.io FilePermission where cross package access is not needed. >> The test FilePermis

Re: Integrated: 8295803: Console should be usable in jshell and other environments

2025-04-14 Thread Chapman Flack
Hello, This existing email thread seems to hold the most historical context regarding usability of Console in jshell. On 12/07/22 15:52, Naoto Sato wrote: > On Tue, 29 Nov 2022 19:38:02 GMT, Naoto Sato wrote: >> This is to allow Console to be used even when it is not attached > to the platform p

Re: RFR: 8325448: Hybrid Public Key Encryption [v14]

2025-04-14 Thread Sean Mullan
On Wed, 2 Apr 2025 20:35:29 GMT, Weijun Wang wrote: >> Implement HPKE as defined in https://datatracker.ietf.org/doc/rfc9180/. >> ![hpke](https://github.com/user-attachments/assets/4edc5d08-ef52-44c5-b5d5-e8890c2d2fce) > > Weijun Wang has updated the pull request incrementally with two additional

Re: RFR: 8325448: Hybrid Public Key Encryption [v15]

2025-04-14 Thread Sean Mullan
On Fri, 11 Apr 2025 20:41:13 GMT, Weijun Wang wrote: >> Implement HPKE as defined in https://datatracker.ietf.org/doc/rfc9180/. >> ![hpke](https://github.com/user-attachments/assets/4edc5d08-ef52-44c5-b5d5-e8890c2d2fce) > > Weijun Wang has updated the pull request incrementally with one additiona

Re: RFR: 8354053: Remove unused JavaIOFilePermissionAccess [v2]

2025-04-14 Thread Roger Riggs
On Mon, 14 Apr 2025 16:14:03 GMT, Roger Riggs wrote: >> The JavaIOFilePermissionAccess interface is removed from SharedSecrets and >> its implementation (FilePermCompat.java) used by the test is moved to >> java.io FilePermission where cross package access is not needed. >> The test FilePermis

Re: RFR: 8354053: Remove unused JavaIOFilePermissionAccess [v2]

2025-04-14 Thread Roger Riggs
> The JavaIOFilePermissionAccess interface is removed from SharedSecrets and > its implementation (FilePermCompat.java) used by the test is moved to java.io > FilePermission where cross package access is not needed. > The test FilePermissionCollectionMerge is updated to access the internal > im

Re: RFR: 8328914: Document the java.security.debug property in javadoc [v16]

2025-04-14 Thread Sean Mullan
On Thu, 10 Apr 2025 05:09:52 GMT, Koushik Muthukrishnan Thirupattur wrote: >> java.security.debug is a widely used debug system property for JDK security >> libs. It's time to capture details about this property via javadoc. >> >> ![image](https://github.com/user-attachments/assets/b8a589d1-69

Re: RFR: 8350807: Certificates using MD5 algorithm that are disabled by default are incorrectly allowed in TLSv1.3 when re-enabled [v3]

2025-04-14 Thread Artur Barashev
> MD5 algorithm is prohibited by TLSv1.3 RFC to be used in certificates: > > > Any endpoint receiving any certificate which it would need to > validate using any signature algorithm using an MD5 hash MUST abort > the handshake with a "bad_certificate" alert. > > > > The bug manifests itself wh

Integrated: 8354449: Remove com/sun/org/apache/xml/internal/security/resource/xmlsecurity_de.properties

2025-04-14 Thread Sean Mullan
On Fri, 11 Apr 2025 20:34:39 GMT, Sean Mullan wrote: > Workaround for `sed` issue on MacOS 15.4. See > https://bugs.openjdk.org/browse/JDK-8353948 for more details. > > This is a leftover resource file from long ago which serves no purpose, and > has been removed in the next Apache release: >

Re: RFR: 8349400: Improve startup speed via eliminating nested classes [v2]

2025-04-14 Thread Roger Riggs
On Sat, 5 Apr 2025 01:30:49 GMT, Shaojin Wen wrote: >> During JVM startup, the class KnownOIDs is loaded. KnownOIDs has 10 >> anonymous classes, which slows down the startup. This PR is to improve >> KnownOIDs and eliminate unnecessary embedded classes. >> >> >> Here's how to reproduce this:

Re: RFR: 8354053: Remove unused JavaIOFilePermissionAccess

2025-04-14 Thread Roger Riggs
On Fri, 11 Apr 2025 21:26:08 GMT, Roger Riggs wrote: > The JavaIOFilePermissionAccess interface is removed from SharedSecrets and > its implementation (FilePermCompat.java) used by the test is moved to java.io > FilePermission where cross package access is not needed. > The test FilePermission

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v5]

2025-04-14 Thread Daniel Fuchs
On Thu, 10 Apr 2025 21:26:21 GMT, Michael McMahon wrote: >> Hi, >> >> Enhanced exception messages are designed to hide sensitive information such >> as hostnames, IP >> addresses from exception message strings, unless the enhanced mode for the >> specific category >> has been explicitly enab

Re: RFR: 8354449: Remove com/sun/org/apache/xml/internal/security/resource/xmlsecurity_de.properties

2025-04-14 Thread Magnus Ihse Bursie
On Fri, 11 Apr 2025 20:34:39 GMT, Sean Mullan wrote: > Workaround for `sed` issue on MacOS 15.4. See > https://bugs.openjdk.org/browse/JDK-8353948 for more details. > > This is a leftover resource file from long ago which serves no purpose, and > has been removed in the next Apache release: >

Re: RFR: 8349721: Add aarch64 intrinsics for ML-KEM [v7]

2025-04-14 Thread Ferenc Rakoczi
On Thu, 10 Apr 2025 16:50:29 GMT, Andrew Dinn wrote: >> Ferenc Rakoczi has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Code rearrange, some renaming, fixing comments >> - Changes suggested by Andrew Dinn. > > @ferakocz Hi Ferenc. Than

Re: RFR: 8350830: Values converted incorrectly when reading TLS session tickets [v3]

2025-04-14 Thread Nibedita Jena
> Session resumption without server side state was added under > [JDK-8211018](https://bugs.openjdk.org/browse/JDK-8211018). > While it is TLSv1.2 session resumption, the client hello message is being > parsed in SSLSessionImpl for each extensions. > > Customer has reported handshake failure and

Re: RFR: 8350830: Values converted incorrectly when reading TLS session tickets [v3]

2025-04-14 Thread Daniel JeliƄski
On Mon, 14 Apr 2025 12:11:22 GMT, Nibedita Jena wrote: >> Session resumption without server side state was added under >> [JDK-8211018](https://bugs.openjdk.org/browse/JDK-8211018). >> While it is TLSv1.2 session resumption, the client hello message is being >> parsed in SSLSessionImpl for each

Re: RFR: 8354053: Remove unused JavaIOFilePermissionAccess

2025-04-14 Thread Alan Bateman
On Sun, 13 Apr 2025 20:01:28 GMT, Weijun Wang wrote: > I remember the implies method of the file permission class depends on whether > this system property is set. Although file permission is no longer used in > access control check the class and the method are still there. Right, and I wasn't