Re: RFR: 8350661: PKCS11 HKDF throws ProviderException when requesting a 31-byte AES key

2025-04-08 Thread Daniel Jeliński
On Tue, 8 Apr 2025 20:02:56 GMT, Martin Balao wrote: > Hi, > > I would like to request a review for the fix of JDK-8350661. In this fix, we > translate the native PKCS 11 error code into an > `InvalidAlgorithmParameterException`, as documented in the `KDF::deriveKey` > API. With that said, di

Re: RFR: 8353888: Implement Key Derivation Function API [v2]

2025-04-08 Thread Alan Bateman
On Tue, 8 Apr 2025 21:03:18 GMT, Chen Liang wrote: >> Oh, I didn't know that. I've built this with JDK 24 as the boot JDK and see >> no problem. > > I think the dependency is in the CreateSymbols tool or something Yes, we've had issues with boot cycle builds at least, Jan has the details and I

Re: RFR: 8350830: Values converted incorrectly when reading TLS session tickets

2025-04-08 Thread Hendrik Schick
On Wed, 9 Apr 2025 03:28:40 GMT, Nibedita Jena wrote: > Session resumption without server side state was added under > [JDK-8211018](https://bugs.openjdk.org/browse/JDK-8211018). > While it is TLSv1.2 session resumption, the client hello message is being > parsed in SSLSessionImpl for each exte

Re: RFR: 8350830: Values converted incorrectly when reading TLS session tickets

2025-04-08 Thread Hendrik Schick
On Wed, 9 Apr 2025 03:28:40 GMT, Nibedita Jena wrote: > Session resumption without server side state was added under > [JDK-8211018](https://bugs.openjdk.org/browse/JDK-8211018). > While it is TLSv1.2 session resumption, the client hello message is being > parsed in SSLSessionImpl for each exte

RFR: 8350830: Values converted incorrectly when reading TLS session tickets

2025-04-08 Thread Nibedita Jena
Session resumption without server side state was added under [JDK-8211018](https://bugs.openjdk.org/browse/JDK-8211018). While it is TLSv1.2 session resumption, the client hello message is being parsed in SSLSessionImpl for each extensions. Customer has reported handshake failure and is reproduc

Re: RFR: 8353888: Implement Key Derivation Function API [v2]

2025-04-08 Thread Weijun Wang
> Finalize the KDF API. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: add enum back - Changes: - all: https://git.openjdk.org/jdk/pull/24520/files - new: https://git.openjdk.org/jdk/pull/24520/files/4ff3b95b..66706a

Re: RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used [v4]

2025-04-08 Thread TomyLobo
On Tue, 30 Jul 2024 22:24:04 GMT, Weijun Wang wrote: >> There is an error in `jarsigner` on the "This JAR contains signed entries >> that aren't signed by alias in this keystore" warning. The exit code is >> determined by >> [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb

Re: RFR: 8354061: Update copyright in NameFormat.java fix after JDK-8349890

2025-04-08 Thread Chen Liang
On Tue, 8 Apr 2025 17:26:47 GMT, Koushik Muthukrishnan Thirupattur wrote: > Update copyright in NameFormat.java fix after JDK-8353945. Missed to update > when the fix was integrated with JDK-8353945. Marked as reviewed by liach (Reviewer). On second look this is not necessary - this file was

Integrated: 8354061: Update copyright in NameFormat.java fix after JDK-8349890

2025-04-08 Thread Koushik Muthukrishnan Thirupattur
On Tue, 8 Apr 2025 19:44:30 GMT, Koushik Muthukrishnan Thirupattur wrote: > 8354061: Update copyright in NameFormat.java fix after JDK-8349890 This pull request has now been integrated. Changeset: 63fa255c Author:Koushik Thirupattur Committer: Chen Liang URL: https://git.openjdk.o

Re: RFR: 8354061: Update copyright in NameFormat.java fix after JDK-8349890

2025-04-08 Thread Chen Liang
On Tue, 8 Apr 2025 19:44:30 GMT, Koushik Muthukrishnan Thirupattur wrote: > 8354061: Update copyright in NameFormat.java fix after JDK-8349890 This trivial bump looks right. - PR Comment: https://git.openjdk.org/jdk/pull/24523#issuecomment-2787718753

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v14]

2025-04-08 Thread Sandhya Viswanathan
On Tue, 8 Apr 2025 21:27:08 GMT, Ferenc Rakoczi wrote: >> By using the AVX-512 vector registers the speed of the computation of the >> ML-DSA algorithms (key generation, document signing, signature verification) >> can be approximately doubled. > > Ferenc Rakoczi has updated the pull request in

RFR: 8354061: Update copyright in NameFormat.java fix after JDK-8349890

2025-04-08 Thread Koushik Muthukrishnan Thirupattur
Update copyright in NameFormat.java fix after JDK-8353945. Missed to update when the fix was integrated with JDK-8353945. - Commit messages: - 8354061: Update copyright in NameFormat.java fix after JDK-8349890 Changes: https://git.openjdk.org/jdk/pull/24518/files Webrev: https://

Re: RFR: 8349534: Refactor jdk/sun/security/krb5/runNameEquals.sh to java test [v4]

2025-04-08 Thread Mikhail Yankelevich
On Tue, 11 Feb 2025 18:46:29 GMT, Mikhail Yankelevich wrote: >> Refactored the runNameEquals.sh to java test > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > minor Still needs a review - PR Comment: ht

Re: RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v6]

2025-04-08 Thread Mikhail Yankelevich
On Wed, 19 Mar 2025 18:08:40 GMT, Mikhail Yankelevich wrote: >> Moved the sh file logic to jtreg java test. > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > minor: space at the end Still needs a review

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v13]

2025-04-08 Thread Ferenc Rakoczi
On Sat, 5 Apr 2025 00:27:05 GMT, Sandhya Viswanathan wrote: >> Ferenc Rakoczi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Reacting to comment by Sandhya. > > src/hotspot/cpu/x86/stubGenerator_x86_64_dilithium.cpp line 345: > >> 343

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v14]

2025-04-08 Thread Ferenc Rakoczi
> By using the AVX-512 vector registers the speed of the computation of the > ML-DSA algorithms (key generation, document signing, signature verification) > can be approximately doubled. Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision

Re: RFR: 8350661: PKCS11 HKDF throws ProviderException when requesting a 31-byte AES key

2025-04-08 Thread Weijun Wang
On Tue, 8 Apr 2025 20:02:56 GMT, Martin Balao wrote: > Hi, > > I would like to request a review for the fix of JDK-8350661. In this fix, we > translate the native PKCS 11 error code into an > `InvalidAlgorithmParameterException`, as documented in the `KDF::deriveKey` > API. With that said, di

Re: RFR: 8353888: Implement Key Derivation Function API

2025-04-08 Thread Chen Liang
On Tue, 8 Apr 2025 21:00:41 GMT, Weijun Wang wrote: >> src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 82: >> >>> 80: MODULE_IMPORTS, >>> 81: @JEP(number=478, title="Key Derivation Function API", >>> status="Preview") >>> 82: KEY_DERIVATION, >> >

Re: RFR: 8348967: Deprecate security permission classes for removal [v3]

2025-04-08 Thread Roger Riggs
On Tue, 8 Apr 2025 14:23:06 GMT, Sean Mullan wrote: >> Please review this change to terminally deprecate the following security >> related permission classes: `java.security.UnresolvedPermission`, >> `javax.net.ssl.SSLPermission`, `javax.security.auth.AuthPermission`, >> `javax.security.auth.P

Re: RFR: 8350661: PKCS11 HKDF throws ProviderException when requesting a 31-byte AES key

2025-04-08 Thread Martin Balao
On Tue, 8 Apr 2025 20:02:56 GMT, Martin Balao wrote: > Hi, > > I would like to request a review for the fix of JDK-8350661. In this fix, we > translate the native PKCS 11 error code into an > `InvalidAlgorithmParameterException`, as documented in the `KDF::deriveKey` > API. With that said, di

Withdrawn: 8354061: Update copyright in NameFormat.java fix after JDK-8349890

2025-04-08 Thread Koushik Muthukrishnan Thirupattur
On Tue, 8 Apr 2025 17:26:47 GMT, Koushik Muthukrishnan Thirupattur wrote: > Update copyright in NameFormat.java fix after JDK-8353945. Missed to update > when the fix was integrated with JDK-8353945. This pull request has been closed without being integrated. - PR: https://git.op

RFR: 8350661: PKCS11 HKDF throws ProviderException when requesting a 31-byte AES key

2025-04-08 Thread Martin Balao
Hi, I would like to request a review for the fix of JDK-8350661. In this fix, we translate the native PKCS 11 error code into an `InvalidAlgorithmParameterException`, as documented in the `KDF::deriveKey` API. With that said, different PKCS 11 libraries may throw different errors and may even

Re: RFR: 8354061: Update copyright in NameFormat.java fix after JDK-8349890

2025-04-08 Thread duke
On Tue, 8 Apr 2025 19:44:30 GMT, Koushik Muthukrishnan Thirupattur wrote: > 8354061: Update copyright in NameFormat.java fix after JDK-8349890 @koushikthirupattur Your change (at version 1d3078efb8dce8346336d298832b204875b8e71f) is now ready to be sponsored by a Committer. - PR

Re: RFR: 8353888: Implement Key Derivation Function API

2025-04-08 Thread Chen Liang
On Tue, 8 Apr 2025 18:14:53 GMT, Weijun Wang wrote: > Finalize the KDF API. Changes requested by liach (Reviewer). src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 82: > 80: MODULE_IMPORTS, > 81: @JEP(number=478, title="Key Derivation Function API", > st

Re: RFR: 8354061: Update copyright in NameFormat.java fix after JDK-8349890

2025-04-08 Thread Sean Mullan
On Tue, 8 Apr 2025 19:44:30 GMT, Koushik Muthukrishnan Thirupattur wrote: > 8354061: Update copyright in NameFormat.java fix after JDK-8349890 Marked as reviewed by mullan (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/24523#pullrequestreview-2751231196

RFR: 8354061: Update copyright in NameFormat.java fix after JDK-8349890

2025-04-08 Thread Koushik Muthukrishnan Thirupattur
8354061: Update copyright in NameFormat.java fix after JDK-8349890 - Commit messages: - 8354061: Update copyright in NameFormat.java fix after JDK-8349890 Changes: https://git.openjdk.org/jdk/pull/24523/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24523&range=00 Issue:

Re: RFR: 8350459: MontgomeryIntegerPolynomialP256 multiply intrinsic with AVX2 on x86_64 [v8]

2025-04-08 Thread Sean Mullan
On Fri, 4 Apr 2025 15:13:50 GMT, Volodymyr Paprotski wrote: > > > Done I think: https://bugs.openjdk.org/browse/JDK-8297970 > > > > > > Is this link correct? This issue was fixed in JDK 20. > > Sorry.. copy/paste didnt notice.. https://bugs.openjdk.org/browse/JDK-8353670 > (also ends in *70!

RFR: 8353888: Implement Key Derivation Function API

2025-04-08 Thread Weijun Wang
Finalize the KDF API. - Commit messages: - the change Changes: https://git.openjdk.org/jdk/pull/24520/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24520&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8353888 Stats: 42 lines in 16 files changed: 0 ins; 30 del; 12

Integrated: 8348967: Deprecate security permission classes for removal

2025-04-08 Thread Sean Mullan
On Fri, 4 Apr 2025 12:42:36 GMT, Sean Mullan wrote: > Please review this change to terminally deprecate the following security > related permission classes: `java.security.UnresolvedPermission`, > `javax.net.ssl.SSLPermission`, `javax.security.auth.AuthPermission`, > `javax.security.auth.Priva

Re: RFR: 8350705: [JMH] test security.SSLHandshake failed for 2 threads configuration

2025-04-08 Thread Daniel Jeliński
On Mon, 24 Mar 2025 12:54:01 GMT, Daniel Jeliński wrote: > Update the SSLHandshake benchmark to enable running in multiple threads. > > This PR changes the scope of the state from per-benchmark to per-thread. The > server SSLContext is still shared across all threads to simulate the scenario >

Re: RFR: 8353478: Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithms [v2]

2025-04-08 Thread Mark Powers
On Sun, 6 Apr 2025 00:32:17 GMT, Sergey Kuksenko wrote: >> Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithms. > > Sergey Kuksenko has updated the pull request incrementally with one > additional commit since the last revision: > > Update test/micro/org/openjdk/bench/ja

Integrated: 8350705: [JMH] test security.SSLHandshake failed for 2 threads configuration

2025-04-08 Thread Daniel Jeliński
On Mon, 24 Mar 2025 12:54:01 GMT, Daniel Jeliński wrote: > Update the SSLHandshake benchmark to enable running in multiple threads. > > This PR changes the scope of the state from per-benchmark to per-thread. The > server SSLContext is still shared across all threads to simulate the scenario >

Re: RFR: 8348967: Deprecate security permission classes for removal [v3]

2025-04-08 Thread Roger Riggs
On Tue, 8 Apr 2025 14:23:06 GMT, Sean Mullan wrote: >> Please review this change to terminally deprecate the following security >> related permission classes: `java.security.UnresolvedPermission`, >> `javax.net.ssl.SSLPermission`, `javax.security.auth.AuthPermission`, >> `javax.security.auth.P

Re: RFR: 8348967: Deprecate security permission classes for removal [v3]

2025-04-08 Thread Sean Mullan
> Please review this change to terminally deprecate the following security > related permission classes: `java.security.UnresolvedPermission`, > `javax.net.ssl.SSLPermission`, `javax.security.auth.AuthPermission`, > `javax.security.auth.PrivateCredentialPermission`, > `javax.security.auth.kerbe

Re: RFR: 8350705: [JMH] test security.SSLHandshake failed for 2 threads configuration

2025-04-08 Thread Sean Mullan
On Mon, 24 Mar 2025 12:54:01 GMT, Daniel Jeliński wrote: > Update the SSLHandshake benchmark to enable running in multiple threads. > > This PR changes the scope of the state from per-benchmark to per-thread. The > server SSLContext is still shared across all threads to simulate the scenario >

Integrated: 8340321: Disable SHA-1 in TLS/DTLS 1.2 handshake signatures

2025-04-08 Thread Artur Barashev
On Tue, 1 Apr 2025 20:53:01 GMT, Artur Barashev wrote: > Disable SHA-1 in TLS/DTLS 1.2 handshake signatures (but not in certificate > signatures). > https://www.rfc-editor.org/rfc/rfc9155.html > > Also fixing a little TLSv1.3 spec violation bug: ECDSA_SHA1 should not be > allowed for handshake

Re: RFR: 8353641: Deprecate core library permission classes for removal [v8]

2025-04-08 Thread Alan Bateman
On Mon, 7 Apr 2025 18:40:35 GMT, Roger Riggs wrote: >> Now that the Security Manager is permanently disabled, the following >> permission classes in the core libraries area can be deprecated for removal >> as they are no longer useful: FilePermission, LinkPermission, >> LoggingPermission, Prop

Integrated: 8353945: Test javax/security/auth/x500/X500Principal/NameFormat.java fails after JDK-8349890

2025-04-08 Thread Koushik Muthukrishnan Thirupattur
On Tue, 8 Apr 2025 03:10:23 GMT, Koushik Muthukrishnan Thirupattur wrote: > Test javax/security/auth/x500/X500Principal/NameFormat.java fails after > JDK-8349890. The expected results of the failing tests will now change > according to the fix in JDK-8349890. This pull request has now been in

Re: RFR: 8353945: Test javax/security/auth/x500/X500Principal/NameFormat.java fails after JDK-8349890 [v2]

2025-04-08 Thread Koushik Muthukrishnan Thirupattur
> Test javax/security/auth/x500/X500Principal/NameFormat.java fails after > JDK-8349890. The expected results of the failing tests will now change > according to the fix in JDK-8349890. Koushik Muthukrishnan Thirupattur has updated the pull request incrementally with one additional commit since

Re: RFR: 8353945: Test javax/security/auth/x500/X500Principal/NameFormat.java fails after JDK-8349890 [v2]

2025-04-08 Thread duke
On Tue, 8 Apr 2025 03:20:31 GMT, Koushik Muthukrishnan Thirupattur wrote: >> Test javax/security/auth/x500/X500Principal/NameFormat.java fails after >> JDK-8349890. The expected results of the failing tests will now change >> according to the fix in JDK-8349890. > > Koushik Muthukrishnan Thiru