Re: RFR: 8339280: jarsigner -verify performs cross-checking between CEN and LOC [v11]

2025-03-20 Thread Hai-May Chao
> The jarsigner -verify command currently performs verification by reading from > JarFile to navigate the central directory (CEN) headers. It is now enhanced > to include cross-validation of entries between JarFile (CEN-based) and > JarInputStream (stream-based) representations of the JAR. It em

Re: RFR: 8201778: Speed up test javax/net/ssl/DTLS/PacketLossRetransmission.java

2025-03-20 Thread Matthew Donovan
On Mon, 17 Mar 2025 13:19:55 GMT, Fernando Guallini wrote: > The test `javax/net/ssl/DTLS/PacketLossRetransmission` takes about ~2 to > complete. The reason is that, in multiple scenarios, the server/client socket > times out after 10 seconds waiting to receive a DatagramPacket that has been

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v5]

2025-03-20 Thread Ferenc Rakoczi
On Thu, 6 Mar 2025 19:27:12 GMT, Volodymyr Paprotski wrote: >> Ferenc Rakoczi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Accepted review comments. > > src/hotspot/cpu/x86/stubGenerator_x86_64_sha3.cpp line 426: > >> 424: __ subl

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v7]

2025-03-20 Thread Ferenc Rakoczi
On Mon, 17 Mar 2025 19:24:52 GMT, Volodymyr Paprotski wrote: >> Ferenc Rakoczi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Made the intrinsics test separate from the pure java test. > > src/hotspot/cpu/x86/stubGenerator_x86_64_dilit

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v10]

2025-03-20 Thread Ferenc Rakoczi
> By using the AVX-512 vector registers the speed of the computation of the > ML-DSA algorithms (key generation, document signing, signature verification) > can be approximately doubled. Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision

Re: RFR: 8315487: Security Providers Filter [v21]

2025-03-20 Thread Xue-Lei Andrew Fan
On Thu, 20 Feb 2025 20:31:40 GMT, Martin Balao wrote: >> In addition to the goals, scope, motivation, specification and requirement >> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we >> would like to describe the most relevant decisions taken during the >> implementatio

Re: RFR: 8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore [v3]

2025-03-20 Thread Artur Barashev
On Thu, 20 Mar 2025 12:07:54 GMT, Fernando Guallini wrote: >> The following tests are marked with @ignore (not running): >> >> - sun/security/ssl/SSLSocketImpl/SetClientMode.java: it checks that setting >> the clientMode after the handshake has begun is not permitted, but this was >> failing

Re: RFR: 8350459: MontgomeryIntegerPolynomialP256 multiply intrinsic with AVX2 on x86_64 [v4]

2025-03-20 Thread Anthony Scarpino
On Wed, 19 Mar 2025 23:00:55 GMT, Volodymyr Paprotski wrote: >> Randomness isn't idea for reproducibility. If a failure occurs, is it >> obvious what operations were done? I don't see any stdout or stderr >> messages to know what operations happen to bring about a possible failure. > > I use

Re: RFR: 8346129: Simplify EdDSA & XDH curve name usage [v4]

2025-03-20 Thread Anthony Scarpino
On Fri, 14 Mar 2025 19:44:16 GMT, Weijun Wang wrote: >> I'm confused by this comment. With removing the hardcoded aliases in >> AbstractAlgorithmConstraints, which is what I thought you had suggested, >> EdDSA and Ed25519 are now separate as the check is effectively a string >> compare check

Re: RFR: 8346129: Simplify EdDSA & XDH curve name usage [v5]

2025-03-20 Thread Anthony Scarpino
On Tue, 18 Mar 2025 19:14:40 GMT, Artur Barashev wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> check for dup > > src/java.base/share/classes/sun/security/provider/certpath/AlgorithmChecker.java > line 210: >

Re: RFR: 8201778: Speed up test javax/net/ssl/DTLS/PacketLossRetransmission.java

2025-03-20 Thread Fernando Guallini
On Mon, 17 Mar 2025 18:19:46 GMT, Matthew Donovan wrote: >> The test `javax/net/ssl/DTLS/PacketLossRetransmission` takes about ~2 to >> complete. The reason is that, in multiple scenarios, the server/client >> socket times out after 10 seconds waiting to receive a DatagramPacket that >> has

RFR: 8201778: Speed up test javax/net/ssl/DTLS/PacketLossRetransmission.java

2025-03-20 Thread Fernando Guallini
The test `javax/net/ssl/DTLS/PacketLossRetransmission` takes about ~2 to complete. The reason is that, in multiple scenarios, the server/client socket times out after 10 seconds waiting to receive a DatagramPacket that has been removed (to simulate a packet loss). After reducing the time out

Re: RFR: 8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore [v3]

2025-03-20 Thread Fernando Guallini
> The following tests are marked with @ignore (not running): > > - sun/security/ssl/SSLSocketImpl/SetClientMode.java: it checks that setting > the clientMode after the handshake has begun is not permitted, but this was > failing intermittently due to a race condition, it was possible that > Set

Re: RFR: 8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore [v2]

2025-03-20 Thread Fernando Guallini
On Tue, 18 Mar 2025 02:27:31 GMT, Artur Barashev wrote: >> Fernando Guallini has updated the pull request incrementally with one >> additional commit since the last revision: >> >> SSLContextTemplate and using asserts > > test/jdk/sun/security/ssl/SSLSocketImpl/NonAutoClose.java line 65: > >

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v8]

2025-03-20 Thread Ferenc Rakoczi
> By using the AVX-512 vector registers the speed of the computation of the > ML-DSA algorithms (key generation, document signing, signature verification) > can be approximately doubled. Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision