Re: RFR: 8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore [v2]

2025-03-17 Thread Artur Barashev
On Thu, 6 Mar 2025 12:28:19 GMT, Fernando Guallini wrote: >> The following tests are marked with @ignore (not running): >> >> - sun/security/ssl/SSLSocketImpl/SetClientMode.java: it checks that setting >> the clientMode after the handshake has begun is not permitted, but this was >> failing i

Re: RFR: 8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore [v2]

2025-03-17 Thread Artur Barashev
On Thu, 6 Mar 2025 12:28:19 GMT, Fernando Guallini wrote: >> The following tests are marked with @ignore (not running): >> >> - sun/security/ssl/SSLSocketImpl/SetClientMode.java: it checks that setting >> the clientMode after the handshake has begun is not permitted, but this was >> failing i

Re: RFR: 8339280: jarsigner -verify performs cross-checking between CEN and LOC [v6]

2025-03-17 Thread Hai-May Chao
> The jarsigner -verify command currently performs verification by reading from > JarFile to navigate the central directory (CEN) headers. It is now enhanced > to include cross-validation of entries between JarFile (CEN-based) and > JarInputStream (stream-based) representations of the JAR. It em

Re: RFR: 8350459: MontgomeryIntegerPolynomialP256 multiply intrinsic with AVX2 on x86_64 [v4]

2025-03-17 Thread Volodymyr Paprotski
On Mon, 10 Mar 2025 23:07:45 GMT, Volodymyr Paprotski wrote: >> test/jdk/com/sun/security/util/math/intpoly/MontgomeryPolynomialFuzzTest.java >> line 30: >> >>> 28: import sun.security.util.math.intpoly.*; >>> 29: >>> 30: /* >> >> It is strange that there are two copies of the `@test` block.

Re: RFR: 8350459: MontgomeryIntegerPolynomialP256 multiply intrinsic with AVX2 on x86_64 [v5]

2025-03-17 Thread Volodymyr Paprotski
> Add AVX2 montgomery multiplication intrinsic. (About 60-80% gain) > > Also add reduction to existing AVX512 multiplication (this was left-over from > https://github.com/openjdk/jdk/pull/19893 where a quick fix was required). > This is mostly for cleanup, but there is about 1-2% gain. > > Befo

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v5]

2025-03-17 Thread Volodymyr Paprotski
On Thu, 6 Mar 2025 17:37:33 GMT, Ferenc Rakoczi wrote: >> By using the AVX-512 vector registers the speed of the computation of the >> ML-DSA algorithms (key generation, document signing, signature verification) >> can be approximately doubled. > > Ferenc Rakoczi has updated the pull request in

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v7]

2025-03-17 Thread Volodymyr Paprotski
On Wed, 12 Mar 2025 19:19:08 GMT, Ferenc Rakoczi wrote: >> By using the AVX-512 vector registers the speed of the computation of the >> ML-DSA algorithms (key generation, document signing, signature verification) >> can be approximately doubled. > > Ferenc Rakoczi has updated the pull request i

Re: RFR: 8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore [v2]

2025-03-17 Thread Matthew Donovan
On Thu, 6 Mar 2025 12:28:19 GMT, Fernando Guallini wrote: >> The following tests are marked with @ignore (not running): >> >> - sun/security/ssl/SSLSocketImpl/SetClientMode.java: it checks that setting >> the clientMode after the handshake has begun is not permitted, but this was >> failing i

Re: RFR: 8347067: Load certificates without explicit trust settings in KeyChainStore [v3]

2025-03-17 Thread Tim Jacomb
On Mon, 27 Jan 2025 13:06:57 GMT, Sean Mullan wrote: >> Tim Jacomb has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert unneeded change > > This change is significant and should be reviewed by at least 2 Reviewers. Hi @seanjmullan can

Integrated: 8351970: Retire JavaLangAccess::exit

2025-03-17 Thread Roger Riggs
On Fri, 14 Mar 2025 18:31:38 GMT, Roger Riggs wrote: > Cleanup the single use of JavaLangAccess.exit() it is no longer necessary; > System.exit() can be called directly. This pull request has now been integrated. Changeset: 19154f7a Author:Roger Riggs URL: https://git.openjdk.org/j

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v7]

2025-03-17 Thread Leonid Mesnik
On Wed, 12 Mar 2025 19:19:08 GMT, Ferenc Rakoczi wrote: >> By using the AVX-512 vector registers the speed of the computation of the >> ML-DSA algorithms (key generation, document signing, signature verification) >> can be approximately doubled. > > Ferenc Rakoczi has updated the pull request i

Integrated: 8350964: Add an ArtifactResolver.fetch(clazz) method

2025-03-17 Thread Matthew Donovan
On Tue, 11 Mar 2025 15:21:09 GMT, Matthew Donovan wrote: > In this PR, I created a new method, `ArtifactResolver.fetchOne()`, to > consolidate duplicate code across tests. This pull request has now been integrated. Changeset: e62becc6 Author:Matthew Donovan URL: https://git.openjdk

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v6]

2025-03-17 Thread Ferenc Rakoczi
On Wed, 12 Mar 2025 15:34:18 GMT, Leonid Mesnik wrote: >> Ferenc Rakoczi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added validity test for the intrinsics. > > test/jdk/sun/security/provider/acvp/Launcher.java line 43: > >> 41: *

Re: RFR: 8351970: Retire JavaLangAccess::exit

2025-03-17 Thread Daniel JeliƄski
On Fri, 14 Mar 2025 18:31:38 GMT, Roger Riggs wrote: > Cleanup the single use of JavaLangAccess.exit() it is no longer necessary; > System.exit() can be called directly. Marked as reviewed by djelinski (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/24066#pullrequestrevi