Re: RFR: 8348561: Add aarch64 intrinsics for ML-DSA [v5]

2025-02-18 Thread Hao Sun
On Thu, 6 Feb 2025 18:47:54 GMT, Ferenc Rakoczi wrote: >> By using the aarch64 vector registers the speed of the computation of the >> ML-DSA algorithms (key generation, document signing, signature verification) >> can be approximately doubled. > > Ferenc Rakoczi has updated the pull request in

Re: RFR: 8349583: Add mechanism to disable signature schemes based on their TLS scope [v2]

2025-02-18 Thread Artur Barashev
> Currently when a signature scheme constraint is specified with > "jdk.tls.disabledAlgorithms" property we don't differentiate between > signatures used to sign a TLS handshake exchange and the signatures used in > TLS certificates: > https://datatracker.ietf.org/doc/html/rfc8446#section-4.2.3

RFR: 8349583: Add mechanism to disable signature schemes based on their TLS scope

2025-02-18 Thread Artur Barashev
Currently when a signature scheme constraint is specified with "jdk.tls.disabledAlgorithms" property we don't differentiate between signatures used to sign a TLS handshake exchange and the signatures used in TLS certificates: https://datatracker.ietf.org/doc/html/rfc8446#section-4.2.3 -

Re: RFR: 8342238: Test javax/crypto/CryptoPermissions/InconsistentEntries.java writes files in tested JDK dir

2025-02-18 Thread Jamil Nimeh
On Mon, 20 Jan 2025 16:20:27 GMT, Fernando Guallini wrote: > The test javax/crypto/CryptoPermissions/InconsistentEntries.java should not > modify the JDK home directory under test as that could impact the results of > other tests, or it could fail if the JDK home dir is read-only. > > This PR

Re: RFR: 8349664: HEX dump should always use ASCII or ISO_8859_1

2025-02-18 Thread Sean Mullan
On Mon, 17 Feb 2025 11:40:59 GMT, Mikhail Yankelevich wrote: > Changed `HexDumpEncoder`, so `encodeBuffer` always uses ISO_8859_1. > This also fixes the issue with conversion in `encode` method, as the input is > always ISO_8859_1. The fix needs a test or you need to add an appropriate `noreg`

Integrated: 8346050: Update BuildTestLib.gmk to build whole testlibrary

2025-02-18 Thread Leonid Mesnik
On Fri, 7 Feb 2025 21:15:36 GMT, Leonid Mesnik wrote: > The fix add remaining classes to the testlibrary jar and fix some warnings in > security-related classes. This pull request has now been integrated. Changeset: 62d93f2a Author:Leonid Mesnik URL: https://git.openjdk.org/jdk/com

Re: RFR: 8348309: MultiNST tests need more debugging and timing

2025-02-18 Thread Anthony Scarpino
On Tue, 18 Feb 2025 15:48:26 GMT, Matthew Donovan wrote: >> I need a review of this change that adds new timing controls for the initial >> server setup. On rare occasions, more so on certain architectures, the >> server may not fully start before the client tries to connect. Additional >> d

Re: RFR: 8348309: MultiNST tests need more debugging and timing

2025-02-18 Thread Anthony Scarpino
On Tue, 18 Feb 2025 19:42:25 GMT, Anthony Scarpino wrote: >> test/jdk/javax/net/ssl/templates/TLSBase.java line 204: >> >>> 202: write(sock, read(sock)); >>> 203: } catch (Exception e) { >>> 204: System.err.println("Caught " + e.getMessage

Re: RFR: 8348309: MultiNST tests need more debugging and timing

2025-02-18 Thread Anthony Scarpino
On Tue, 18 Feb 2025 15:38:50 GMT, Matthew Donovan wrote: >> I need a review of this change that adds new timing controls for the initial >> server setup. On rare occasions, more so on certain architectures, the >> server may not fully start before the client tries to connect. Additional >> d

Re: RFR: 8342238: Test javax/crypto/CryptoPermissions/InconsistentEntries.java writes files in tested JDK dir

2025-02-18 Thread Jamil Nimeh
On Mon, 17 Feb 2025 18:52:17 GMT, Fernando Guallini wrote: >> The test javax/crypto/CryptoPermissions/InconsistentEntries.java should not >> modify the JDK home directory under test as that could impact the results of >> other tests, or it could fail if the JDK home dir is read-only. >> >> Th

Re: RFR: 8348309: MultiNST tests need more debugging and timing

2025-02-18 Thread Anthony Scarpino
On Sat, 1 Feb 2025 04:20:36 GMT, Anthony Scarpino wrote: > I need a review of this change that adds new timing controls for the initial > server setup. On rare occasions, more so on certain architectures, the > server may not fully start before the client tries to connect. Additional > debug

Re: RFR: 8348309: MultiNST tests need more debugging and timing

2025-02-18 Thread Anthony Scarpino
On Tue, 4 Feb 2025 18:56:05 GMT, Hai-May Chao wrote: >> I need a review of this change that adds new timing controls for the initial >> server setup. On rare occasions, more so on certain architectures, the >> server may not fully start before the client tries to connect. Additional >> debug

Re: RFR: 8346094: Harden X509CertImpl.getExtensionValue for NPE cases [v5]

2025-02-18 Thread Konanki Sreenath
> Earlier code will trigger NPE if the certificate does not contain the > extensions or if the requested extensions does not exist. The better approach > for hardening **getExtensionValue** here is to to check for NULL explicitly > before calling **getExtensionValue()** and avoding try-catch blo

Re: RFR: 8346094: Harden X509CertImpl.getExtensionValue for NPE cases [v4]

2025-02-18 Thread Weijun Wang
On Tue, 18 Feb 2025 11:45:57 GMT, Konanki Sreenath wrote: >> Earlier code will trigger NPE if the certificate does not contain the >> extensions or if the requested extensions does not exist. The better >> approach for hardening **getExtensionValue** here is to to check for NULL >> explicitly

Re: RFR: 8348309: MultiNST tests need more debugging and timing

2025-02-18 Thread Matthew Donovan
On Sat, 1 Feb 2025 04:20:36 GMT, Anthony Scarpino wrote: > I need a review of this change that adds new timing controls for the initial > server setup. On rare occasions, more so on certain architectures, the > server may not fully start before the client tries to connect. Additional > debug

Re: RFR: 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version [v4]

2025-02-18 Thread Rajan Halade
On Mon, 17 Feb 2025 11:06:09 GMT, Fernando Guallini wrote: >> This updates the OpenSSL version that is used by test >> `sun/security/pkcs12/KeytoolOpensslInteropTest.java` to the current LTS >> version (3.0 series). >> There are some differences between the 1.1.x and the current OpenSSL versi

Re: RFR: 8346050: Update BuildTestLib.gmk to build whole testlibrary [v4]

2025-02-18 Thread Weijun Wang
On Fri, 14 Feb 2025 18:22:26 GMT, Leonid Mesnik wrote: >> The fix add remaining classes to the testlibrary jar and fix some warnings >> in security-related classes. > > Leonid Mesnik has updated the pull request incrementally with two additional > commits since the last revision: > > - added

Re: RFR: 8350147: Replace example in KEM class with the one from JEP 452 [v3]

2025-02-18 Thread Sean Mullan
On Sat, 15 Feb 2025 22:33:46 GMT, Bradford Wetmore wrote: >> The example code in the JEP was much clearer than that in the current `KEM` >> class. It's easier to keep the various nested classes straight, rather than >> using `var`s which require scrolling to see what the return types are. >>

Re: RFR: 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version [v4]

2025-02-18 Thread Weijun Wang
On Mon, 17 Feb 2025 11:06:09 GMT, Fernando Guallini wrote: >> This updates the OpenSSL version that is used by test >> `sun/security/pkcs12/KeytoolOpensslInteropTest.java` to the current LTS >> version (3.0 series). >> There are some differences between the 1.1.x and the current OpenSSL versi

Re: RFR: 8346094: Harden X509CertImpl.getExtensionValue for NPE cases [v3]

2025-02-18 Thread Weijun Wang
On Sun, 16 Feb 2025 06:31:50 GMT, Konanki Sreenath wrote: >> Earlier code will trigger NPE if the certificate does not contain the >> extensions or if the requested extensions does not exist. The better >> approach for hardening **getExtensionValue** here is to to check for NULL >> explicitly

Re: RFR: 8348561: Add aarch64 intrinsics for ML-DSA [v5]

2025-02-18 Thread Andrew Dinn
On Thu, 6 Feb 2025 18:47:54 GMT, Ferenc Rakoczi wrote: >> By using the aarch64 vector registers the speed of the computation of the >> ML-DSA algorithms (key generation, document signing, signature verification) >> can be approximately doubled. > > Ferenc Rakoczi has updated the pull request in

Re: RFR: 8348561: Add aarch64 intrinsics for ML-DSA [v5]

2025-02-18 Thread Andrew Dinn
On Thu, 6 Feb 2025 18:47:54 GMT, Ferenc Rakoczi wrote: >> By using the aarch64 vector registers the speed of the computation of the >> ML-DSA algorithms (key generation, document signing, signature verification) >> can be approximately doubled. > > Ferenc Rakoczi has updated the pull request in

Re: RFR: 8346094: Harden X509CertImpl.getExtensionValue for NPE cases [v4]

2025-02-18 Thread Konanki Sreenath
> Earlier code will trigger NPE if the certificate does not contain the > extensions or if the requested extensions does not exist. The better approach > for hardening **getExtensionValue** here is to to check for NULL explicitly > before calling **getExtensionValue()** and avoding try-catch blo