Re: RFR: 8346094: Harden X509CertImpl.getExtensionValue for NPE cases [v3]

2025-02-15 Thread Konanki Sreenath
> Earlier code will trigger NPE if the certificate does not contain the > extensions or if the requested extensions does not exist. The better approach > for hardening **getExtensionValue** here is to to check for NULL explicitly > before calling **getExtensionValue()** and avoding try-catch blo

Re: RFR: 8350147: Replace example in KEM class with the one from JEP 452 [v3]

2025-02-15 Thread Weijun Wang
On Sat, 15 Feb 2025 22:33:46 GMT, Bradford Wetmore wrote: >> The example code in the JEP was much clearer than that in the current `KEM` >> class. It's easier to keep the various nested classes straight, rather than >> using `var`s which require scrolling to see what the return types are. >>

Integrated: 8350147: Replace example in KEM class with the one from JEP 452

2025-02-15 Thread Bradford Wetmore
On Sat, 15 Feb 2025 05:02:44 GMT, Bradford Wetmore wrote: > The example code in the JEP was much clearer than that in the current `KEM` > class. It's easier to keep the various nested classes straight, rather than > using `var`s which require scrolling to see what the return types are. > > A

Re: RFR: 8350147: Replace example in KEM class with the one from JEP 452 [v3]

2025-02-15 Thread Bradford Wetmore
> The example code in the JEP was much clearer than that in the current `KEM` > class. It's easier to keep the various nested classes straight, rather than > using `var`s which require scrolling to see what the return types are. > > Added/tweaked example for clarity. > > Generated/checked jav

Re: RFR: 8350147: Replace example in KEM class with the one from JEP 452 [v2]

2025-02-15 Thread Bradford Wetmore
> The example code in the JEP was much clearer than that in the current `KEM` > class. It's easier to keep the various nested classes straight, rather than > using `var`s which require scrolling to see what the return types are. > > Added/tweaked example for clarity. > > Generated/checked jav

Re: RFR: 8350147: Replace example in KEM class with the one from JEP 452

2025-02-15 Thread Bradford Wetmore
On Sat, 15 Feb 2025 14:28:04 GMT, Weijun Wang wrote: >> The example code in the JEP was much clearer than that in the current `KEM` >> class. It's easier to keep the various nested classes straight, rather than >> using `var`s which require scrolling to see what the return types are. >> >> A

Re: RFR: 8350147: Replace example in KEM class with the one from JEP 452

2025-02-15 Thread Bradford Wetmore
On Sat, 15 Feb 2025 14:28:04 GMT, Weijun Wang wrote: >> The example code in the JEP was much clearer than that in the current `KEM` >> class. It's easier to keep the various nested classes straight, rather than >> using `var`s which require scrolling to see what the return types are. >> >> A

Re: RFR: 8347946: Add API note that caller should validate/trust signers to the getCertificates and getCodeSigners methods of JarEntry and JarURLConnection

2025-02-15 Thread Jaikiran Pai
On Thu, 13 Feb 2025 16:27:03 GMT, Sean Mullan wrote: > This change adds an API note to these methods recommending that the caller > should perform further validation steps on the code signers that signed the > JAR file, such as validating the code signer's certificate chain, and > determining

Re: RFR: 8350147: Replace example in KEM class with the one from JEP 452

2025-02-15 Thread Weijun Wang
On Sat, 15 Feb 2025 05:02:44 GMT, Bradford Wetmore wrote: > The example code in the JEP was much clearer than that in the current `KEM` > class. It's easier to keep the various nested classes straight, rather than > using `var`s which require scrolling to see what the return types are. > > A