Re: RFR: 8346094: Harden X509CertImpl.getExtensionValue for NPE cases [v2]

2025-02-12 Thread Konanki Sreenath
On Mon, 10 Feb 2025 13:37:07 GMT, Weijun Wang wrote: > I take back my word about `extensions` -- it can be null. However, > `X509CertImpl` should never have a null `info`. I’d prefer to add > `Objects.requireNonNull` in its constructor. Your approach of returning null > instead of throwing an

Re: RFR: 8315487: Security Providers Filter [v20]

2025-02-12 Thread Martin Balao
> In addition to the goals, scope, motivation, specification and requirement > notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would > like to describe the most relevant decisions taken during the implementation > of this enhancement. These notes are organized by feature,

Re: RFR: 8267068: Incomplete @throws javadoc for various javax.crypto.spec classes

2025-02-12 Thread Valerie Peng
On Sat, 18 Jan 2025 00:14:58 GMT, Mark Powers wrote: > [JDK-8267068](https://bugs.openjdk.org/browse/JDK-8267068) I didn't see the CSR? Assuming it's not filed yet? We still need to file CSR for documenting existing behavior, but no need to cover the syntax related changes, e.g. to {@code }.

Re: RFR: 8267068: Incomplete @throws javadoc for various javax.crypto.spec classes

2025-02-12 Thread Valerie Peng
On Sat, 18 Jan 2025 00:14:58 GMT, Mark Powers wrote: > [JDK-8267068](https://bugs.openjdk.org/browse/JDK-8267068) src/java.base/share/classes/javax/crypto/spec/IvParameterSpec.java line 73: > 71: * or {@code (iv.length - offset < len)} > 72: * @throws ArrayIndexOutOfBoundsException if

Re: RFR: 8267068: Incomplete @throws javadoc for various javax.crypto.spec classes

2025-02-12 Thread Valerie Peng
On Tue, 21 Jan 2025 15:53:35 GMT, Sean Mullan wrote: >> [JDK-8267068](https://bugs.openjdk.org/browse/JDK-8267068) > > src/java.base/share/classes/javax/crypto/spec/IvParameterSpec.java line 73: > >> 71: * or {@code (iv.length - offset < len)} >> 72: * @throws ArrayIndexOutOfBoundsExce

Re: RFR: 8267068: Incomplete @throws javadoc for various javax.crypto.spec classes

2025-02-12 Thread Valerie Peng
On Wed, 12 Feb 2025 18:37:38 GMT, Valerie Peng wrote: >> src/java.base/share/classes/javax/crypto/spec/IvParameterSpec.java line 73: >> >>> 71: * or {@code (iv.length - offset < len)} >>> 72: * @throws ArrayIndexOutOfBoundsException if {@code offset} >>> 73: * or {@code len} index

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-02-12 Thread Francisco Ferrari Bihurriet
> Hi, this pull request implements the fixes for bugs and inconsistencies > described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix > bugs and inconsistencies in the Provider services map"). > > New services map design > > Here is the high-level hierarchy of the new ser

Re: RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v2]

2025-02-12 Thread Rajan Halade
On Wed, 12 Feb 2025 19:15:46 GMT, Rajan Halade wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> changed the year > > test/jdk/sun/security/pkcs11/Provider/MultipleLogins.java line 63: > >> 61: private st

RFR: 8345598: Upgrade NSS binaries for interop tests

2025-02-12 Thread Matthew Donovan
This is a trivial PR to update the version of NSS used for pkcs11 tests. - Commit messages: - 8345598: Upgrade NSS binaries for interop tests Changes: https://git.openjdk.org/jdk/pull/23594/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23594&range=00 Issue: https://bugs

Re: RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v2]

2025-02-12 Thread Rajan Halade
On Wed, 12 Feb 2025 18:07:48 GMT, Mikhail Yankelevich wrote: >> Moved the sh file logic to jtreg java test. > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > changed the year Changes requested by rhalade (Reviewer).

Integrated: 8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore

2025-02-12 Thread Fernando Guallini
On Wed, 2 Oct 2024 13:24:00 GMT, Fernando Guallini wrote: > The test: **sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java** > relies on the `certutil.exe` tool to import and delete certificates from a > keystore. It was annotated with `@ignore` due to the uncertainty of > `certutil.e

Re: RFR: 8337723: Remove redundant tests from com/sun/security/sasl/gsskerb [v5]

2025-02-12 Thread duke
On Tue, 11 Feb 2025 13:05:48 GMT, Fernando Guallini wrote: >> There are 3 manual GSS-API/Kerberos tests that require a manual setup and >> were added to the problem list years ago: >> >> - com/sun/security/sasl/gsskerb/**AuthOnly**-> Verifies that both client and >> server have completed the

Re: RFR: 8337723: Remove redundant tests from com/sun/security/sasl/gsskerb [v5]

2025-02-12 Thread Rajan Halade
On Tue, 11 Feb 2025 13:05:48 GMT, Fernando Guallini wrote: >> There are 3 manual GSS-API/Kerberos tests that require a manual setup and >> were added to the problem list years ago: >> >> - com/sun/security/sasl/gsskerb/**AuthOnly**-> Verifies that both client and >> server have completed the

Re: RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v2]

2025-02-12 Thread Mikhail Yankelevich
> Moved the sh file logic to jtreg java test. Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: changed the year - Changes: - all: https://git.openjdk.org/jdk/pull/23590/files - new: https://git.openjdk.org/jdk/

RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test

2025-02-12 Thread Mikhail Yankelevich
Moved the sh file logic to jtreg java test. - Commit messages: - 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test Changes: https://git.openjdk.org/jdk/pull/23590/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23590&range=00 Issue: https://bugs.openjdk.o

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v4]

2025-02-12 Thread Francisco Ferrari Bihurriet
On Tue, 11 Feb 2025 23:33:49 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, this pull request implements the fixes for bugs and inconsistencies >> described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix >> bugs and inconsistencies in the Provider services map"). >> >>

Re: RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v14]

2025-02-12 Thread Martin Balao
On Wed, 5 Feb 2025 23:06:54 GMT, Martin Balao wrote: >> We would like to propose an implementation of the HKDF algorithms for >> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key >> Derivation Function API >> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)). >>

Re: RFR: 8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore [v2]

2025-02-12 Thread duke
On Thu, 6 Feb 2025 09:53:04 GMT, Fernando Guallini wrote: >> The test: **sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java** >> relies on the `certutil.exe` tool to import and delete certificates from a >> keystore. It was annotated with `@ignore` due to the uncertainty of >> `certut

Re: RFR: 8346050: Update BuildTestLib.gmk to build whole testlibrary [v3]

2025-02-12 Thread Magnus Ihse Bursie
On Tue, 11 Feb 2025 17:10:37 GMT, Leonid Mesnik wrote: >> The fix add remaining classes to the testlibrary jar and fix some warnings >> in security-related classes. > > Leonid Mesnik has updated the pull request incrementally with two additional > commits since the last revision: > > - Merge

RFR: 8349849: PKCS11 SunTlsKeyMaterial crashes when used with TLS1.2 TlsKeyMaterialParameterSpec

2025-02-12 Thread Daniel Jeliński
Please review this trivial fix that ensures that the mechanism always matches the parameter class type. I added a new test case that crashes without the fix, passes with the fix. Existing tier1-3 test cases continue to pass. - Commit messages: - Fix P11TlsKeyMaterialGenerator cras

Re: RFR: 8267068: Incomplete @throws javadoc for various javax.crypto.spec classes

2025-02-12 Thread Valerie Peng
On Sat, 18 Jan 2025 00:14:58 GMT, Mark Powers wrote: > [JDK-8267068](https://bugs.openjdk.org/browse/JDK-8267068) Didn't get to this until today, will take a look. Thanks! - PR Comment: https://git.openjdk.org/jdk/pull/23188#issuecomment-2653089842