Re: RFR: 8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree [v2]

2025-02-08 Thread Jamil Nimeh
> This takes a few test classes and moves them away from their current location > in `test/jdk/java/security/testlibrary` to `test/lib/jdk/test/lib/security`, > grouping them together with many other existing test utility classes. It > also changes the dependent security tests to point at the n

Re: RFR: 8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree

2025-02-08 Thread Rajan Halade
On Sat, 8 Feb 2025 16:23:59 GMT, Jamil Nimeh wrote: > This takes a few test classes and moves them away from their current location > in `test/jdk/java/security/testlibrary` to `test/lib/jdk/test/lib/security`, > grouping them together with many other existing test utility classes. It > also

Re: RFR: 8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree

2025-02-08 Thread Weijun Wang
On Sat, 8 Feb 2025 16:23:59 GMT, Jamil Nimeh wrote: > This takes a few test classes and moves them away from their current location > in `test/jdk/java/security/testlibrary` to `test/lib/jdk/test/lib/security`, > grouping them together with many other existing test utility classes. It > also

RFR: 8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree

2025-02-08 Thread Jamil Nimeh
This takes a few test classes and moves them away from their current location in `test/jdk/java/security/testlibrary` to `test/lib/jdk/test/lib/security`, grouping them together with many other existing test utility classes. It also changes the dependent security tests to point at the new locat

Re: RFR: 8349400: Improve startup speed via eliminating nested classes

2025-02-08 Thread Shaojin Wen
On Fri, 7 Feb 2025 01:46:03 GMT, Valerie Peng wrote: > > The reproducer you provided doesn't try to load KnownOIDs on my machine. > > What am I missing? > > Other than that, the change looks reasonable to me. > > Me neither and I'm using linux. Are you sure the Startup.java is right? Just > cu

Re: RFR: 8349400: Improve startup speed via eliminating nested classes

2025-02-08 Thread Shaojin Wen
On Thu, 6 Feb 2025 23:45:57 GMT, Johannes Graham wrote: >> you are right, but accessing static field from enum constructor is not >> allowed > > You could define the static field on another class, like SecurityConstants, > and then use it in the enum constructor. Creating a new empty string ar