Re: RFR: 8346050: Update BuildTestLib.gmk to build whole testlibrary [v2]

2025-02-07 Thread Leonid Mesnik
> The fix add remaining classes to the testlibrary jar and fix some warnings in > security-related classes. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: Update make/test/BuildTestLib.gmk Co-authored-by: Erik Joelsson <375974

Re: RFR: 8346050: Update BuildTestLib.gmk to build whole testlibrary

2025-02-07 Thread Erik Joelsson
On Fri, 7 Feb 2025 21:15:36 GMT, Leonid Mesnik wrote: > The fix add remaining classes to the testlibrary jar and fix some warnings in > security-related classes. make/test/BuildTestLib.gmk line 61: > 59: > 60: ifeq ($(call isTargetOs, linux), false) > 61: EXCLUDE_DIRS := jdk/test/lib/cont

RFR: 8348432: Use block size as the default Hmac key length for JDK providers

2025-02-07 Thread Valerie Peng
Could someone help review this straight forward change? Changing to use block size instead of the hash output length as the default Hmac key sizes. The relevant regression tests have been adjusted accordingly as well. Thanks, Valerie - Commit messages: - 8348432: Use block size a

RFR: 8346050: Update BuildTestLib.gmk to build whole testlibrary

2025-02-07 Thread Leonid Mesnik
The fix add remaining classes to the testlibrary jar and fix some warnings in security-related classes. - Commit messages: - 8346050: Update BuildTestLib.gmk to build whole testlibrary Changes: https://git.openjdk.org/jdk/pull/23525/files Webrev: https://webrevs.openjdk.org/?repo

Re: RFR: 8225739: sun/security/pkcs11/tls/tls12/FipsModeTLS12.java is not reliable

2025-02-07 Thread Rajan Halade
On Fri, 17 Jan 2025 17:24:57 GMT, Martin Balao wrote: > Hello, > > I would like to propose a solution for this test that makes it more clear > when it's skipped. > > Regards, > Martin.- Changes requested by rhalade (Reviewer). test/jdk/sun/security/pkcs11/tls/tls12/FipsModeTLS12.java line 95

Re: RFR: 8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore [v2]

2025-02-07 Thread Rajan Halade
On Thu, 6 Feb 2025 09:53:04 GMT, Fernando Guallini wrote: >> The test: **sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java** >> relies on the `certutil.exe` tool to import and delete certificates from a >> keystore. It was annotated with `@ignore` due to the uncertainty of >> `certut

Re: RFR: 8337723: Remove redundant tests from com/sun/security/sasl/gsskerb [v3]

2025-02-07 Thread Rajan Halade
On Tue, 28 Jan 2025 19:25:07 GMT, Fernando Guallini wrote: >> There are 3 manual GSS-API/Kerberos tests that require a manual setup and >> were added to the problem list years ago: >> >> - com/sun/security/sasl/gsskerb/**AuthOnly**-> Verifies that both client and >> server have completed the

Re: RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v14]

2025-02-07 Thread Valerie Peng
On Wed, 5 Feb 2025 23:06:54 GMT, Martin Balao wrote: >> We would like to propose an implementation of the HKDF algorithms for >> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key >> Derivation Function API >> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)). >>

Re: PKCS #12 Support RFC 9579

2025-02-07 Thread Sean Mullan
Hi Davide, Yes, we are working on this and it is being tracked in this issue: https://bugs.openjdk.org/browse/JDK-8343232 Thanks, Sean On 2/7/25 8:56 AM, Davide Malpassini wrote: Hi, RFC 9579 , that add another MAC algorithm to PKCS#12 compatible with FIPS 140-3, has been approved and opens

PKCS #12 Support RFC 9579

2025-02-07 Thread Davide Malpassini
Hi, RFC 9579 , that add another MAC algorithm to PKCS#12 compatible with FIPS 140-3, has been approved and openssl 3.4 , bouncy castle and future redhat 10 already supports it. I want to know the plan to support it and avoid ending with some p12 files that cannot be read by java nut from any other

Re: RFR: 8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore [v2]

2025-02-07 Thread Hai-May Chao
On Thu, 6 Feb 2025 09:53:04 GMT, Fernando Guallini wrote: >> The test: **sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java** >> relies on the `certutil.exe` tool to import and delete certificates from a >> keystore. It was annotated with `@ignore` due to the uncertainty of >> `certut

Integrated: 8349121: SSLParameters.setApplicationProtocols() ALPN example could be clarified

2025-02-07 Thread Bradford Wetmore
On Fri, 31 Jan 2025 01:45:47 GMT, Bradford Wetmore wrote: > Update and clarify the sample code. > > Docs only, no additional testing other than verifying javadoc is correctly > output. This pull request has now been integrated. Changeset: 88a84835 Author:Bradford Wetmore URL: http

Re: RFR: 8349121: SSLParameters.setApplicationProtocols() ALPN example could be clarified [v4]

2025-02-07 Thread Jamil Nimeh
On Thu, 6 Feb 2025 19:31:24 GMT, Bradford Wetmore wrote: >> Update and clarify the sample code. >> >> Docs only, no additional testing other than verifying javadoc is correctly >> output. > > Bradford Wetmore has updated the pull request incrementally with one > additional commit since the las

Integrated: 8349532: Refactor ./util/Pem/encoding.sh to run in java

2025-02-07 Thread Mikhail Yankelevich
On Thu, 6 Feb 2025 12:12:35 GMT, Mikhail Yankelevich wrote: > * ./util/Pem/encoding.sh is now a java test > * also added the validations for the test results, not only an error check This pull request has now been integrated. Changeset: 7cd5cb29 Author:Mikhail Yankelevich Committer: Weijun

Re: RFR: 8346094: Harden X509CertImpl.getExtensionValue for NPE cases

2025-02-07 Thread Sean Mullan
On Thu, 6 Feb 2025 14:36:29 GMT, Weijun Wang wrote: > I'm wondering how necessary this fix is. These are internal classes, only > called inside JDK, where some pre-conditions are always met. Unless someone > explicitly calls `x509Certimpl.getInfo().setExtensions(null)` (as done in the > test),

Re: RFR: 8349532: Refactor ./util/Pem/encoding.sh to run in java [v4]

2025-02-07 Thread duke
On Fri, 7 Feb 2025 14:14:26 GMT, Mikhail Yankelevich wrote: >> * ./util/Pem/encoding.sh is now a java test >> * also added the validations for the test results, not only an error check > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last

Re: RFR: 8349532: Refactor ./util/Pem/encoding.sh to run in java [v4]

2025-02-07 Thread Weijun Wang
On Fri, 7 Feb 2025 14:14:26 GMT, Mikhail Yankelevich wrote: >> * ./util/Pem/encoding.sh is now a java test >> * also added the validations for the test results, not only an error check > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last

Re: RFR: 8349532: Refactor ./util/Pem/encoding.sh to run in java [v3]

2025-02-07 Thread Mikhail Yankelevich
On Fri, 7 Feb 2025 13:50:37 GMT, Weijun Wang wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> removed othervm > > test/jdk/sun/security/util/Pem/PemEncoding.java line 29: > >> 27: * @summary BASE64 encoded

Re: RFR: 8349532: Refactor ./util/Pem/encoding.sh to run in java [v4]

2025-02-07 Thread Mikhail Yankelevich
> * ./util/Pem/encoding.sh is now a java test > * also added the validations for the test results, not only an error check Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: removed run line - Changes: - all: https

Re: RFR: 8349532: Refactor ./util/Pem/encoding.sh to run in java [v3]

2025-02-07 Thread Weijun Wang
On Fri, 7 Feb 2025 13:42:50 GMT, Mikhail Yankelevich wrote: >> * ./util/Pem/encoding.sh is now a java test >> * also added the validations for the test results, not only an error check > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last

Re: RFR: 8349532: Refactor ./util/Pem/encoding.sh to run in java [v3]

2025-02-07 Thread Mikhail Yankelevich
> * ./util/Pem/encoding.sh is now a java test > * also added the validations for the test results, not only an error check Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: removed othervm - Changes: - all: https:

Re: RFR: 8349532: Refactor ./util/Pem/encoding.sh to run in java [v2]

2025-02-07 Thread Mikhail Yankelevich
On Fri, 7 Feb 2025 12:51:36 GMT, Weijun Wang wrote: > Thanks. The updated test runs fine. > > Out of curiosity, I append `.reportDiagnosticSummary()` to the last line in > `main` and see the output string contains garbaged characters. It looks like > although the original fix made it possible

Re: RFR: 8349532: Refactor ./util/Pem/encoding.sh to run in java [v2]

2025-02-07 Thread Mikhail Yankelevich
On Fri, 7 Feb 2025 12:52:45 GMT, Weijun Wang wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> changes to improve readability and removal of unneded System.out.print > > test/jdk/sun/security/util/Pem/PemEncod

Re: RFR: 8349532: Refactor ./util/Pem/encoding.sh to run in java [v2]

2025-02-07 Thread Weijun Wang
On Thu, 6 Feb 2025 18:11:30 GMT, Mikhail Yankelevich wrote: >> * ./util/Pem/encoding.sh is now a java test >> * also added the validations for the test results, not only an error check > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last

Re: RFR: 8349532: Refactor ./util/Pem/encoding.sh to run in java [v2]

2025-02-07 Thread Fernando Guallini
On Thu, 6 Feb 2025 18:11:30 GMT, Mikhail Yankelevich wrote: >> * ./util/Pem/encoding.sh is now a java test >> * also added the validations for the test results, not only an error check > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last