[jdk24] Withdrawn: 8345757: [ASAN] clang17 report 'dprintf' macro redefined

2025-01-22 Thread SendaoYan
On Thu, 26 Dec 2024 02:14:21 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit > [6c591854](https://github.com/openjdk/jdk/commit/6c59185475eeca83153f085eba27cc0b3acf9bb4) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being

Re: [jdk24] RFR: 8345757: [ASAN] clang17 report 'dprintf' macro redefined

2025-01-22 Thread SendaoYan
On Wed, 22 Jan 2025 22:12:15 GMT, Kevin Rushforth wrote: > @sendaoYan This PR should be closed. It does not meet the criteria for > backporting to JDK 24 now that we are in RDP2. Okey. - PR Comment: https://git.openjdk.org/jdk/pull/22883#issuecomment-2608653641

Re: [jdk24] RFR: 8345757: [ASAN] clang17 report 'dprintf' macro redefined

2025-01-22 Thread Kevin Rushforth
On Thu, 26 Dec 2024 02:14:21 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit > [6c591854](https://github.com/openjdk/jdk/commit/6c59185475eeca83153f085eba27cc0b3acf9bb4) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being

Re: RFR: 8339891: Several sun/security/ssl/SSLSessionImpl/* tests override test.java.opts [v3]

2025-01-22 Thread Sonia Zaldana Calles
> Hi all, > > This PR addresses [8339891](https://bugs.openjdk.org/browse/JDK-8339891). > With this patch, "test.java.opts" aggregates on options set via jtreg as > opposed to overriding them. > > Thanks, > Sonia Sonia Zaldana Calles has updated the pull request with a new target base due t

Re: RFR: 8347123: Add missing @serial tags to other modules

2025-01-22 Thread Phil Race
On Wed, 22 Jan 2025 09:23:10 GMT, Hannes Wallnöfer wrote: >> src/java.datatransfer/share/classes/java/awt/datatransfer/DataFlavor.java >> line 1288: >> >>> 1286: >>> 1287: /** >>> 1288: * Serializes this {@code DataFlavor}. >> >> This most definitely changes the serialisation spec. S

RFR: 8348301: Remove unused Reference.waitForReferenceProcessing break-ins in tests

2025-01-22 Thread Aleksey Shipilev
`Reference.waitForReferenceProcessing` is in internal API, which should go away with [JDK-8344332](https://bugs.openjdk.org/browse/JDK-8344332). There is single use of that internal API in the tests, the last use of which was removed by [JDK-8080225](https://bugs.openjdk.org/browse/JDK-8080225).

Re: RFR: 8339891: Several sun/security/ssl/SSLSessionImpl/* tests override test.java.opts [v2]

2025-01-22 Thread Leonid Mesnik
On Wed, 22 Jan 2025 14:00:53 GMT, Sonia Zaldana Calles wrote: >> Hi all, >> >> This PR addresses [8339891](https://bugs.openjdk.org/browse/JDK-8339891). >> With this patch, "test.java.opts" aggregates on options set via jtreg as >> opposed to overriding them. >> >> Thanks, >> Sonia > > So

Re: RFR: 8344316: Add extra line in security/auth/callback/TextCallbackHandler/Password.java to make clear it is not a JTReg test [v6]

2025-01-22 Thread Mikhail Yankelevich
> * Add extra line in security/auth/callback/TextCallbackHandler/Password.java > to make clear it is not a JTReg test > * Test will now fail if run with JTReg Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: changed the test ba

Re: RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v8]

2025-01-22 Thread Sean Mullan
On Tue, 7 Jan 2025 13:50:04 GMT, Sean Mullan wrote: >>> > I'll split this PR and clarify the intention for _Generic_ keys in the >>> > new CSR. @seanjmullan, based on what we discussed with Weijun, would you >>> > be open to making this PR dependent on the _Generic_ one? Otherwise, I'll >>> >

Re: RFR: 8339891: Several sun/security/ssl/SSLSessionImpl/* tests override test.java.opts [v2]

2025-01-22 Thread Sonia Zaldana Calles
> Hi all, > > This PR addresses [8339891](https://bugs.openjdk.org/browse/JDK-8339891). > With this patch, "test.java.opts" aggregates on options set via jtreg as > opposed to overriding them. > > Thanks, > Sonia Sonia Zaldana Calles has updated the pull request incrementally with one addi

Re: RFR: 8347123: Add missing @serial tags to other modules

2025-01-22 Thread Hannes Wallnöfer
On Tue, 21 Jan 2025 19:41:39 GMT, Phil Race wrote: >> Please review a doc-only change to mostly add missing `@serial` javadoc >> tags. This is a sub-task of [JDK-8286931] to allow us to re-enable the >> javadoc `-serialwarn` option in the JDK doc build, which has been disabled >> since JDK 19.