On Thu, 7 Nov 2024 15:44:56 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [8339891](https://bugs.openjdk.org/browse/JDK-8339891).
> With this patch, "test.java.opts" aggregates on options set via jtreg as
> opposed to overriding them.
>
> Thanks,
> Sonia
@SoniaZaldana
On Fri, 17 Jan 2025 21:12:04 GMT, Martin Balao wrote:
>> We would like to propose an implementation of the HKDF algorithms for
>> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key
>> Derivation Function API
>> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)).
>
On Wed, 8 Jan 2025 20:13:50 GMT, Hannes Wallnöfer wrote:
> Please review a doc-only change to mostly add missing `@serial` javadoc tags.
> This is a sub-task of [JDK-8286931] to allow us to re-enable the javadoc
> `-serialwarn` option in the JDK doc build, which has been disabled since JDK
> 1
On Fri, 17 Jan 2025 21:12:04 GMT, Martin Balao wrote:
>> We would like to propose an implementation of the HKDF algorithms for
>> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key
>> Derivation Function API
>> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)).
>
On Fri, 17 Jan 2025 21:12:04 GMT, Martin Balao wrote:
>> We would like to propose an implementation of the HKDF algorithms for
>> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key
>> Derivation Function API
>> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)).
>
On Tue, 21 Jan 2025 18:13:04 GMT, Kevin Driver wrote:
>> Martin Balao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add test case with empty inputs
>>
>> Co-authored-by: Martin Balao Alonso
>> Co-authored-by: Francisco Ferrari
On Thu, 16 Jan 2025 23:38:48 GMT, Naoto Sato wrote:
> This fix is a follow on for
> [JDK-8342550](https://bugs.openjdk.org/browse/JDK-8342550). Replaces/Removes
> usages of those deprecated time zone ids in tests.
This pull request has now been integrated.
Changeset: 81912e95
Author:Naoto
On Fri, 17 Jan 2025 00:45:54 GMT, Naoto Sato wrote:
>> This fix is a follow on for
>> [JDK-8342550](https://bugs.openjdk.org/browse/JDK-8342550). Replaces/Removes
>> usages of those deprecated time zone ids in tests.
>
> Naoto Sato has updated the pull request incrementally with one additional
On Fri, 17 Jan 2025 21:12:04 GMT, Martin Balao wrote:
>> We would like to propose an implementation of the HKDF algorithms for
>> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key
>> Derivation Function API
>> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)).
>
> * Add extra line in security/auth/callback/TextCallbackHandler/Password.java
> to make clear it is not a JTReg test
> * Test will now fail if run with JTReg
Mikhail Yankelevich has updated the pull request incrementally with one
additional commit since the last revision:
reworked the test t
On Tue, 21 Jan 2025 16:29:06 GMT, Mark Powers wrote:
> So a CSR is needed even if the only change is to sync javadoc with the code?
Yes, because that is still considered a specification change to a public API.
-
PR Comment: https://git.openjdk.org/jdk/pull/23188#issuecomment-260523
On Sat, 18 Jan 2025 00:14:58 GMT, Mark Powers wrote:
> [JDK-8267068](https://bugs.openjdk.org/browse/JDK-8267068)
So a CSR is needed even if the only change is to sync javadoc with the code?
-
PR Comment: https://git.openjdk.org/jdk/pull/23188#issuecomment-2605202927
On Sat, 18 Jan 2025 00:14:58 GMT, Mark Powers wrote:
> [JDK-8267068](https://bugs.openjdk.org/browse/JDK-8267068)
@valeriepeng can you also review this? Thanks.
src/java.base/share/classes/javax/crypto/spec/IvParameterSpec.java line 73:
> 71: * or {@code (iv.length - offset < len)}
> 72:
On Sat, 18 Jan 2025 00:14:58 GMT, Mark Powers wrote:
> [JDK-8267068](https://bugs.openjdk.org/browse/JDK-8267068)
This will need a CSR because you are adding a new exception to the
`RC5ParameterSpec` constructor.
-
PR Comment: https://git.openjdk.org/jdk/pull/23188#issuecomment-26
14 matches
Mail list logo