Re: RFR: 8339891: Several sun/security/ssl/SSLSessionImpl/* tests override test.java.opts

2025-01-21 Thread Leonid Mesnik
On Thu, 7 Nov 2024 15:44:56 GMT, Sonia Zaldana Calles wrote: > Hi all, > > This PR addresses [8339891](https://bugs.openjdk.org/browse/JDK-8339891). > With this patch, "test.java.opts" aggregates on options set via jtreg as > opposed to overriding them. > > Thanks, > Sonia @SoniaZaldana

Re: RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v12]

2025-01-21 Thread Valerie Peng
On Fri, 17 Jan 2025 21:12:04 GMT, Martin Balao wrote: >> We would like to propose an implementation of the HKDF algorithms for >> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key >> Derivation Function API >> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)). >

Re: RFR: 8347123: Add missing @serial tags to other modules

2025-01-21 Thread Phil Race
On Wed, 8 Jan 2025 20:13:50 GMT, Hannes Wallnöfer wrote: > Please review a doc-only change to mostly add missing `@serial` javadoc tags. > This is a sub-task of [JDK-8286931] to allow us to re-enable the javadoc > `-serialwarn` option in the JDK doc build, which has been disabled since JDK > 1

Re: RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v12]

2025-01-21 Thread Weijun Wang
On Fri, 17 Jan 2025 21:12:04 GMT, Martin Balao wrote: >> We would like to propose an implementation of the HKDF algorithms for >> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key >> Derivation Function API >> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)). >

Re: RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v12]

2025-01-21 Thread Kevin Driver
On Fri, 17 Jan 2025 21:12:04 GMT, Martin Balao wrote: >> We would like to propose an implementation of the HKDF algorithms for >> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key >> Derivation Function API >> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)). >

Re: RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v12]

2025-01-21 Thread Martin Balao
On Tue, 21 Jan 2025 18:13:04 GMT, Kevin Driver wrote: >> Martin Balao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add test case with empty inputs >> >> Co-authored-by: Martin Balao Alonso >> Co-authored-by: Francisco Ferrari

Integrated: 8347841: Test fixes that use deprecated time zone IDs

2025-01-21 Thread Naoto Sato
On Thu, 16 Jan 2025 23:38:48 GMT, Naoto Sato wrote: > This fix is a follow on for > [JDK-8342550](https://bugs.openjdk.org/browse/JDK-8342550). Replaces/Removes > usages of those deprecated time zone ids in tests. This pull request has now been integrated. Changeset: 81912e95 Author:Naoto

Re: RFR: 8347841: Test fixes that use deprecated time zone IDs [v2]

2025-01-21 Thread Naoto Sato
On Fri, 17 Jan 2025 00:45:54 GMT, Naoto Sato wrote: >> This fix is a follow on for >> [JDK-8342550](https://bugs.openjdk.org/browse/JDK-8342550). Replaces/Removes >> usages of those deprecated time zone ids in tests. > > Naoto Sato has updated the pull request incrementally with one additional

Re: RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v12]

2025-01-21 Thread Kevin Driver
On Fri, 17 Jan 2025 21:12:04 GMT, Martin Balao wrote: >> We would like to propose an implementation of the HKDF algorithms for >> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key >> Derivation Function API >> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)). >

Re: RFR: 8344316: Add extra line in security/auth/callback/TextCallbackHandler/Password.java to make clear it is not a JTReg test [v5]

2025-01-21 Thread Mikhail Yankelevich
> * Add extra line in security/auth/callback/TextCallbackHandler/Password.java > to make clear it is not a JTReg test > * Test will now fail if run with JTReg Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: reworked the test t

Re: RFR: 8267068: Incomplete @throws javadoc for various javax.crypto.spec classes

2025-01-21 Thread Sean Mullan
On Tue, 21 Jan 2025 16:29:06 GMT, Mark Powers wrote: > So a CSR is needed even if the only change is to sync javadoc with the code? Yes, because that is still considered a specification change to a public API. - PR Comment: https://git.openjdk.org/jdk/pull/23188#issuecomment-260523

Re: RFR: 8267068: Incomplete @throws javadoc for various javax.crypto.spec classes

2025-01-21 Thread Mark Powers
On Sat, 18 Jan 2025 00:14:58 GMT, Mark Powers wrote: > [JDK-8267068](https://bugs.openjdk.org/browse/JDK-8267068) So a CSR is needed even if the only change is to sync javadoc with the code? - PR Comment: https://git.openjdk.org/jdk/pull/23188#issuecomment-2605202927

Re: RFR: 8267068: Incomplete @throws javadoc for various javax.crypto.spec classes

2025-01-21 Thread Sean Mullan
On Sat, 18 Jan 2025 00:14:58 GMT, Mark Powers wrote: > [JDK-8267068](https://bugs.openjdk.org/browse/JDK-8267068) @valeriepeng can you also review this? Thanks. src/java.base/share/classes/javax/crypto/spec/IvParameterSpec.java line 73: > 71: * or {@code (iv.length - offset < len)} > 72:

Re: RFR: 8267068: Incomplete @throws javadoc for various javax.crypto.spec classes

2025-01-21 Thread Sean Mullan
On Sat, 18 Jan 2025 00:14:58 GMT, Mark Powers wrote: > [JDK-8267068](https://bugs.openjdk.org/browse/JDK-8267068) This will need a CSR because you are adding a new exception to the `RC5ParameterSpec` constructor. - PR Comment: https://git.openjdk.org/jdk/pull/23188#issuecomment-26