On Fri, 17 Jan 2025 00:42:03 GMT, Naoto Sato wrote:
>> test/jdk/java/util/TimeZone/TimeZoneBoundaryTest.java line 417:
>>
>>> 415: //findBoundariesStepwise(1997, ONE_DAY,
>>> TimeZone.getTimeZone("EST"), 2);
>>> 416: findBoundariesStepwise(1997, ONE_DAY,
>>> TimeZone.getTimeZon
On Fri, 17 Jan 2025 00:45:54 GMT, Naoto Sato wrote:
>> This fix is a follow on for
>> [JDK-8342550](https://bugs.openjdk.org/browse/JDK-8342550). Replaces/Removes
>> usages of those deprecated time zone ids in tests.
>
> Naoto Sato has updated the pull request incrementally with one additional
On Thu, 16 Jan 2025 23:54:04 GMT, Justin Lu wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed extra spaces
>
> test/jdk/java/util/TimeZone/TimeZoneBoundaryTest.java line 417:
>
>> 415: //findBoundaries
> This fix is a follow on for
> [JDK-8342550](https://bugs.openjdk.org/browse/JDK-8342550). Replaces/Removes
> usages of those deprecated time zone ids in tests.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Removed extra spaces
--
On Thu, 16 Jan 2025 23:38:48 GMT, Naoto Sato wrote:
> This fix is a follow on for
> [JDK-8342550](https://bugs.openjdk.org/browse/JDK-8342550). Replaces/Removes
> usages of those deprecated time zone ids in tests.
Looks good.
test/jdk/java/text/Format/DateFormat/DateFormatTest.java line 190:
This fix is a follow on for
[JDK-8342550](https://bugs.openjdk.org/browse/JDK-8342550). Replaces/Removes
usages of those deprecated time zone ids in tests.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/23166/files
Webrev: https://webrevs.openjdk.o
On Tue, 26 Nov 2024 18:49:07 GMT, Alan Bateman wrote:
>> Please review this PR which adds the `final` modifier to non-subclassable
>> classes in `java.base`.
>>
>> The classes were identified using an automated analysis. See CSR for details.
>>
>> Besides simply adding the `final` access modif
On Tue, 26 Nov 2024 20:08:28 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/net/InterfaceAddress.java line 45:
>>
>>> 43:
>>> 44: /*
>>> 45: * Package private constructor. Can't be built directly, instances
>>> are
>>
>> The comment is outdated. This constructor is actua
On Tue, 26 Nov 2024 13:04:41 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which adds the `final` modifier to non-subclassable
> classes in `java.base`.
>
> The classes were identified using an automated analysis. See CSR for details.
>
> Besides simply adding the `final` access modifier,
On Tue, 26 Nov 2024 20:03:39 GMT, Chen Liang wrote:
>> Please review this PR which adds the `final` modifier to non-subclassable
>> classes in `java.base`.
>>
>> The classes were identified using an automated analysis. See CSR for details.
>>
>> Besides simply adding the `final` access modifie
On Tue, 26 Nov 2024 18:00:21 GMT, Chen Liang wrote:
>> Please review this PR which adds the `final` modifier to non-subclassable
>> classes in `java.base`.
>>
>> The classes were identified using an automated analysis. See CSR for details.
>>
>> Besides simply adding the `final` access modifie
On Tue, 26 Nov 2024 19:08:26 GMT, Eirik Bjørsnøs wrote:
>> Thanks! Yes, that's good feedback. There are some non-API changes that I'd
>> like to make, such as this and updating the comment for the
>> `InterfaceAddress` constructor.
>>
>> I prefered to make the initial PR draft contain just the
On Tue, 26 Nov 2024 18:55:50 GMT, Eirik Bjørsnøs wrote:
>> src/java.base/share/classes/java/lang/module/ModuleDescriptor.java line 1318:
>>
>>> 1316: Version version,
>>> 1317: Set modifiers,
>>> 1318: Set requires,
>>
>> I assume y
On Tue, 26 Nov 2024 13:04:41 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which adds the `final` modifier to non-subclassable
> classes in `java.base`.
>
> The classes were identified using an automated analysis. See CSR for details.
>
> Besides simply adding the `final` access modifier,
On Tue, 26 Nov 2024 13:04:41 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which adds the `final` modifier to non-subclassable
> classes in `java.base`.
>
> The classes were identified using an automated analysis. See CSR for details.
>
> Besides simply adding the `final` access modifier,
Please review this PR which adds the `final` modifier to non-subclassable
classes in `java.base`.
The classes were identified using an automated analysis. See CSR for details.
Besides simply adding the `final` access modifier, the PR:
* Updates a note in `java.lang.constant.DynamicCallSiteDesc`
On Tue, 14 Jan 2025 22:41:47 GMT, Jamil Nimeh wrote:
> This makes a small change to the default value of the
> `com.sun.security.ocsp.readtimeout` System property. When not explicitly
> specified, it will be set to the value of the `com.sun.security.ocsp.timeout`
> System property, which help
On Tue, 14 Jan 2025 22:41:47 GMT, Jamil Nimeh wrote:
> This makes a small change to the default value of the
> `com.sun.security.ocsp.readtimeout` System property. When not explicitly
> specified, it will be set to the value of the `com.sun.security.ocsp.timeout`
> System property, which help
On Wed, 17 Jul 2024 20:07:36 GMT, Ben Perez wrote:
> 8261513: Various BasicConstraintsExtension issues
Re-opening PR
-
PR Comment: https://git.openjdk.org/jdk/pull/20224#issuecomment-2596211696
19 matches
Mail list logo
