Re: RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v11]

2025-01-14 Thread Valerie Peng
On Tue, 14 Jan 2025 01:22:30 GMT, Martin Balao wrote: >> We would like to propose an implementation of the HKDF algorithms for >> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key >> Derivation Function API >> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)). >

Re: RFR: 8347597: HttpClient: improve exception reporting when closing connection [v2]

2025-01-14 Thread Jaikiran Pai
On Tue, 14 Jan 2025 20:29:38 GMT, Daniel Fuchs wrote: >> There are a few places in the HttpClient code base where we close the >> connection when some error/exception happens. This can some time trigger a >> race condition where closing the connection in turns causes a "connection >> closed lo

Re: RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v10]

2025-01-14 Thread Valerie Peng
On Mon, 13 Jan 2025 17:12:33 GMT, Francisco Ferrari Bihurriet wrote: >> May be a matter of taste and trade-offs, but I personally lean more towards >> the object-oriented/polymorphic design. While a bit more verbose, I like the >> separation of responsibilities, the closed-world type of transi

Re: RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v8]

2025-01-14 Thread Valerie Peng
On Tue, 7 Jan 2025 16:49:08 GMT, Martin Balao wrote: >> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KDF.java line >> 63: >> >>> 61: }; >>> 62: >>> 63: private static KDFParameters requireNull(KDFParameters >>> kdfParameters, >> >> Would `void` be better since we are

Re: RFR: 8347506: Compatible OCSP readtimeout property with OCSP timeout

2025-01-14 Thread Alexey Bakhtin
On Tue, 14 Jan 2025 22:41:47 GMT, Jamil Nimeh wrote: > This makes a small change to the default value of the > `com.sun.security.ocsp.readtimeout` System property. When not explicitly > specified, it will be set to the value of the `com.sun.security.ocsp.timeout` > System property, which help

[jdk24] RFR: 8347596: Update HSS/LMS public key encoding

2025-01-14 Thread Weijun Wang
8347596: Update HSS/LMS public key encoding - Commit messages: - Backport 0ee6ba9c4c998baeb733363d00db138864f49406 Changes: https://git.openjdk.org/jdk/pull/23119/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23119&range=00 Issue: https://bugs.openjdk.org/browse/JDK-834

Integrated: 8347596: Update HSS/LMS public key encoding

2025-01-14 Thread Weijun Wang
On Mon, 13 Jan 2025 17:42:12 GMT, Weijun Wang wrote: > Update the encoding of HSS/LMS public key to be consistent with > https://www.rfc-editor.org/rfc/rfc9708.html#name-changes-since-rfc-8708 and > https://datatracker.ietf.org/doc/html/draft-ietf-lamps-x509-shbs-13#name-hss-public-keys. This

RFR: 8347506: Compatible OCSP readtimeout property with OCSP timeout

2025-01-14 Thread Jamil Nimeh
This makes a small change to the default value of the `com.sun.security.ocsp.readtimeout` System property. When not explicitly specified, it will be set to the value of the `com.sun.security.ocsp.timeout` System property, which helps ease the transition from older JDK versions where this prope

Re: RFR: 8347596: Update HSS/LMS public key encoding [v3]

2025-01-14 Thread Sean Mullan
On Tue, 14 Jan 2025 02:53:16 GMT, Weijun Wang wrote: >> Update the encoding of HSS/LMS public key to be consistent with >> https://www.rfc-editor.org/rfc/rfc9708.html#name-changes-since-rfc-8708 and >> https://datatracker.ietf.org/doc/html/draft-ietf-lamps-x509-shbs-13#name-hss-public-keys. > >

Re: RFR: 8347597: HttpClient: improve exception reporting when closing connection [v2]

2025-01-14 Thread Daniel Fuchs
On Tue, 14 Jan 2025 09:52:59 GMT, Jaikiran Pai wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review feedback from @japai > > src/java.net.http/share/classes/jdk/internal/net/http/Http1Response.java line > 334: >

Re: RFR: 8347597: HttpClient: improve exception reporting when closing connection [v2]

2025-01-14 Thread Daniel Fuchs
> There are a few places in the HttpClient code base where we close the > connection when some error/exception happens. This can some time trigger a > race condition where closing the connection in turns causes a "connection > closed locally" exception to get reported instead of the original exc

Re: RFR: 8347424: Fix and rewrite sun/security/x509/DNSName/LeadingPeriod.java test

2025-01-14 Thread Ben Perez
On Fri, 10 Jan 2025 12:37:42 GMT, Aleksey Shipilev wrote: > Noticed this when backporting > [JDK-8311546](https://bugs.openjdk.org/browse/JDK-8311546). The test is > actually broken, as it does not include CA cert in the certification path. So > it passes even without the fix, and thus the tes

Re: RFR: 8344316: Add extra line in security/auth/callback/TextCallbackHandler/Password.java to make clear it is not a JTReg test [v3]

2025-01-14 Thread Mikhail Yankelevich
On Fri, 10 Jan 2025 12:21:04 GMT, Mikhail Yankelevich wrote: >> * Add extra line in security/auth/callback/TextCallbackHandler/Password.java >> to make clear it is not a JTReg test >> * Test will now fail if run with JTReg > > Mikhail Yankelevich has updated the pull request incrementally with o

Re: RFR: 8344316: Add extra line in security/auth/callback/TextCallbackHandler/Password.java to make clear it is not a JTReg test [v4]

2025-01-14 Thread Mikhail Yankelevich
> * Add extra line in security/auth/callback/TextCallbackHandler/Password.java > to make clear it is not a JTReg test > * Test will now fail if run with JTReg Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: removed an unnecess

Re: RFR: 8345134: Test sun/security/tools/jarsigner/ConciseJarsigner.java failed: unable to find valid certification path to requested target [v4]

2025-01-14 Thread Weijun Wang
On Mon, 13 Jan 2025 15:20:15 GMT, Mikhail Yankelevich wrote: >> Changed the gencert, so the certificate is now initialised to be with a >> start time of -1M. This prevents a potential error with the certificate not >> yet being valid. >> Similar solution to [this pull >> request](https://gith

Integrated: 8346045: Cleanup of security library tests calling Security Manager APIs

2025-01-14 Thread Sean Mullan
On Mon, 13 Jan 2025 13:36:53 GMT, Sean Mullan wrote: > Some additional removal of calls to SM APIs from security library tests. One > test is removed since it is no longer an issue. This pull request has now been integrated. Changeset: a49f8332 Author:Sean Mullan URL: https://git.o

Re: RFR: 8346045: Cleanup of security library tests calling Security Manager APIs [v2]

2025-01-14 Thread Roger Riggs
On Tue, 14 Jan 2025 13:15:58 GMT, Sean Mullan wrote: >> Some additional removal of calls to SM APIs from security library tests. One >> test is removed since it is no longer an issue. > > Sean Mullan has updated the pull request with a new target base due to a > merge or a rebase. The pull requ

[jdk24] Integrated: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set

2025-01-14 Thread Weijun Wang
On Mon, 13 Jan 2025 22:55:41 GMT, Weijun Wang wrote: > 8342062: Reformat keytool and jarsigner output for keys with a named > parameter set This pull request has now been integrated. Changeset: 57c46ac2 Author:Weijun Wang URL: https://git.openjdk.org/jdk/commit/57c46ac2feefa2064e67

Re: [jdk24] RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set

2025-01-14 Thread Sean Mullan
On Mon, 13 Jan 2025 22:55:41 GMT, Weijun Wang wrote: > 8342062: Reformat keytool and jarsigner output for keys with a named > parameter set Marked as reviewed by mullan (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/23092#pullrequestreview-2549694680

Re: RFR: 8346045: Cleanup of security library tests calling Security Manager APIs [v2]

2025-01-14 Thread Sean Mullan
> Some additional removal of calls to SM APIs from security library tests. One > test is removed since it is no longer an issue. Sean Mullan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge - Initial changes. -

Re: RFR: 8347597: HttpClient: improve exception reporting when closing connection

2025-01-14 Thread Jaikiran Pai
On Mon, 13 Jan 2025 16:07:45 GMT, Daniel Fuchs wrote: > There are a few places in the HttpClient code base where we close the > connection when some error/exception happens. This can some time trigger a > race condition where closing the connection in turns causes a "connection > closed locall

Re: RFR: 8347597: HttpClient: improve exception reporting when closing connection

2025-01-14 Thread Jaikiran Pai
On Mon, 13 Jan 2025 16:07:45 GMT, Daniel Fuchs wrote: > There are a few places in the HttpClient code base where we close the > connection when some error/exception happens. This can some time trigger a > race condition where closing the connection in turns causes a "connection > closed locall