Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v5]

2025-01-09 Thread Weijun Wang
> Traditionally, an asymmetric key has a key size. The size is displayed by > `keytool` and `jarsigner`, both in informational output and weak-key > warnings. However, for the recently added ML-DSA algorithm, key size is not > defined. > > Thus when an ML-DSA key is created, `keytool` shows >

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v4]

2025-01-09 Thread Weijun Wang
> Traditionally, an asymmetric key has a key size. The size is displayed by > `keytool` and `jarsigner`, both in informational output and weak-key > warnings. However, for the recently added ML-DSA algorithm, key size is not > defined. > > Thus when an ML-DSA key is created, `keytool` shows >

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v3]

2025-01-09 Thread Weijun Wang
On Thu, 9 Jan 2025 19:19:11 GMT, Hai-May Chao wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> no more combined output > > src/java.base/share/classes/sun/security/tools/keytool/Main.java line 2074: > >> 2072:

Re: KeychainStore include user and predefined roots within one truststore

2025-01-09 Thread Sean Mullan
On 1/8/25 4:06 AM, Tim Jacomb wrote: TLS handshake fails with PKIX path building error. Chain is Root -> Intermediate -> Leaf in the runnable example although in our real-world use-case its Root -> Intermediate 1 -> Intermediate 2 -> Leaf If I run the example only with Root -> Leaf then it

[jdk24] Integrated: 8347289: HKDF delayed provider selection failed with non-extractable PRK

2025-01-09 Thread Weijun Wang
On Thu, 9 Jan 2025 03:29:37 GMT, Weijun Wang wrote: > 8347289: HKDF delayed provider selection failed with non-extractable PRK This pull request has now been integrated. Changeset: 864d0fde Author:Weijun Wang URL: https://git.openjdk.org/jdk/commit/864d0fde236c80c13a0428e099a6ee2ff6

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v3]

2025-01-09 Thread Hai-May Chao
On Fri, 13 Dec 2024 15:10:15 GMT, Weijun Wang wrote: >> Traditionally, an asymmetric key has a key size. The size is displayed by >> `keytool` and `jarsigner`, both in informational output and weak-key >> warnings. However, for the recently added ML-DSA algorithm, key size is not >> defined. >

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v3]

2025-01-09 Thread Hai-May Chao
On Fri, 13 Dec 2024 15:10:15 GMT, Weijun Wang wrote: >> Traditionally, an asymmetric key has a key size. The size is displayed by >> `keytool` and `jarsigner`, both in informational output and weak-key >> warnings. However, for the recently added ML-DSA algorithm, key size is not >> defined. >

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v3]

2025-01-09 Thread Hai-May Chao
On Fri, 13 Dec 2024 15:10:15 GMT, Weijun Wang wrote: >> Traditionally, an asymmetric key has a key size. The size is displayed by >> `keytool` and `jarsigner`, both in informational output and weak-key >> warnings. However, for the recently added ML-DSA algorithm, key size is not >> defined. >

Re: RFR: 8189441: Define algorithm names for keys derived from KeyAgreement [v15]

2025-01-09 Thread Weijun Wang
> Allow `Generic` as an algorithm in the `KeyAgreement::generateSecret(alg)` > method. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: "secret-key" to "secret key" - Changes: - all: https://git.openjdk.org/jdk/pull/226

Re: RFR: 8345134: Test sun/security/tools/jarsigner/ConciseJarsigner.java failed: unable to find valid certification path to requested target [v3]

2025-01-09 Thread Mikhail Yankelevich
On Thu, 9 Jan 2025 18:19:26 GMT, Rajan Halade wrote: >> Mikhail Yankelevich has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. The pull request >> contains one ne

Re: RFR: 8345134: Test sun/security/tools/jarsigner/ConciseJarsigner.java failed: unable to find valid certification path to requested target [v3]

2025-01-09 Thread Mikhail Yankelevich
> Changed the gencert, so the certificate is now initialised to be with a start > time of -1M. This prevents a potential error with the certificate not yet > being valid. > Similar solution to [this pull > request](https://github.com/openjdk/jdk/pull/22592) > Have tested the test 6000 times for

Re: RFR: 8189441: Define algorithm names for keys derived from KeyAgreement [v14]

2025-01-09 Thread Weijun Wang
> Allow `Generic` as an algorithm in the `KeyAgreement::generateSecret(alg)` > method. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: not supported - Changes: - all: https://git.openjdk.org/jdk/pull/22650/files - ne

Re: RFR: 8345134: Test sun/security/tools/jarsigner/ConciseJarsigner.java failed: unable to find valid certification path to requested target [v2]

2025-01-09 Thread Mikhail Yankelevich
> Changed the gencert, so the certificate is now initialised to be with a start > time of -1M. This prevents a potential error with the certificate not yet > being valid. > Similar solution to [this pull > request](https://github.com/openjdk/jdk/pull/22592) > Have tested the test 6000 times for

Re: [jdk24] RFR: 8347289: HKDF delayed provider selection failed with non-extractable PRK

2025-01-09 Thread Valerie Peng
On Thu, 9 Jan 2025 03:29:37 GMT, Weijun Wang wrote: > 8347289: HKDF delayed provider selection failed with non-extractable PRK Look good. - Marked as reviewed by valeriep (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22995#pullrequestreview-2540649639

Re: RFR: 8345134: Test sun/security/tools/jarsigner/ConciseJarsigner.java failed: unable to find valid certification path to requested target

2025-01-09 Thread Rajan Halade
On Thu, 9 Jan 2025 10:50:44 GMT, Mikhail Yankelevich wrote: > Changed the gencert, so the certificate is now initialised to be with a start > time of -1M. This prevents a potential error with the certificate not yet > being valid. > Similar solution to [this pull > request](https://github.com

Re: RFR: 8315487: Security Providers Filter [v17]

2025-01-09 Thread Sean Mullan
On Thu, 19 Dec 2024 20:48:18 GMT, Martin Balao wrote: >> Martin Balao has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. > > Added a non-goal to the JEP to indicate that secu

Integrated: 8283795: Add TLSv1.3 and CNSA 1.0 algorithms to implementation requirements

2025-01-09 Thread Sean Mullan
On Thu, 2 Jan 2025 14:41:48 GMT, Sean Mullan wrote: > Periodically, we review the security algorithm requirements to see if new > algorithms should be added or existing ones should be removed. The > requirements are intended to improve interoperability across different SE > implementations by

Re: RFR: 8283795: Add TLSv1.3 and CNSA 1.0 algorithms to implementation requirements [v3]

2025-01-09 Thread Jamil Nimeh
On Thu, 9 Jan 2025 14:31:53 GMT, Sean Mullan wrote: >> Periodically, we review the security algorithm requirements to see if new >> algorithms should be added or existing ones should be removed. The >> requirements are intended to improve interoperability across different SE >> implementations

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v3]

2025-01-09 Thread Sean Mullan
On Fri, 13 Dec 2024 15:10:15 GMT, Weijun Wang wrote: >> Traditionally, an asymmetric key has a key size. The size is displayed by >> `keytool` and `jarsigner`, both in informational output and weak-key >> warnings. However, for the recently added ML-DSA algorithm, key size is not >> defined. >

Re: RFR: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set [v3]

2025-01-09 Thread Sean Mullan
On Fri, 13 Dec 2024 15:10:15 GMT, Weijun Wang wrote: >> Traditionally, an asymmetric key has a key size. The size is displayed by >> `keytool` and `jarsigner`, both in informational output and weak-key >> warnings. However, for the recently added ML-DSA algorithm, key size is not >> defined. >

Re: On 8346720: Support Generic keys in SunPKCS11 SecretKeyFactory

2025-01-09 Thread Martin Balao
If it's more clear or easier for you, we can do it. I've re-opened JDK-8346720. We will reference JDK-8346720 in PR #22215's commit for the code changes part. My understanding is that PR #22215 will now be blocked by JDK-8346720's CSR. We look forward to having the CSR for JDK-8346720 reviewed, s

Re: RFR: 8283795: Add TLSv1.3 and CNSA 1.0 algorithms to implementation requirements [v3]

2025-01-09 Thread Sean Mullan
> Periodically, we review the security algorithm requirements to see if new > algorithms should be added or existing ones should be removed. The > requirements are intended to improve interoperability across different SE > implementations by requiring a set of commonly used algorithms. The > al

Integrated: 8347121: Add missing @serial tags to module java.base

2025-01-09 Thread Hannes Wallnöfer
On Wed, 8 Jan 2025 19:41:42 GMT, Hannes Wallnöfer wrote: > Please review a doc-only change to add missing `@serial` javadoc tags in > module `java.base`. This is a sub-task of [JDK-8286931] to allow us to > re-enable the javadoc `-serialwarn` option in the JDK doc build, which has > been disab

RFR: 8345134: Test sun/security/tools/jarsigner/ConciseJarsigner.java failed: unable to find valid certification path to requested target

2025-01-09 Thread Mikhail Yankelevich
Changed the gencert, so the certificate is now initialised to be with a start time of -1M. This prevents a potential error with the certificate not yet being valid. Similar solution to [this pull request](https://github.com/openjdk/jdk/pull/22592) Have tested the test 6000 times for stability a

Re: RFR: 8347121: Add missing @serial tags to module java.base

2025-01-09 Thread Alan Bateman
On Wed, 8 Jan 2025 19:41:42 GMT, Hannes Wallnöfer wrote: > Please review a doc-only change to add missing `@serial` javadoc tags in > module `java.base`. This is a sub-task of [JDK-8286931] to allow us to > re-enable the javadoc `-serialwarn` option in the JDK doc build, which has > been disab