Re: RFR: 8345757: [ASAN] clang17 report 'dprintf' macro redefined [v4]

2024-12-23 Thread SendaoYan
On Mon, 23 Dec 2024 21:30:51 GMT, Kim Barrett wrote: > Looks good to me, but you should get reviews from folks directly involved in > the relevant areas. Okey, thanks. - PR Comment: https://git.openjdk.org/jdk/pull/22630#issuecomment-2560575583

Re: RFR: 8345757: [ASAN] clang17 report 'dprintf' macro redefined [v4]

2024-12-23 Thread SendaoYan
On Mon, 23 Dec 2024 21:28:41 GMT, Kim Barrett wrote: >> SendaoYan has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains five additional commits >> sin

Re: RFR: 8345757: [ASAN] clang17 report 'dprintf' macro redefined [v4]

2024-12-23 Thread Kim Barrett
On Sun, 22 Dec 2024 02:38:31 GMT, SendaoYan wrote: >> Hi all, >> File src/java.smartcardio/share/native/libj2pcsc/pcsc.c and >> src/jdk.crypto.cryptoki/share/native/libj2pkcs11/j2secmod.h generate compile >> warning `'dprintf' macro redefined` by clang17/llvm17 with fastdebug >> configure. Thi

Integrated: 8345840: Add missing TLS handshake messages to SSLHandshake.java

2024-12-23 Thread Bradford Wetmore
On Tue, 10 Dec 2024 06:25:51 GMT, Bradford Wetmore wrote: > SunJSSE has many of the IANA TLS handshake message types defined, but some > are reserved and could be added for debugging output. > > https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml > > Testing coverage: JDK com

Re: RFR: 8345840: Add missing TLS handshake messages to SSLHandshake.java [v3]

2024-12-23 Thread Bradford Wetmore
> SunJSSE has many of the IANA TLS handshake message types defined, but some > are reserved and could be added for debugging output. > > https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml > > Testing coverage: JDK compilation only. Bradford Wetmore has updated the pull reques

Re: RFR: 8345840: Add missing TLS handshake messages to SSLHandshake.java [v3]

2024-12-23 Thread Jamil Nimeh
On Mon, 23 Dec 2024 18:52:58 GMT, Bradford Wetmore wrote: >> SunJSSE has many of the IANA TLS handshake message types defined, but some >> are reserved and could be added for debugging output. >> >> https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml >> >> Testing coverage: J

Re: RFR: 8345840: Add missing TLS handshake messages to SSLHandshake.java [v2]

2024-12-23 Thread Jamil Nimeh
On Mon, 23 Dec 2024 18:47:25 GMT, Bradford Wetmore wrote: >> SunJSSE has many of the IANA TLS handshake message types defined, but some >> are reserved and could be added for debugging output. >> >> https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml >> >> Testing coverage: J

Re: RFR: 8345840: Add missing TLS handshake messages to SSLHandshake.java [v2]

2024-12-23 Thread Bradford Wetmore
> SunJSSE has many of the IANA TLS handshake message types defined, but some > are reserved and could be added for debugging output. > > https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml > > Testing coverage: JDK compilation only. Bradford Wetmore has updated the pull reques

Re: RFR: 8345840: Add missing TLS handshake messages to SSLHandshake.java

2024-12-23 Thread Jamil Nimeh
On Tue, 10 Dec 2024 06:25:51 GMT, Bradford Wetmore wrote: > SunJSSE has many of the IANA TLS handshake message types defined, but some > are reserved and could be added for debugging output. > > https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml > > Testing coverage: JDK com