Re: RFR: 8315487: Security Providers Filter [v13]

2024-12-16 Thread Xue-Lei Andrew Fan
On Mon, 16 Dec 2024 20:41:04 GMT, Anthony Scarpino wrote: > > > It's only the combination of a Provider that overrides > > > getService/getServices + does not call putService/put + overrides > > > newInstance without calling its parent + uses a non-Java SE service type > > > that would be unf

[jdk24] RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-16 Thread Justin Lu
Hi all, This pull request contains a backport of commit [fd0207d5](https://github.com/openjdk/jdk/commit/fd0207d59309ae1af9539580f5bfcbc7627789cb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Justin Lu on 16 Dec 2024 and was review

Integrated: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-16 Thread Justin Lu
On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu wrote: > Please review this PR which contains the open L10n drop changes for RDP1. > > I recommend viewing the improved diffs which are built out by Jon's tool > here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the > correctnes

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update [v3]

2024-12-16 Thread Justin Lu
On Mon, 16 Dec 2024 19:23:55 GMT, Justin Lu wrote: >> Please review this PR which contains the open L10n drop changes for RDP1. >> >> I recommend viewing the improved diffs which are built out by Jon's tool >> here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the >> corr

Re: RFR: 8315487: Security Providers Filter [v13]

2024-12-16 Thread Anthony Scarpino
On Sun, 15 Dec 2024 09:15:10 GMT, Xue-Lei Andrew Fan wrote: > > It's only the combination of a Provider that overrides > > getService/getServices + does not call putService/put + overrides > > newInstance without calling its parent + uses a non-Java SE service type > > that would be unfiltered

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update [v3]

2024-12-16 Thread Naoto Sato
On Mon, 16 Dec 2024 19:20:54 GMT, Justin Lu wrote: >> Please review this PR which contains the open L10n drop changes for RDP1. >> >> I recommend viewing the improved diffs which are built out by Jon's tool >> here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the >> corr

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update [v3]

2024-12-16 Thread Justin Lu
> Please review this PR which contains the open L10n drop changes for RDP1. > > I recommend viewing the improved diffs which are built out by Jon's tool > here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the > correctness on the quality of the translations themselves. >

Integrated: 8346285: Update jarsigner compatibility test for change in default digest algorithm

2024-12-16 Thread Matthew Donovan
On Mon, 16 Dec 2024 14:57:36 GMT, Matthew Donovan wrote: > In this small PR, I updated the jarsigner compatibility test to handle the > difference in default digest algorithms between JDK versions. The previous > default was SHA-256 but has been updated to SHA-384. This pull request has now be

Re: RFR: 8346285: Update jarsigner compatibility test for change in default digest algorithm [v2]

2024-12-16 Thread Weijun Wang
On Mon, 16 Dec 2024 15:29:15 GMT, Matthew Donovan wrote: >> In this small PR, I updated the jarsigner compatibility test to handle the >> difference in default digest algorithms between JDK versions. The previous >> default was SHA-256 but has been updated to SHA-384. > > Matthew Donovan has up

Re: RFR: 8346285: Update jarsigner compatibility test for change in default digest algorithm [v2]

2024-12-16 Thread Matthew Donovan
> In this small PR, I updated the jarsigner compatibility test to handle the > difference in default digest algorithms between JDK versions. The previous > default was SHA-256 but has been updated to SHA-384. Matthew Donovan has updated the pull request incrementally with one additional commit

Re: RFR: 8346285: Update jarsigner compatibility test for change in default digest algorithm [v2]

2024-12-16 Thread Matthew Donovan
On Mon, 16 Dec 2024 15:05:38 GMT, Weijun Wang wrote: >> Matthew Donovan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> updated to use JarSigner.Builder.getDefaultDigestAlgorithm() > > test/jdk/sun/security/tools/jarsigner/compatibility/

Re: RFR: 8346285: Update jarsigner compatibility test for change in default digest algorithm

2024-12-16 Thread Weijun Wang
On Mon, 16 Dec 2024 14:57:36 GMT, Matthew Donovan wrote: > In this small PR, I updated the jarsigner compatibility test to handle the > difference in default digest algorithms between JDK versions. The previous > default was SHA-256 but has been updated to SHA-384. test/jdk/sun/security/tools/

RFR: 8346285: Update jarsigner compatibility test for change in default digest algorithm

2024-12-16 Thread Matthew Donovan
In this small PR, I updated the jarsigner compatibility test to handle the difference in default digest algorithms between JDK versions. The previous default was SHA-256 but has been updated to SHA-384. - Commit messages: - 8346285: Update jarsigner compatibility test for change in