Re: RFR: 8344924: Default CA certificates loaded despite request to use custom keystore

2024-12-06 Thread Alan Bateman
On Fri, 6 Dec 2024 21:15:23 GMT, Kevin Driver wrote: > A regression was introduced by > [JDK-8338383](https://bugs.openjdk.org/browse/JDK-8338383). Remove the forced > static eager initialization. Would it be possible to create some follow-up issues to re-visit the class initialisers and the

Re: RFR: 8344924: Default CA certificates loaded despite request to use custom keystore

2024-12-06 Thread Anthony Scarpino
On Fri, 6 Dec 2024 21:15:23 GMT, Kevin Driver wrote: > A regression was introduced by > [JDK-8338383](https://bugs.openjdk.org/browse/JDK-8338383). Remove the forced > static eager initialization. After reading the comments in the bug from @AlanBateman, removing the code appears to have been

Re: RFR: 8344137: Update XML Security for Java to 3.0.5

2024-12-06 Thread Weijun Wang
On Thu, 5 Dec 2024 20:54:58 GMT, Weijun Wang wrote: > Update XML Signature to Apache Santuario 3.0.5. Thanks. I've created the release note at https://bugs.openjdk.org/browse/JDK-8345729. - PR Comment: https://git.openjdk.org/jdk/pull/22584#issuecomment-2524223240

Re: RFR: 8344137: Update XML Security for Java to 3.0.5

2024-12-06 Thread Sean Mullan
On Thu, 5 Dec 2024 20:54:58 GMT, Weijun Wang wrote: > Update XML Signature to Apache Santuario 3.0.5. Looks good. Please write a release note noting the new SignatureMethod constants for ECDSA with SHA-3. - Marked as reviewed by mullan (Reviewer). PR Review: https://git.openjdk.o

RFR: 8344924: Default CA certificates loaded despite request to use custom keystore

2024-12-06 Thread Kevin Driver
A regression was introduced by [JDK-8338383](https://bugs.openjdk.org/browse/JDK-8338383). Remove the forced static eager initialization. - Commit messages: - trailing whitespace - JDK-8344924: revert change from 8338383 Changes: https://git.openjdk.org/jdk/pull/22616/files Web

Re: RFR: 8315487: Security Providers Filter [v15]

2024-12-06 Thread Francisco Ferrari Bihurriet
On Thu, 5 Dec 2024 20:45:57 GMT, Martin Balao wrote: >> In addition to the goals, scope, motivation, specification and requirement >> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we >> would like to describe the most relevant decisions taken during the >> implementation

Re: RFR: 8315487: Security Providers Filter [v16]

2024-12-06 Thread Martin Balao
> In addition to the goals, scope, motivation, specification and requirement > notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would > like to describe the most relevant decisions taken during the implementation > of this enhancement. These notes are organized by feature,

RFR: 8345139: Fix bugs and inconsistencies in the Provider services map

2024-12-06 Thread Francisco Ferrari Bihurriet
Hi, this pull request implements the fixes for bugs and inconsistencies described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix bugs and inconsistencies in the Provider services map"). New services map design Here is the high-level hierarchy of the new services map desi

Re: RFR: 8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout

2024-12-06 Thread Sean Mullan
On Fri, 6 Dec 2024 01:30:09 GMT, Matthew Donovan wrote: > I was unable to recreate the error but it is probably the same root cause as > JDK-8337951 (https://github.com/openjdk/jdk/pull/20728). > > I updated the gencert command to explicitly set the start date to ensure the > certificate is v

Re: RFR: 8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout

2024-12-06 Thread Hai-May Chao
On Fri, 6 Dec 2024 01:30:09 GMT, Matthew Donovan wrote: > I was unable to recreate the error but it is probably the same root cause as > JDK-8337951 (https://github.com/openjdk/jdk/pull/20728). > > I updated the gencert command to explicitly set the start date to ensure the > certificate is v

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-06 Thread Joe Wang
On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu wrote: > Please review this PR which contains the open L10n drop changes for RDP1. > > I recommend viewing the improved diffs which are built out by Jon's tool > here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the > correctnes

Re: RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v2]

2024-12-06 Thread Weijun Wang
On Mon, 18 Nov 2024 23:01:41 GMT, Martin Balao wrote: >> We would like to propose an implementation of the HKDF algorithms for >> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key >> Derivation Function API >> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)). >

[jdk24] Integrated: 8345414: Google CAInterop test failures

2024-12-06 Thread Fernando Guallini
On Wed, 4 Dec 2024 13:37:32 GMT, Fernando Guallini wrote: > The following tests in CAInterop.java for Google test domain are currently > failing: > > security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 > security/infra/java/security/cert/CertP

Re: RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v2]

2024-12-06 Thread Weijun Wang
On Mon, 18 Nov 2024 23:01:41 GMT, Martin Balao wrote: >> We would like to propose an implementation of the HKDF algorithms for >> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key >> Derivation Function API >> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)). >

Re: [jdk24] RFR: 8345414: Google CAInterop test failures

2024-12-06 Thread duke
On Wed, 4 Dec 2024 13:37:32 GMT, Fernando Guallini wrote: > The following tests in CAInterop.java for Google test domain are currently > failing: > > security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 > security/infra/java/security/cert/CertP

Re: RFR: 8339356: Test javax/net/ssl/SSLSocket/Tls13PacketSize.java failed with java.net.SocketException: An established connection was aborted by the software in your host machine

2024-12-06 Thread Daniel JeliƄski
On Fri, 6 Dec 2024 01:23:31 GMT, Matthew Donovan wrote: > I was unable to reproduce the error but I suspect the error is caused by the > server-side closing the socket as soon as the write operation is done. I > added a read() call on the server to ensure the client initiates connection > clos

Re: RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v2]

2024-12-06 Thread Weijun Wang
On Mon, 18 Nov 2024 23:01:41 GMT, Martin Balao wrote: >> We would like to propose an implementation of the HKDF algorithms for >> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key >> Derivation Function API >> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)). >

Re: [jdk24] RFR: 8345414: Google CAInterop test failures

2024-12-06 Thread Rajan Halade
On Wed, 4 Dec 2024 13:37:32 GMT, Fernando Guallini wrote: > The following tests in CAInterop.java for Google test domain are currently > failing: > > security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 > security/infra/java/security/cert/CertP

[jdk24] RFR: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714

2024-12-06 Thread Chen Liang
Hi all, This pull request contains a backport of commit [49664195](https://github.com/openjdk/jdk/commit/496641955041c5e48359e6256a4a61812653d900) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. This is a test-only change so it is eligible for backport; in addition, this change

Re: RFR: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714 [v2]

2024-12-06 Thread Chen Liang
On Thu, 5 Dec 2024 20:44:59 GMT, Chen Liang wrote: >> Remove the redundant `@enablePreview` and `--enable-preview` flags for >> enabling ClassFile API in the tests. The remainder of these flags in all >> tests seem to serve preview APIs (such as ScopedValue) or language features >> (primitive

Re: RFR: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714 [v2]

2024-12-06 Thread Chen Liang
On Thu, 5 Dec 2024 20:44:59 GMT, Chen Liang wrote: >> Remove the redundant `@enablePreview` and `--enable-preview` flags for >> enabling ClassFile API in the tests. The remainder of these flags in all >> tests seem to serve preview APIs (such as ScopedValue) or language features >> (primitive

Integrated: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714

2024-12-06 Thread Chen Liang
On Wed, 27 Nov 2024 23:10:15 GMT, Chen Liang wrote: > Remove the redundant `@enablePreview` and `--enable-preview` flags for > enabling ClassFile API in the tests. The remainder of these flags in all > tests seem to serve preview APIs (such as ScopedValue) or language features > (primitive pa

Re: RFR: 8329251: Print custom truststore/ keystore name [v13]

2024-12-06 Thread Prasadrao Koppula
On Fri, 6 Dec 2024 11:14:53 GMT, Alan Bateman wrote: > > > Would it possible to list down the API entry points where you want map > > > the InputStream back to its source? I assume methods such as > > > KeyStore.getInstance(File file, ..) are not a concern, is it the > > > load(InputStream,pas

Re: RFR: 8329251: Print custom truststore/ keystore name [v13]

2024-12-06 Thread Alan Bateman
On Fri, 6 Dec 2024 10:55:08 GMT, Prasadrao Koppula wrote: > > Would it possible to list down the API entry points where you want map the > > InputStream back to its source? I assume methods such as > > KeyStore.getInstance(File file, ..) are not a concern, is it the > > load(InputStream,passwo

Re: RFR: 8329251: Print custom truststore/ keystore name [v13]

2024-12-06 Thread Prasadrao Koppula
On Thu, 5 Dec 2024 14:11:29 GMT, Alan Bateman wrote: > Would it possible to list down the API entry points where you want map the > InputStream back to its source? I assume methods such as > KeyStore.getInstance(File file, ..) are not a concern, is it the > load(InputStream,password) method?

Re: [jdk24] RFR: 8345414: Google CAInterop test failures

2024-12-06 Thread Fernando Guallini
On Thu, 5 Dec 2024 18:12:56 GMT, Rajan Halade wrote: > LGTM. Can you target this fix to https://github.com/openjdk/jdk/tree/jdk24 > instead? Done - PR Comment: https://git.openjdk.org/jdk/pull/22542#issuecomment-2522683745