Re: RFR: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714 [v2]

2024-12-05 Thread Adam Sotona
On Thu, 5 Dec 2024 20:44:59 GMT, Chen Liang wrote: >> Remove the redundant `@enablePreview` and `--enable-preview` flags for >> enabling ClassFile API in the tests. The remainder of these flags in all >> tests seem to serve preview APIs (such as ScopedValue) or language features >> (primitive

RFR: 8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout

2024-12-05 Thread Matthew Donovan
I was unable to recreate the error but it is probably the same root cause as JDK-8337951 (https://github.com/openjdk/jdk/pull/20728). I updated the gencert command to explicitly set the start date to ensure the certificate is valid. - Commit messages: - 8345133: Test sun/security

RFR: 8339356: Test javax/net/ssl/SSLSocket/Tls13PacketSize.java failed with java.net.SocketException: An established connection was aborted by the software in your host machine

2024-12-05 Thread Matthew Donovan
I was unable to reproduce the error but I suspect the error is caused by the server-side closing the socket as soon as the write operation is done. I added a read() call on the server to ensure the client initiates connection close - Commit messages: - 8339356: Test javax/net/ssl/S

Re: RFR: 8344137: Update XML Security for Java to 3.0.5

2024-12-05 Thread Weijun Wang
On Thu, 5 Dec 2024 23:18:51 GMT, Mark Powers wrote: > The only thing I noticed were old Oracle copyright dates in some files with > "dom" or "DOM" in their path names. Many contained a single 2005 but at least > one had 2005 plus another date that was not 2024. I don’t update the copyright yea

Re: RFR: 8344137: Update XML Security for Java to 3.0.5

2024-12-05 Thread Weijun Wang
On Thu, 5 Dec 2024 23:07:17 GMT, Mark Powers wrote: >> Update XML Signature to Apache Santuario 3.0.5. > > src/java.xml.crypto/share/legal/santuario.md line 226: > >> 224: >> 225: This product contains software that is >> 226: copyright (c) 2021, 2023, Oracle and/or its affiliates. > > Why not

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-05 Thread Damon Nguyen
On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu wrote: > Please review this PR which contains the open L10n drop changes for RDP1. > > I recommend viewing the improved diffs which are built out by Jon's tool > here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the > correctnes

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-05 Thread Damon Nguyen
On Fri, 6 Dec 2024 00:30:03 GMT, Justin Lu wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac_zh_CN.properties >> line 190: >> >>> 188: javac.opt.Xdoclint.package.args = [-]<程序包>(,[-]<程序包>)* >>> 189: >>> 190: javac.opt.Xdoclint.package.desc=在特定的程序包中启用或禁用检查。每个 >>> 是\

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-05 Thread Justin Lu
On Fri, 6 Dec 2024 00:21:34 GMT, Damon Nguyen wrote: >> Please review this PR which contains the open L10n drop changes for RDP1. >> >> I recommend viewing the improved diffs which are built out by Jon's tool >> here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the >> co

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-05 Thread Justin Lu
On Fri, 6 Dec 2024 00:27:36 GMT, Damon Nguyen wrote: > > Looks generally fine overall. But, looking at the URL for the differences > > in each file per language, I see changes for > > `src/jdk.compiler/share/classes/com/sun/tools/javac/resources/launcher`. I > > don't see any changes for this

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-05 Thread Damon Nguyen
On Fri, 6 Dec 2024 00:24:27 GMT, Damon Nguyen wrote: > Looks generally fine overall. But, looking at the URL for the differences in > each file per language, I see changes for > `src/jdk.compiler/share/classes/com/sun/tools/javac/resources/launcher`. I > don't see any changes for this file in

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-05 Thread Damon Nguyen
On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu wrote: > Please review this PR which contains the open L10n drop changes for RDP1. > > I recommend viewing the improved diffs which are built out by Jon's tool > here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the > correctnes

Re: RFR: 8344137: Update XML Security for Java to 3.0.5

2024-12-05 Thread Mark Powers
On Thu, 5 Dec 2024 20:54:58 GMT, Weijun Wang wrote: > Update XML Signature to Apache Santuario 3.0.5. The only thing I noticed were old Oracle copyright dates in some files with "dom" or "DOM" in their path names. Many contained a single 2005 but at least one had 2005 plus another date that wa

Re: RFR: 8344137: Update XML Security for Java to 3.0.5

2024-12-05 Thread Mark Powers
On Thu, 5 Dec 2024 20:54:58 GMT, Weijun Wang wrote: > Update XML Signature to Apache Santuario 3.0.5. src/java.xml.crypto/share/legal/santuario.md line 226: > 224: > 225: This product contains software that is > 226: copyright (c) 2021, 2023, Oracle and/or its affiliates. Why not 2024? -

Re: RFR: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714 [v2]

2024-12-05 Thread Mandy Chung
On Thu, 5 Dec 2024 20:44:59 GMT, Chen Liang wrote: >> Remove the redundant `@enablePreview` and `--enable-preview` flags for >> enabling ClassFile API in the tests. The remainder of these flags in all >> tests seem to serve preview APIs (such as ScopedValue) or language features >> (primitive

RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-05 Thread Justin Lu
Please review this PR which contains the open L10n drop changes for RDP1. I recommend viewing the improved diffs which are built out by Jon's tool here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the correctness on the quality of the translations themselves. Generally sp

Re: RFR: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714 [v2]

2024-12-05 Thread Chen Liang
On Thu, 5 Dec 2024 22:26:31 GMT, Chen Liang wrote: >> test/langtools/tools/javac/annotations/parameter/ParameterAnnotations.java >> line 643: >> >>> 641: >>> 642: Task.Result result = new JavacTask(tb) >>> 643: .processors(new TestAP()) >> >> I assume this fix does not

Re: RFR: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714 [v2]

2024-12-05 Thread Chen Liang
On Thu, 5 Dec 2024 21:54:19 GMT, Mandy Chung wrote: >> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains two commits: >> >> - Merge branch 'master' of https://github.com/openjdk/jdk into >> cleanup/cf-preview >> - 8334

Re: RFR: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714 [v2]

2024-12-05 Thread Mandy Chung
On Thu, 5 Dec 2024 20:44:59 GMT, Chen Liang wrote: >> Remove the redundant `@enablePreview` and `--enable-preview` flags for >> enabling ClassFile API in the tests. The remainder of these flags in all >> tests seem to serve preview APIs (such as ScopedValue) or language features >> (primitive

Re: Expose native error codes and strings on private Exceptions?

2024-12-05 Thread Sean Mullan
On 11/30/24 8:11 PM, Michael StJohns wrote: Hi - As Java has become more modularized and locked down, I've lost some easy access to critical information in two places - PCSC and PKCS11.  I haven't gone back to dealing with JDBC recently, but I think I might have the same problem there. I

RFR: 8344137: Update XML Security for Java to 3.0.5

2024-12-05 Thread Weijun Wang
Update XML Signature to Apache Santuario 3.0.5. - Commit messages: - the fix Changes: https://git.openjdk.org/jdk/pull/22584/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22584&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344137 Stats: 640 lines in 23 files ch

Re: RFR: 8315487: Security Providers Filter [v15]

2024-12-05 Thread Martin Balao
> In addition to the goals, scope, motivation, specification and requirement > notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would > like to describe the most relevant decisions taken during the implementation > of this enhancement. These notes are organized by feature,

Re: RFR: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714 [v2]

2024-12-05 Thread Chen Liang
> Remove the redundant `@enablePreview` and `--enable-preview` flags for > enabling ClassFile API in the tests. The remainder of these flags in all > tests seem to serve preview APIs (such as ScopedValue) or language features > (primitive pattern, module imports, etc.), or testing the enable pr

Re: RFR: 4936767: Parameters for MessageDigest [v6]

2024-12-05 Thread Weijun Wang
On Mon, 20 Nov 2023 17:08:15 GMT, Weijun Wang wrote: >> Weijun Wang has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - more spec change, restruct SHAKE256.java >> - Revert "throw iape" >> >>This reverts commit d01bf93999d85081734

Re: RFR: 4936767: Parameters for MessageDigest [v6]

2024-12-05 Thread Kevin Driver
On Mon, 20 Nov 2023 17:08:15 GMT, Weijun Wang wrote: >> Weijun Wang has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - more spec change, restruct SHAKE256.java >> - Revert "throw iape" >> >>This reverts commit d01bf93999d85081734

Re: RFR: 8345414: Google CAInterop test failures

2024-12-05 Thread Rajan Halade
On Wed, 4 Dec 2024 13:37:32 GMT, Fernando Guallini wrote: > The following tests in CAInterop.java for Google test domain are currently > failing: > > security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 > security/infra/java/security/cert/CertP

Re: RFR: 8329251: Print custom truststore/ keystore name [v13]

2024-12-05 Thread Alan Bateman
On Wed, 27 Nov 2024 14:39:31 GMT, Prasadrao Koppula wrote: >> Using SharedSecrets, I attempted to expose FileInputStream::path >> information. After implementing the fix, I validated the startup performance >> tests. Observed no consistent pattern of performance drops or gains, can >> disrega

Integrated: 8345578: New test in JDK-8343622 fails with a promoted build

2024-12-05 Thread Weijun Wang
On Thu, 5 Dec 2024 12:41:47 GMT, Weijun Wang wrote: > The test fails with a promoted build because `Utils.` calls > `MessageDigest.getInstance("MD5")` after the SUN provider is removed. > Manually rewrite the functionality of `Utils.runAndCheckException` instead of > using the existing helper

Re: RFR: 8345578: New test in JDK-8343622 fails with a promoted build

2024-12-05 Thread Sean Mullan
On Thu, 5 Dec 2024 12:41:47 GMT, Weijun Wang wrote: > The test fails with a promoted build because `Utils.` calls > `MessageDigest.getInstance("MD5")` after the SUN provider is removed. > Manually rewrite the functionality of `Utils.runAndCheckException` instead of > using the existing helper

RFR: 8345578: New test in JDK-8343622 fails with a promoted build

2024-12-05 Thread Weijun Wang
The test fails with a promoted build because `Utils.` calls `MessageDigest.getInstance("MD5")` after the SUN provider is removed. Manually rewrite the functionality of `Utils.runAndCheckException` instead of using the existing helper method. - Commit messages: - the fix Changes:

Re: RFR: 8345414: Google CAInterop test failures

2024-12-05 Thread Fernando Guallini
On Wed, 4 Dec 2024 14:44:22 GMT, SendaoYan wrote: > Hi, this test has been marked as manual test by > [JDK-8334441](https://bugs.openjdk.org/browse/JDK-8334441). After this PR, > should we mark this test as automatic test. Hi, This test should remain manual, as it still depends on multiple ext

Integrated: 8343622: AesDkCrypto.stringToKey should not return null

2024-12-05 Thread Weijun Wang
On Tue, 5 Nov 2024 15:35:18 GMT, Weijun Wang wrote: > When an exception happens inside these stringToKey() methods, it returns a > null. This would lead to unexpected NPE some time in the future. This pull request has now been integrated. Changeset: ca46c3a5 Author:Weijun Wang URL: