Withdrawn: 8337723: Remove redundant tests from com/sun/security/sasl/gsskerb

2024-11-28 Thread duke
On Mon, 5 Aug 2024 10:46:32 GMT, Fernando Guallini wrote: > There are 3 manual GSS-API/Kerberos tests that require a manual setup and > were added to the problem list years ago: > > - com/sun/security/sasl/gsskerb/**AuthOnly**-> Verifies that both client and > server have completed the authen

Withdrawn: 8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore

2024-11-28 Thread duke
On Wed, 2 Oct 2024 13:24:00 GMT, Fernando Guallini wrote: > The test: **sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java** > relies on the `certutil.exe` tool to import and delete certificates from a > keystore. It was annotated with `@ignore` due to the uncertainty of > `certutil.e

Re: RFR: 8344397: Remove Security Manager dependencies from java.security and sun.security packages [v2]

2024-11-28 Thread Daniel Fuchs
On Wed, 27 Nov 2024 19:59:24 GMT, Sean Mullan wrote: >> Now that JEP 486 has been integrated, `java.security` and `sun.security` >> implementation dependencies on `System.getSecurityManager` and >> `AccessController.doPrivileged` can be removed. >> >> This should cover most of the remaining c

Integrated: 8344299: SM cleanup in javax.naming modules

2024-11-28 Thread Aleksei Efimov
On Thu, 28 Nov 2024 00:17:43 GMT, Aleksei Efimov wrote: > The proposed change cleans-up `SecurityManager`, `doPriviledged`, and > `AccessController` usages from `java.naming`, `jdk.naming.rmi` and > `jdk.naming.dns` modules. > > One noteworthy change: The `java.naming.rmi.security.manager` JND

Re: RFR: 8344299: SM cleanup in javax.naming modules [v3]

2024-11-28 Thread Daniel Fuchs
On Thu, 28 Nov 2024 17:28:59 GMT, Aleksei Efimov wrote: >> The proposed change cleans-up `SecurityManager`, `doPriviledged`, and >> `AccessController` usages from `java.naming`, `jdk.naming.rmi` and >> `jdk.naming.dns` modules. >> >> One noteworthy change: The `java.naming.rmi.security.manager

Re: RFR: 8344299: SM cleanup in javax.naming modules [v2]

2024-11-28 Thread Aleksei Efimov
On Thu, 28 Nov 2024 17:03:13 GMT, Alan Bateman wrote: > Sean has hollowed out SecurityConstants in pull/22418 but had to leave > GET_CLASSLOADER_PERMISSION because of this usage. There will be many rounds > of cleanup so doesn't matter if it comes later. ALL_PERMISSION will probably > be the l

Re: RFR: 8344299: SM cleanup in javax.naming modules [v3]

2024-11-28 Thread Alan Bateman
On Thu, 28 Nov 2024 17:26:04 GMT, Aleksei Efimov wrote: >> The proposed change cleans-up `SecurityManager`, `doPriviledged`, and >> `AccessController` usages from `java.naming`, `jdk.naming.rmi` and >> `jdk.naming.dns` modules. >> >> One noteworthy change: The `java.naming.rmi.security.manager

Re: RFR: 8344299: SM cleanup in javax.naming modules [v3]

2024-11-28 Thread Aleksei Efimov
> The proposed change cleans-up `SecurityManager`, `doPriviledged`, and > `AccessController` usages from `java.naming`, `jdk.naming.rmi` and > `jdk.naming.dns` modules. > > One noteworthy change: The `java.naming.rmi.security.manager` JNDI > environment property can be used to setup the `Securi

Re: RFR: 8344397: Remove Security Manager dependencies from java.security and sun.security packages [v2]

2024-11-28 Thread Alan Bateman
On Wed, 27 Nov 2024 19:59:24 GMT, Sean Mullan wrote: >> Now that JEP 486 has been integrated, `java.security` and `sun.security` >> implementation dependencies on `System.getSecurityManager` and >> `AccessController.doPrivileged` can be removed. >> >> This should cover most of the remaining c

Re: RFR: 8344299: SM cleanup in javax.naming modules [v2]

2024-11-28 Thread Alan Bateman
On Thu, 28 Nov 2024 13:58:58 GMT, Aleksei Efimov wrote: >> The proposed change cleans-up `SecurityManager`, `doPriviledged`, and >> `AccessController` usages from `java.naming`, `jdk.naming.rmi` and >> `jdk.naming.dns` modules. >> >> One noteworthy change: The `java.naming.rmi.security.manager

Re: RFR: 8344299: SM cleanup in javax.naming modules [v2]

2024-11-28 Thread Daniel Fuchs
On Thu, 28 Nov 2024 16:30:36 GMT, Alan Bateman wrote: >> Aleksei Efimov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove com.sun.jndi.ldap.VersionHelper > > src/java.naming/share/classes/com/sun/jndi/ldap/LdapDnsProviderService.jav

Re: RFR: 8344299: SM cleanup in javax.naming modules [v2]

2024-11-28 Thread Daniel Fuchs
On Thu, 28 Nov 2024 13:58:58 GMT, Aleksei Efimov wrote: >> The proposed change cleans-up `SecurityManager`, `doPriviledged`, and >> `AccessController` usages from `java.naming`, `jdk.naming.rmi` and >> `jdk.naming.dns` modules. >> >> One noteworthy change: The `java.naming.rmi.security.manager

Re: RFR: 8344299: SM cleanup in javax.naming modules [v2]

2024-11-28 Thread Alan Bateman
On Thu, 28 Nov 2024 13:58:58 GMT, Aleksei Efimov wrote: >> The proposed change cleans-up `SecurityManager`, `doPriviledged`, and >> `AccessController` usages from `java.naming`, `jdk.naming.rmi` and >> `jdk.naming.dns` modules. >> >> One noteworthy change: The `java.naming.rmi.security.manager

Re: RFR: 8315487: Security Providers Filter [v11]

2024-11-28 Thread Martin Balao
> In addition to the goals, scope, motivation, specification and requirement > notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would > like to describe the most relevant decisions taken during the implementation > of this enhancement. These notes are organized by feature,

Re: RFR: 8344397: Remove Security Manager dependencies from java.security and sun.security packages [v2]

2024-11-28 Thread Francisco Ferrari Bihurriet
On Wed, 27 Nov 2024 19:59:24 GMT, Sean Mullan wrote: >> Now that JEP 486 has been integrated, `java.security` and `sun.security` >> implementation dependencies on `System.getSecurityManager` and >> `AccessController.doPrivileged` can be removed. >> >> This should cover most of the remaining c

Re: RFR: 8345060: Remove Security Manager dependencies from java.security.KeyStore and Identity APIs and implementations [v2]

2024-11-28 Thread Alan Bateman
On Wed, 27 Nov 2024 14:39:21 GMT, Sean Mullan wrote: >> Now that JEP 486 has been integrated, `java.security.KeyStore` and >> `Identity` API and impl dependencies on `System.getSecurityManager`, >> `AccessController.doPrivileged` and `AccessControlContext` can be removed. >> >> Most of the cha

Re: RFR: 8344299: SM cleanup in javax.naming modules

2024-11-28 Thread Aleksei Efimov
On Thu, 28 Nov 2024 07:52:14 GMT, Alan Bateman wrote: > Good cleanup. Maybe for a follow on PR but I assume VersionHelper can be > removed. There's been several post JEP 486 removals that mean that > createThread and loadClass shouldn't be needed now. Also isSerialDataAllowed > could move to O

Re: RFR: 8344299: SM cleanup in javax.naming modules [v2]

2024-11-28 Thread Aleksei Efimov
> The proposed change cleans-up `SecurityManager`, `doPriviledged`, and > `AccessController` usages from `java.naming`, `jdk.naming.rmi` and > `jdk.naming.dns` modules. > > One noteworthy change: The `java.naming.rmi.security.manager` JNDI > environment property can be used to setup the `Securi

Integrated: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation

2024-11-28 Thread rebarbora-mckvak
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote: > This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367 > > If the process does not have write permissions, the store is opened as > read-only (instead of failing). > > Please note that permissions to use a cert

Re: RFR: 8334733: Remove obsolete @enablePreview from tests after JDK-83324714

2024-11-28 Thread Chen Liang
On Wed, 27 Nov 2024 23:10:15 GMT, Chen Liang wrote: > Remove the redundant `@enablePreview` and `--enable-preview` flags for > enabling ClassFile API in the tests. The remainder of these flags in all > tests seem to serve preview APIs (such as ScopedValue) or language features > (primitive pa