Re: RFR: 8345060: Remove Security Manager dependencies from java.security.KeyStore and Identity APIs and implementations

2024-11-26 Thread Hai-May Chao
On Tue, 26 Nov 2024 21:06:14 GMT, Sean Mullan wrote: > Now that JEP 486 has been integrated, `java.security.KeyStore` and `Identity` > API and impl dependencies on `System.getSecurityManager`, > `AccessController.doPrivileged` and `AccessControlContext` can be removed. > > Most of the changes

Re: RFD: Security Providers Filter (JEP)

2024-11-26 Thread Martin Balao
Hello Sean, We've made the following adjustments to the JEP [1]: 1) Paragraphs starting with "When a security provider is installed..." and "The filter applies to services..." replaced with paragraphs starting with "The filter applies to services..." and "Each service is evaluated by...". The

Integrated: 8345057: ML_KEM NamedParameterSpec constants removed by ML-DSA integration

2024-11-26 Thread Valerie Peng
On Tue, 26 Nov 2024 19:04:47 GMT, Valerie Peng wrote: > Could someone please help review this trivial fix? > > The constants for ML-KEM are accidentally removed during merge. This PR adds > them back and adds a test for checking them against the expected ones. This pull request has now been in

RFR: 8345060: Remove Security Manager dependencies from java.security.KeyStore and Identity APIs and implementations

2024-11-26 Thread Sean Mullan
Now that JEP 486 has been integrated, `java.security.KeyStore` and `Identity` API and impl dependencies on `System.getSecurityManager`, `AccessController.doPrivileged` and `AccessControlContext` can be removed. Most of the changes are straightforward, although some of the refactoring in `KeySto

Re: RFR: 8345057: ML_KEM NamedParameterSpec constants removed by ML-DSA integration [v3]

2024-11-26 Thread Sean Mullan
On Tue, 26 Nov 2024 20:33:20 GMT, Valerie Peng wrote: >> Could someone please help review this trivial fix? >> >> The constants for ML-KEM are accidentally removed during merge. This PR adds >> them back and adds a test for checking them against the expected ones. > > Valerie Peng has updated t

Re: RFR: 8345057: ML_KEM NamedParameterSpec constants removed by ML-DSA integration [v2]

2024-11-26 Thread Valerie Peng
On Tue, 26 Nov 2024 19:59:23 GMT, Valerie Peng wrote: >> Could someone please help review this trivial fix? >> >> The constants for ML-KEM are accidentally removed during merge. This PR adds >> them back and adds a test for checking them against the expected ones. > > Valerie Peng has updated t

Re: RFR: 8345057: ML_KEM NamedParameterSpec constants removed by ML-DSA integration [v3]

2024-11-26 Thread Valerie Peng
> Could someone please help review this trivial fix? > > The constants for ML-KEM are accidentally removed during merge. This PR adds > them back and adds a test for checking them against the expected ones. Valerie Peng has updated the pull request incrementally with one additional commit since

Re: RFR: 8345057: ML_KEM NamedParameterSpec constants removed by ML-DSA integration [v2]

2024-11-26 Thread Hai-May Chao
On Tue, 26 Nov 2024 19:59:23 GMT, Valerie Peng wrote: >> Could someone please help review this trivial fix? >> >> The constants for ML-KEM are accidentally removed during merge. This PR adds >> them back and adds a test for checking them against the expected ones. > > Valerie Peng has updated t

Re: RFR: 8345057: ML_KEM NamedParameterSpec constants removed by ML-DSA integration [v2]

2024-11-26 Thread Valerie Peng
> Could someone please help review this trivial fix? > > The constants for ML-KEM are accidentally removed during merge. This PR adds > them back and adds a test for checking them against the expected ones. Valerie Peng has updated the pull request incrementally with one additional commit since

Re: RFR: 8345057: ML_KEM NamedParameterSpec constants removed by ML-DSA integration [v2]

2024-11-26 Thread Valerie Peng
On Tue, 26 Nov 2024 19:25:54 GMT, Sean Mullan wrote: > A few small comments but this looks fine in order to get this fixed quickly. > However, I think it would be better if there were ML-KEM and ML-DSA specific > tests that used the public constants. I think we should followup on that with > B

Re: RFR: 8345057: ML_KEM NamedParameterSpec constants removed by ML-DSA integration

2024-11-26 Thread Sean Mullan
On Tue, 26 Nov 2024 19:04:47 GMT, Valerie Peng wrote: > Could someone please help review this trivial fix? > > The constants for ML-KEM are accidentally removed during merge. This PR adds > them back and adds a test for checking them against the expected ones. A few small comments but this loo

RFR: 8345057: ML_KEM NamedParameterSpec constants removed by ML-DSA integration

2024-11-26 Thread Valerie Peng
Could someone please help review this trivial fix? The constants for ML-KEM are accidentally removed during merge. This PR adds them back and adds a test for checking them against the expected ones. - Commit messages: - 8345057: ML_KEM NamedParameterSpec constants removed by ML-DSA

Integrated: 8344992: Remove Security Manager dependencies from java.security.cert API and implementations

2024-11-26 Thread Sean Mullan
On Mon, 25 Nov 2024 21:22:10 GMT, Sean Mullan wrote: > Now that JEP 486 has been integrated, `java.security.cert` API and impl > dependencies on `AccessController.doPrivileged` can be removed. This pull request has now been integrated. Changeset: c5de3072 Author:Sean Mullan URL: h

Integrated: 8344420: Remove Security Manager dependencies from javax.security package

2024-11-26 Thread Sean Mullan
On Mon, 25 Nov 2024 17:40:12 GMT, Sean Mullan wrote: > Now that JEP 486 has been integrated, the `javax.security` package > implementation dependencies on `System.getSecurityManager`, > `AccessController.doPrivileged` and `AccessControlContext` can be removed. > > Most of the changes are strai

Re: RFR: 8344766: AES/CTR slow at big payloads [v2]

2024-11-26 Thread Volodymyr Paprotski
> This is a follow up to https://github.com/openjdk/jdk/pull/22086 for AES/CTR > > Before: > > Benchmark(algorithm) (dataSize) (keyLength) (provider) > Mode CntScoreError Units > AESBench.decrypt AES/CTR/NoPadding3000 128 SunJCE > thrpt

Integrated: 8344949: javax.security.auth.Subject.SecureSet.writeObject does not do a security check anymore

2024-11-26 Thread Sean Mullan
On Tue, 26 Nov 2024 13:28:14 GMT, Sean Mullan wrote: > The Serial Data section of > `javax.security.auth.Subject.SecureSet.writeObject()` should be removed as it > no longer does a security check now that the Security Manager is permanently > disabled. This pull request has now been integrate

Re: RFR: 8344949: javax.security.auth.Subject.SecureSet.writeObject does not do a security check anymore

2024-11-26 Thread Alan Bateman
On Tue, 26 Nov 2024 13:28:14 GMT, Sean Mullan wrote: > The Serial Data section of > `javax.security.auth.Subject.SecureSet.writeObject()` should be removed as it > no longer does a security check now that the Security Manager is permanently > disabled. Marked as reviewed by alanb (Reviewer).

RFR: 8344949: javax.security.auth.Subject.SecureSet.writeObject does not do a security check anymore

2024-11-26 Thread Sean Mullan
The Serial Data section of `javax.security.auth.Subject.SecureSet.writeObject()` should be removed as it no longer does a security check now that the Security Manager is permanently disabled. - Commit messages: - Remove serialData text. Changes: https://git.openjdk.org/jdk/pull/2

Integrated: 8344419: Use StaticProperty in some JDK classes

2024-11-26 Thread Per Minborg
On Mon, 18 Nov 2024 17:52:04 GMT, Per Minborg wrote: > This PR proposes to use `StaticProperty.javaHome()` instead of > `System.getPropoerty("java.home")` in some internal classes. This pull request has now been integrated. Changeset: fc2da15b Author:Per Minborg URL: https://git.op

Re: RFR: 8344629: SSLSocketNoServerHelloClientShutdown test timeout [v4]

2024-11-26 Thread Artur Barashev
On Tue, 26 Nov 2024 01:11:00 GMT, Bradford Wetmore wrote: >> test/jdk/sun/security/ssl/SSLCipher/SSLSocketNoServerHelloClientShutdown.java >> line 101: >> >>> 99: log(e.toString()); >>> 100: } finally { >>> 101: serverLatch.countDown(); >> >> There s

Integrated: 8344222: Remove calls to SecurityManager and doPrivileged in java.net.HttpURLConnection, java.net.HttpConnectSocketImpl, and javax.net.HttpsURLConnection after JEP 486 integration

2024-11-26 Thread Volkan Yazıcı
On Fri, 22 Nov 2024 14:31:21 GMT, Volkan Yazıcı wrote: > Addresses [8344222](https://bugs.openjdk.org/browse/JDK-8344222) and removes > `SecurityManager` and `doPrivileged()` usages from `Http(s)URLConnection` and > `HttpConnectSocketImpl`. `tier2` and `tier3` results are on their way. This pu

Re: RFR: 8344222: Remove calls to SecurityManager and doPrivileged in java.net.HttpURLConnection, java.net.HttpConnectSocketImpl, and javax.net.HttpsURLConnection after JEP 486 integration [v2]

2024-11-26 Thread Daniel Fuchs
On Mon, 25 Nov 2024 20:06:33 GMT, Volkan Yazıcı wrote: >> Addresses [8344222](https://bugs.openjdk.org/browse/JDK-8344222) and removes >> `SecurityManager` and `doPrivileged()` usages from `Http(s)URLConnection` >> and `HttpConnectSocketImpl`. `tier2` and `tier3` results are on their way. > > V

Re: RFR: 8344222: Remove calls to SecurityManager and doPrivileged in java.net.HttpURLConnection, java.net.HttpConnectSocketImpl, and javax.net.HttpsURLConnection after JEP 486 integration [v2]

2024-11-26 Thread Jaikiran Pai
On Mon, 25 Nov 2024 20:06:33 GMT, Volkan Yazıcı wrote: >> Addresses [8344222](https://bugs.openjdk.org/browse/JDK-8344222) and removes >> `SecurityManager` and `doPrivileged()` usages from `Http(s)URLConnection` >> and `HttpConnectSocketImpl`. `tier2` and `tier3` results are on their way. > > V

Re: RFR: 8329251: Print custom truststore/ keystore name [v12]

2024-11-26 Thread Prasadrao Koppula
> Using SharedSecrets, I attempted to expose FileInputStream::path information. > After implementing the fix, I validated the startup performance tests. > Observed no consistent pattern of performance drops or gains, can disregard > the occasional performance drop observed in 1 or 2 runs. Prasa