Re: RFR: 8344882: (bf) Temporary direct buffers should not count against the upper limit on direct buffer memory

2024-11-22 Thread ExE Boss
On Fri, 22 Nov 2024 23:44:11 GMT, Brian Burkhalter wrote: > Make the memory used by internal temporary direct buffers not count towards > the upper limit on direct buffer memory. src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template line 77: > 75: static final boolean UNALIGNE

Re: RFR: 8344882: (bf) Temporary direct buffers should not count against the upper limit on direct buffer memory

2024-11-22 Thread Brian Burkhalter
On Sat, 23 Nov 2024 01:03:25 GMT, ExE Boss wrote: >> Make the memory used by internal temporary direct buffers not count towards >> the upper limit on direct buffer memory. > > src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template line 77: > >> 75: static final boolean UNALIGNE

RFR: 8344882: (bf) Temporary direct buffers should not count against the upper limit on direct buffer memory

2024-11-22 Thread Brian Burkhalter
Make the memory used by internal temporary direct buffers not count towards the upper limit on direct buffer memory. - Commit messages: - 8344882: (bf) Temporary direct buffers should not count against the upper limit on direct buffer memory Changes: https://git.openjdk.org/jdk/pu

Re: RFR: 8344882: (bf) Temporary direct buffers should not count against the upper limit on direct buffer memory

2024-11-22 Thread Brian Burkhalter
On Fri, 22 Nov 2024 23:44:11 GMT, Brian Burkhalter wrote: > Make the memory used by internal temporary direct buffers not count towards > the upper limit on direct buffer memory. This change should also fix [JDK-8340728](https://bugs.openjdk.org/browse/JDK-8340728) and [JDK-8342849](https://b

Re: RFR: 8344629: SSLSocketNoServerHelloClientShutdown test timeout [v3]

2024-11-22 Thread Bradford Wetmore
On Fri, 22 Nov 2024 18:31:11 GMT, Artur Barashev wrote: >> test/jdk/sun/security/ssl/SSLCipher/SSLSocketNoServerHelloClientShutdown.java >> line 74: >> >>> 72: float timeoutFactor = Float.parseFloat( >>> 73: System.getProperty("test.timeout.factor", "1.0")); >>> 74:

Re: RFR: 8344766: AES/CTR slow at big payloads

2024-11-22 Thread Anthony Scarpino
On Thu, 21 Nov 2024 18:03:44 GMT, Volodymyr Paprotski wrote: > This is a follow up to https://github.com/openjdk/jdk/pull/22086 for AES/CTR > > Before: > > Benchmark(algorithm) (dataSize) (keyLength) (provider) > Mode CntScoreError Units > AESBench.decrypt AES

Re: RFR: 8044609: javax.net.debug options not working and documented as expected [v10]

2024-11-22 Thread Bradford Wetmore
On Thu, 21 Nov 2024 13:01:41 GMT, Sean Coffey wrote: >> The `javax.net.debug` TLS debug option is buggy since TLSv1.3 implementation >> was introduced many years ago. >> >> Where "ssl" was previously a value to obtain all TLS debug traces (except >> network type dumps, verbose data), it now pr

Re: RFR: 8344366: Remove Security Manager dependencies from javax.net.ssl and sun.security.ssl packages [v2]

2024-11-22 Thread Alexey Bakhtin
On Fri, 22 Nov 2024 16:39:49 GMT, Sean Mullan wrote: >> Yes, you are right, javadoc is the same. So, not entirely correct about API. >> But the same exact place in the KeyManagerFactory is not modified. I do not >> know the exact policy about references in the javadoc. I prefer to have a >> ful

Re: RFR: 8344366: Remove Security Manager dependencies from javax.net.ssl and sun.security.ssl packages [v2]

2024-11-22 Thread Hai-May Chao
On Fri, 22 Nov 2024 16:38:01 GMT, Sean Mullan wrote: >> Now that JEP 486 has been integrated, the `javax.net.ssl` and >> `sun.security.ssl` package implementation dependencies on >> `System.getSecurityManager`, `AccessController.doPrivileged` and >> `AccessControlContext` can be removed. >> >

Integrated: 8344788: Specify that the access control context parameters of Subject.doAsPrivileged are ignored

2024-11-22 Thread Sean Mullan
On Thu, 21 Nov 2024 22:36:22 GMT, Sean Mullan wrote: > Specify that the access control context parameters of > `Subject.doAsPrivileged` are ignored. This spec update was missed as part of > JEP 486. This pull request has now been integrated. Changeset: 6aec2dcf Author:Sean Mullan URL:

Re: RFR: 8344629: SSLSocketNoServerHelloClientShutdown test timeout [v3]

2024-11-22 Thread Artur Barashev
On Fri, 22 Nov 2024 17:29:23 GMT, Bradford Wetmore wrote: >> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Adding CountDownLatch mechanism > > test/jdk/sun/security/ssl/SSLCipher/SSLSocketNoServerHelloClientShutdown.java

Re: RFR: 8344366: Remove Security Manager dependencies from javax.net.ssl and sun.security.ssl packages [v2]

2024-11-22 Thread Anthony Scarpino
On Fri, 22 Nov 2024 16:38:01 GMT, Sean Mullan wrote: >> Now that JEP 486 has been integrated, the `javax.net.ssl` and >> `sun.security.ssl` package implementation dependencies on >> `System.getSecurityManager`, `AccessController.doPrivileged` and >> `AccessControlContext` can be removed. >> >

Re: RFR: 8298387: Implement JEP 497: Quantum-Resistant Module-Lattice-Based Digital Signature Algorithm [v34]

2024-11-22 Thread Jamil Nimeh
On Fri, 22 Nov 2024 17:31:37 GMT, Ben Perez wrote: >> Java implementation of ML-DSA, the FIPS 204 post-quantum signature scheme >> https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.204.pdf. Depends on >> https://github.com/openjdk/jdk/pull/21167 > > Ben Perez has updated the pull request with a

Integrated: 8298387: Implement JEP 497: Quantum-Resistant Module-Lattice-Based Digital Signature Algorithm

2024-11-22 Thread Ben Perez
On Fri, 4 Oct 2024 20:59:45 GMT, Ben Perez wrote: > Java implementation of ML-DSA, the FIPS 204 post-quantum signature scheme > https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.204.pdf. Depends on > https://github.com/openjdk/jdk/pull/21167 This pull request has now been integrated. Changeset

Re: RFR: 8298387: Implement JEP 497: Quantum-Resistant Module-Lattice-Based Digital Signature Algorithm [v34]

2024-11-22 Thread Ben Perez
> Java implementation of ML-DSA, the FIPS 204 post-quantum signature scheme > https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.204.pdf. Depends on > https://github.com/openjdk/jdk/pull/21167 Ben Perez has updated the pull request with a new target base due to a merge or a rebase. The pull reque

Re: RFR: 8344629: SSLSocketNoServerHelloClientShutdown test timeout [v3]

2024-11-22 Thread Bradford Wetmore
On Fri, 22 Nov 2024 17:19:31 GMT, Artur Barashev wrote: >> SAP complains about SSLSocketNoServerHelloClientShutdown timing out in their >> test environment (concurrent test execution with high CPU load). This change >> addresses this issue in 2 ways: >> - Increase default timeout value >> - All

Re: RFR: 8344629: SSLSocketNoServerHelloClientShutdown test timeout [v3]

2024-11-22 Thread Artur Barashev
> SAP complains about SSLSocketNoServerHelloClientShutdown timing out in their > test environment (concurrent test execution with high CPU load). This change > addresses this issue in 2 ways: > - Increase default timeout value > - Allow adjustment of timeout value by setting "test.timeout.factor"

Re: RFR: 8344629: SSLSocketNoServerHelloClientShutdown test timeout [v2]

2024-11-22 Thread Artur Barashev
On Thu, 21 Nov 2024 21:30:02 GMT, Bradford Wetmore wrote: >> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Print stack trace > > test/jdk/sun/security/ssl/SSLCipher/SSLSocketNoServerHelloClientShutdown.java > line 69: >

Re: RFR: 8344366: Remove Security Manager dependencies from javax.net.ssl and sun.security.ssl packages [v2]

2024-11-22 Thread Sean Coffey
On Fri, 22 Nov 2024 16:38:01 GMT, Sean Mullan wrote: >> Now that JEP 486 has been integrated, the `javax.net.ssl` and >> `sun.security.ssl` package implementation dependencies on >> `System.getSecurityManager`, `AccessController.doPrivileged` and >> `AccessControlContext` can be removed. >> >

Re: RFR: 8344366: Remove Security Manager dependencies from javax.net.ssl and sun.security.ssl packages [v2]

2024-11-22 Thread Sean Mullan
On Fri, 22 Nov 2024 12:53:14 GMT, Sean Coffey wrote: >> Sean Mullan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert @see text in TrustManagerFactory. >> Remove sun.security.action.OpenFileInputStreamAction. > > src/java.base/sha

Re: RFR: 8344366: Remove Security Manager dependencies from javax.net.ssl and sun.security.ssl packages [v2]

2024-11-22 Thread Sean Mullan
On Thu, 21 Nov 2024 23:21:35 GMT, Alexey Bakhtin wrote: >> Why do you think it is an API change? It produces the exact same javadoc. >> Technically it's not related, but minor cleanup changes like this are ok in >> my opinion. > > Yes, you are right, javadoc is the same. So, not entirely correc

Integrated: 8298390: Implement JEP 496: Quantum-Resistant Module-Lattice-Based Key Encapsulation Mechanism

2024-11-22 Thread Ben Perez
On Fri, 11 Oct 2024 20:12:52 GMT, Ben Perez wrote: > Java implementation of ML-KEM, the [FIPS > 203](https://csrc.nist.gov/pubs/fips/203/final) post-quantum KEM scheme. > Depends on https://github.com/openjdk/jdk/pull/21167 This pull request has now been integrated. Changeset: 13987b42 Author

Re: RFR: 8344366: Remove Security Manager dependencies from javax.net.ssl and sun.security.ssl packages [v2]

2024-11-22 Thread Sean Mullan
> Now that JEP 486 has been integrated, the `javax.net.ssl` and > `sun.security.ssl` package implementation dependencies on > `System.getSecurityManager`, `AccessController.doPrivileged` and > `AccessControlContext` can be removed. > > Most of the changes are straightforward: removal of code ca

Re: RFR: 8298390: Implement JEP 496: Quantum-Resistant Module-Lattice-Based Key Encapsulation Mechanism [v30]

2024-11-22 Thread Valerie Peng
On Thu, 21 Nov 2024 23:27:44 GMT, Ben Perez wrote: >> Java implementation of ML-KEM, the [FIPS >> 203](https://csrc.nist.gov/pubs/fips/203/final) post-quantum KEM scheme. >> Depends on https://github.com/openjdk/jdk/pull/21167 > > Ben Perez has updated the pull request incrementally with one ad

Re: RFR: 8344222: Remove calls to SecurityManager and doPrivileged in java.net.HttpURLConnection, java.net.HttpConnectSocketImpl, and javax.net.HttpsURLConnection after JEP 486 integration

2024-11-22 Thread Daniel Fuchs
On Fri, 22 Nov 2024 14:31:21 GMT, Volkan Yazıcı wrote: > Addresses [8344222](https://bugs.openjdk.org/browse/JDK-8344222) and removes > `SecurityManager` and `doPrivileged()` usages from `Http(s)URLConnection` and > `HttpConnectSocketImpl`. `tier2` and `tier3` results are on their way. LGTM -

RFR: 8344222: Remove calls to SecurityManager and doPrivileged in java.net.HttpURLConnection, java.net.HttpConnectSocketImpl, and javax.net.HttpsURLConnection after JEP 486 integration

2024-11-22 Thread Volkan Yazıcı
Addresses [8344222](https://bugs.openjdk.org/browse/JDK-8344222) and removes `SecurityManager` and `doPrivileged()` usages from `Http(s)URLConnection` and `HttpConnectSocketImpl`. `tier2` and `tier3` results are on their way. - Commit messages: - Remove `SM` et al. from `HttpURLCon

Integrated: 8344652: Remove access control context text from SSLEngine and SSLSession APIs

2024-11-22 Thread Sean Mullan
On Thu, 21 Nov 2024 17:36:03 GMT, Sean Mullan wrote: > Some additional text in two `javax.net.ssl` APIs related to access control > context was missed as part of JEP 483. This behavior no longer applies now > that the Security Manager is permanently disabled and has been removed. > > The imple

Re: RFR: 8344366: Remove Security Manager dependencies from javax.net.ssl and sun.security.ssl packages

2024-11-22 Thread Sean Coffey
On Thu, 21 Nov 2024 18:29:24 GMT, Sean Mullan wrote: > Now that JEP 486 has been integrated, the `javax.net.ssl` and > `sun.security.ssl` package implementation dependencies on > `System.getSecurityManager`, `AccessController.doPrivileged` and > `AccessControlContext` can be removed. > > Most