Re: RFR: 8342682: Errors related to unused code on Windows after 8339120 in dt_shmem jdwp security and jpackage [v3]

2024-10-26 Thread Julian Waters
> After 8339120, gcc began catching many different instances of unused code in > the Windows specific codebase. Some of these seem to be bugs. I've taken the > effort to mark out all the relevant globals and locals that trigger the > unused warnings and addressed all of them by commenting out th

Re: RFR: 8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server [v24]

2024-10-26 Thread Xue-Lei Andrew Fan
On Fri, 25 Oct 2024 23:44:50 GMT, Artur Barashev wrote: >> 1. If we got through the `bb.remaining() <= tagSize` arm, we're not going to >> be encrypted. I think we are safe here. >> 2. I would dump the alert level (fatal/warning) + reason. >> 3. `bb` size definitely needs to be checked. e.g. i

Integrated: 8305406: Add @spec tags in java.base/java.* (part 2)

2024-10-26 Thread Hannes Wallnöfer
On Thu, 3 Oct 2024 14:04:51 GMT, Hannes Wallnöfer wrote: > Please review a doc update to add `@spec` tags to crypto and security APIs in > `java.base`. > > This was authored and proposed as #13336 by @jonathan-gibbons as part of an > effort to [add `@spec` tags and an external specifications

Re: RFR: 8305406: Add @spec tags in java.base/java.* (part 2) [v3]

2024-10-26 Thread Hannes Wallnöfer
On Thu, 24 Oct 2024 14:29:45 GMT, Hannes Wallnöfer wrote: >> Please review a doc update to add `@spec` tags to crypto and security APIs >> in `java.base`. >> >> This was authored and proposed as #13336 by @jonathan-gibbons as part of an >> effort to [add `@spec` tags and an external specifica