Re: RFR: 8342682: Errors related to unused code on Windows after 8339120 in dt_shmem jdwp security and jpackage

2024-10-22 Thread Julian Waters
On Tue, 22 Oct 2024 18:03:12 GMT, Chris Plummer wrote: >> After 8339120, gcc began catching many different instances of unused code in >> the Windows specific codebase. Some of these seem to be bugs. I've taken the >> effort to mark out all the relevant globals and locals that trigger the >> u

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Prasanta Sadhukhan
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Prasanta Sadhukhan
On Tue, 22 Oct 2024 16:46:53 GMT, Phil Race wrote: >> Not specific to JEP 486, this should be done as part of a different issue. > > agreed there were many tests modified in javax_swing in this PR where the author tag is removed, only this is missed so I pointed it out... - PR Rev

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Prasanta Sadhukhan
On Tue, 22 Oct 2024 16:44:59 GMT, Phil Race wrote: >> This should be addressed in a more general separate task, and not part of >> this PR since it does not have anything to do with the changes in this JEP. > > Agreed. This is not a "clean up / update tests" task. > If it is a change on some lin

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Prasanta Sadhukhan
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8331958: Update PC/SC Lite for Suse Linux to 2.3.0

2024-10-22 Thread Valerie Peng
On Thu, 17 Oct 2024 11:41:47 GMT, Weijun Wang wrote: > I see there is a `COPYING` file in the same directory as the header files. > Does it need any update? That file has been the same, so no need to update it. - PR Comment: https://git.openjdk.org/jdk/pull/21552#issuecomment-2430

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Mandy Chung
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Harshitha Onkar
On Tue, 22 Oct 2024 09:29:38 GMT, Prasanta Sadhukhan wrote: >> Sean Mullan has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 97 commits: >> >> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411 >> - Change apiNo

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Harshitha Onkar
On Tue, 22 Oct 2024 08:16:38 GMT, Prasanta Sadhukhan wrote: >> Sean Mullan has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 97 commits: >> >> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411 >> - Change apiNo

RFR: 8342838: ECDHE algorithm can't be disabled for TLSv1.3 cipher suites

2024-10-22 Thread Artur Barashev
`SSLAlgorithmDecomposer.decomposes(CipherSuite.KeyExchange keyExchange)` method is missing the `null` case: TLSv1.3 cipher suites with ECDHE being used for both key exchange and authentication have `null` for KeyExchange object. - Commit messages: - 8342838: ECDHE algorithm can't b

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Harshitha Onkar
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8342682: Errors related to unused code on Windows after 8339120

2024-10-22 Thread Chris Plummer
On Mon, 21 Oct 2024 14:34:30 GMT, Julian Waters wrote: > After 8339120, gcc began catching many different instances of unused code in > the Windows specific codebase. Some of these seem to be bugs. I've taken the > effort to mark out all the relevant globals and locals that trigger the > unuse

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Phil Race
On Tue, 22 Oct 2024 15:22:08 GMT, Sean Mullan wrote: >> test/jdk/javax/swing/JComboBox/8080972/TestBasicComboBoxEditor.java line 26: >> >>> 24: import javax.swing.SwingUtilities; >>> 25: import javax.swing.plaf.basic.BasicComboBoxEditor; >>> 26: /* >> >> I think we have finally decided that jtr

Re: RFR: 8336665: CCE in X509CRLImpl$TBSCertList.getCertIssuer [v7]

2024-10-22 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8336665 Mark Powers has updated the pull request incrementally with one additional commit since the last revision: more precise comment - Changes: - all: https://git.openjdk.org/jdk/pull/20528/files - new: https://git.openjdk.org/jdk/pull

Re: RFR: 8336665: CCE in X509CRLImpl$TBSCertList.getCertIssuer [v6]

2024-10-22 Thread Mark Powers
On Tue, 22 Oct 2024 14:27:19 GMT, Sean Mullan wrote: >> The CRL is being constructed from a fuzzed data input stream. All I know is >> that the name in the CertificateIssuerExtension looks like an x509.OIDName >> in the first test, and in the second test it looks like an x509.X400Address. >> >

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Sean Mullan
On Tue, 22 Oct 2024 08:09:01 GMT, Prasanta Sadhukhan wrote: >> Sean Mullan has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 97 commits: >> >> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411 >> - Change apiNo

Re: RFR: 8305406: Add @spec tags in java.base/java.* (part 2) [v2]

2024-10-22 Thread Hannes Wallnöfer
On Mon, 21 Oct 2024 15:45:09 GMT, Hannes Wallnöfer wrote: >> Please review a doc update to add `@spec` tags to crypto and security APIs >> in `java.base`. >> >> This was authored and proposed as #13336 by @jonathan-gibbons as part of an >> effort to [add `@spec` tags and an external specifica

Re: RFR: 8336665: CCE in X509CRLImpl$TBSCertList.getCertIssuer [v6]

2024-10-22 Thread Sean Mullan
On Tue, 22 Oct 2024 12:51:45 GMT, Mark Powers wrote: >> test/jdk/sun/security/x509/X509CRLImpl/UnexpectedCCE.java line 46: >> >>> 44: // "class sun.security.x509.OIDName cannot be cast >>> 45: // to class sun.security.x509.X500Name" >>> 46: byte[] encoded_1 = Base64.getDe

Re: RFR: 8315487: Security Providers Filter

2024-10-22 Thread Francisco Ferrari Bihurriet
On Fri, 6 Oct 2023 17:06:03 GMT, Martin Balao wrote: >> In addition to the goals, scope, motivation, specification and requirement >> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we >> would like to describe the most relevant decisions taken during the >> implementation

Re: RFR: 8317538: RSA have scalability issue for high vCPU numbers

2024-10-22 Thread Claes Redestad
On Mon, 21 Oct 2024 18:18:12 GMT, Vladimir Ivanov wrote: > This patch remove access to the shared variable to fix scalability issue in > the multithread environment. According to testing by the > specjvm2008::crypto.rsa the one thread performance reduced for less than 1% > while the score for

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Daniel Fuchs
On Tue, 22 Oct 2024 11:50:13 GMT, Michael McMahon wrote: >> Sean Mullan has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 97 commits: >> >> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411 >> - Change apiNote t

Re: RFR: 8336665: CCE in X509CRLImpl$TBSCertList.getCertIssuer [v6]

2024-10-22 Thread Mark Powers
On Mon, 21 Oct 2024 17:28:42 GMT, Sean Mullan wrote: >> Mark Powers has updated the pull request incrementally with one additional >> commit since the last revision: >> >> more precise exception message > > test/jdk/sun/security/x509/X509CRLImpl/UnexpectedCCE.java line 46: > >> 44: /

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Michael McMahon
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8342682: Errors related to unused code on Windows after 8339120

2024-10-22 Thread Julian Waters
On Tue, 22 Oct 2024 09:40:35 GMT, David Holmes wrote: > > Aren't the dt_shmem and jdwp changes related to HotSpot? > > Nope. That's core-svc - the non-hotspot side of serviceability. :) Oh, well I guess you learn something new everyday :) - PR Comment: https://git.openjdk.org/jdk/

Re: RFR: 8342181: Update tests to use stronger Key and Salt size [v6]

2024-10-22 Thread Fernando Guallini
> Several tests currently use weak key and salt sizes. Since the purpose of > these tests is not to evaluate weak keys, they can be updated to use stronger > keys length (2048-bits) and stronger Salt (16 bytes). This PR does not intend > to update the tests to use stronger algorithms. > > There

Re: RFR: 8342188: Update tests to use stronger key parameters and certificates [v4]

2024-10-22 Thread Fernando Guallini
> Several tests are identified to use weak key parameters (prime modulus, > private/public values) and certs with weak keys. As these tests purpose is > not to exercise weak keys, these are updated in this PR to use a modulus with > 2048-bit, base 2 and certificates with key size 2048 Fernando

Re: RFR: 8342682: Errors related to unused code on Windows after 8339120

2024-10-22 Thread David Holmes
On Tue, 22 Oct 2024 01:43:50 GMT, Julian Waters wrote: > Aren't the dt_shmem and jdwp changes related to HotSpot? Nope. That's core-svc - the non-hotspot side of serviceability. :) - PR Comment: https://git.openjdk.org/jdk/pull/21616#issuecomment-2428793636

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Prasanta Sadhukhan
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Prasanta Sadhukhan
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Prasanta Sadhukhan
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Prasanta Sadhukhan
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Prasanta Sadhukhan
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Prasanta Sadhukhan
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Prasanta Sadhukhan
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch