Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v12]

2024-10-08 Thread Weijun Wang
> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are only > named standardized parameter sets, a common framework is introduced. > > A example of EdDSA implementation using this framework is included as a test. Weijun Wang has updated the pull request incrementally with one

Re: RFR: 8335288: SunPKCS11 initialization will call C_GetMechanismInfo on unsupported mechanisms [v2]

2024-10-08 Thread Valerie Peng
On Tue, 8 Oct 2024 22:33:40 GMT, Valerie Peng wrote: > > Hi. I'm the original reporter of this issue. Thanks for the work done on > > this bug. I see the the fix has been targeted at only Java 24. Are there > > any plans to back port this to Java 21, which is the current LTS version, > > and w

Re: RFR: 8335288: SunPKCS11 initialization will call C_GetMechanismInfo on unsupported mechanisms [v2]

2024-10-08 Thread Valerie Peng
On Mon, 7 Oct 2024 06:31:13 GMT, Kåre Fiedler Christiansen wrote: > Hi. I'm the original reporter of this issue. Thanks for the work done on this > bug. I see the the fix has been targeted at only Java 24. Are there any plans > to back port this to Java 21, which is the current LTS version, an

Re: RFR: 8331959: Update PKCS#11 Cryptographic Token Interface to v3.1

2024-10-08 Thread Valerie Peng
On Mon, 7 Oct 2024 23:31:49 GMT, Weijun Wang wrote: >> Could someone please help review this PR? It updates the PKCS#11 headers and >> the relevant files to v3.1. >> >> Thanks! >> Valerie > > Looks good to me. Thanks. Thanks @wangweij @ascarpino for the review~Will integrate after management

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v10]

2024-10-08 Thread Weijun Wang
On Tue, 8 Oct 2024 19:49:53 GMT, Anthony Scarpino wrote: >> Yes, `this.key` is the one inside `PKCS8Key`. >> >> Since EdDSA and XDH, the private key has taken this OCTET in OCTET approach. >> My code is identical to the EdDSA code at >> https://github.com/openjdk/jdk/blob/adca97b659d725b0dd320

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v11]

2024-10-08 Thread Weijun Wang
> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are only > named standardized parameter sets, a common framework is introduced. > > A example of EdDSA implementation using this framework is included as a test. Weijun Wang has updated the pull request incrementally with one

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v10]

2024-10-08 Thread Weijun Wang
On Tue, 8 Oct 2024 19:16:10 GMT, Sean Mullan wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> null check as asserts, and better exception messages > > src/java.base/share/classes/sun/security/provider/NamedSignature.

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v10]

2024-10-08 Thread Weijun Wang
On Tue, 8 Oct 2024 19:11:45 GMT, Sean Mullan wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> null check as asserts, and better exception messages > > src/java.base/share/classes/sun/security/provider/NamedSignature.

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v10]

2024-10-08 Thread Weijun Wang
On Tue, 8 Oct 2024 18:46:20 GMT, Sean Mullan wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> null check as asserts, and better exception messages > > src/java.base/share/classes/sun/security/provider/NamedSignature.

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v10]

2024-10-08 Thread Anthony Scarpino
On Tue, 8 Oct 2024 02:28:35 GMT, Weijun Wang wrote: >> src/java.base/share/classes/sun/security/pkcs/NamedPKCS8Key.java line 81: >> >>> 79: } finally { >>> 80: val.clear(); >>> 81: } >> >> The `this.key` is from the `PKCS8Key` class, right? However, looking at the >

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v10]

2024-10-08 Thread Sean Mullan
On Mon, 7 Oct 2024 18:54:03 GMT, Weijun Wang wrote: >> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are >> only named standardized parameter sets, a common framework is introduced. >> >> A example of EdDSA implementation using this framework is included as a test. > > We

Re: RFR: 8298387: Implementing ML-DSA signature algorithm [v3]

2024-10-08 Thread Ben Perez
> Java implementation of ML-DSA, the FIPS 204 post-quantum signature scheme > https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.204.pdf. Depends on > https://github.com/openjdk/jdk/pull/21167 Ben Perez has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8298387: Implementing ML-DSA signature algorithm [v2]

2024-10-08 Thread Ben Perez
> Java implementation of ML-DSA, the FIPS 204 post-quantum signature scheme > https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.204.pdf. Depends on > https://github.com/openjdk/jdk/pull/21167 Ben Perez has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8298387: Implementing ML-DSA signature algorithm

2024-10-08 Thread Jamil Nimeh
On Fri, 4 Oct 2024 20:59:45 GMT, Ben Perez wrote: > Java implementation of ML-DSA, the FIPS 204 post-quantum signature scheme > https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.204.pdf. Depends on > https://github.com/openjdk/jdk/pull/21167 src/java.base/share/classes/sun/security/provider/ML_

Re: RFR: 8298387: Implementing ML-DSA signature algorithm

2024-10-08 Thread Kevin Driver
On Tue, 8 Oct 2024 15:38:18 GMT, Kevin Driver wrote: >> Java implementation of ML-DSA, the FIPS 204 post-quantum signature scheme >> https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.204.pdf. Depends on >> https://github.com/openjdk/jdk/pull/21167 > > src/java.base/share/classes/sun/security/pro

Re: RFR: 8298387: Implementing ML-DSA signature algorithm

2024-10-08 Thread Kevin Driver
On Fri, 4 Oct 2024 20:59:45 GMT, Ben Perez wrote: > Java implementation of ML-DSA, the FIPS 204 post-quantum signature scheme > https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.204.pdf. Depends on > https://github.com/openjdk/jdk/pull/21167 src/java.base/share/classes/sun/security/provider/ML_

Re: RFR: 8340133: Investigate if the java launcher could give hints about JShell

2024-10-08 Thread Magnus Ihse Bursie
On Tue, 8 Oct 2024 15:28:17 GMT, Jan Lahoda wrote: > Currently, running `java` without any parameters will lead to an output that > is a full `--help`, which is over 100 lines (on my computer at least), and it > feels overwhelming. And many people might actually want to run JShell/REPL, > not

Re: RFR: 8298387: Implementing ML-DSA signature algorithm

2024-10-08 Thread Kevin Driver
On Fri, 4 Oct 2024 20:59:45 GMT, Ben Perez wrote: > Java implementation of ML-DSA, the FIPS 204 post-quantum signature scheme > https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.204.pdf. Depends on > https://github.com/openjdk/jdk/pull/21167 src/java.base/share/classes/sun/security/provider/ML_

Re: RFR: 8336665: CCE in X509CRLImpl$TBSCertList.getCertIssuer [v4]

2024-10-08 Thread Mark Powers
On Tue, 8 Oct 2024 15:28:58 GMT, Mark Powers wrote: >> src/java.base/share/classes/sun/security/x509/X509CRLImpl.java line 292: >> >>> 290: throw new CRLException("Parsing error: " >>> 291: + "issuer is not an X.500 DN"); >>> 292: }

RFR: 8340133: Investigate if the java launcher could give hints about JShell

2024-10-08 Thread Jan Lahoda
Currently, running `java` without any parameters will lead to an output that is a full `--help`, which is over 100 lines (on my computer at least), and it feels overwhelming. And many people might actually want to run JShell/REPL, not the `java` launcher, but it is difficult find out about JShel

Re: RFR: 8336665: CCE in X509CRLImpl$TBSCertList.getCertIssuer [v4]

2024-10-08 Thread Mark Powers
On Tue, 24 Sep 2024 12:33:54 GMT, Sean Mullan wrote: >> Mark Powers has updated the pull request incrementally with one additional >> commit since the last revision: >> >> another comment from Sean > > src/java.base/share/classes/sun/security/x509/X509CRLImpl.java line 292: > >> 290:

Re: RFR: 8336665: CCE in X509CRLImpl$TBSCertList.getCertIssuer [v5]

2024-10-08 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8336665 Mark Powers has updated the pull request incrementally with one additional commit since the last revision: allow more than one name - Changes: - all: https://git.openjdk.org/jdk/pull/20528/files - new: https://git.openjdk.org/jdk/

Re: RFR: 8298387: Implementing ML-DSA signature algorithm

2024-10-08 Thread Weijun Wang
On Fri, 4 Oct 2024 20:59:45 GMT, Ben Perez wrote: > Java implementation of ML-DSA, the FIPS 204 post-quantum signature scheme > https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.204.pdf. Depends on > https://github.com/openjdk/jdk/pull/21167 src/java.base/share/classes/sun/security/provider/ML_

Re: RFR: 8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server [v17]

2024-10-08 Thread Artur Barashev
> Check for unexpected plaintext alert message during TLSv1.3 handshake. This > can happen if client doesn't receive ServerHello due to network timeout and > tries to close the connection by sending an alert message. Artur Barashev has updated the pull request incrementally with one additional

Re: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts.

2024-10-08 Thread Sean Mullan
Hi Hempushpa, I'm not actively involved in the OpenJDK 17u Project, so I'm not the best person to review this. You might want to ask one of the JDK 17u Project Maintainers [1] who would be a suitable person to review this backport. Thanks, Sean [1] https://wiki.openjdk.org/display/JDKUpdate