Re: RFR: 8341243: Use ArraySupport.SOFT_MAX_ARRAY_LENGTH for max array size in java.base [v2]

2024-10-01 Thread Jaikiran Pai
On Tue, 1 Oct 2024 05:39:09 GMT, Eirik Bjørsnøs wrote: >> Please review this cleanup PR which updates code and tests in `java.base` to >> consistently use `jdk.internal.util.ArraySupport.SOFT_MAX_ARRAY_LENGTH` >> when referring to the JVM's maximum array size implementation limit. >> Currentl

Integrated: 8341243: Use ArraySupport.SOFT_MAX_ARRAY_LENGTH for max array size in java.base

2024-10-01 Thread Eirik Bjørsnøs
On Mon, 30 Sep 2024 15:14:31 GMT, Eirik Bjørsnøs wrote: > Please review this cleanup PR which updates code and tests in `java.base` to > consistently use `jdk.internal.util.ArraySupport.SOFT_MAX_ARRAY_LENGTH` when > referring to the JVM's maximum array size implementation limit. Currently, >

JEP 486: Question about CodeSource

2024-10-01 Thread Thiago Henrique Hupner
Hi all! Will the following snippet stop working after the JEP 486 has been integrated? If so, will there be any replacement to get a CodeSource? ``` getClass().getProtectionDomain().getCodeSource().getLocation() ``` Best regards, Thiago

Re: RFR: 8341243: Use ArraySupport.SOFT_MAX_ARRAY_LENGTH for max array size in java.base [v2]

2024-10-01 Thread Eirik Bjørsnøs
On Tue, 1 Oct 2024 05:39:09 GMT, Eirik Bjørsnøs wrote: >> Please review this cleanup PR which updates code and tests in `java.base` to >> consistently use `jdk.internal.util.ArraySupport.SOFT_MAX_ARRAY_LENGTH` >> when referring to the JVM's maximum array size implementation limit. >> Currentl

Re: RFR: 8341243: Use ArraySupport.SOFT_MAX_ARRAY_LENGTH for max array size in java.base

2024-10-01 Thread Stuart Marks
On Tue, 1 Oct 2024 05:52:23 GMT, Eirik Bjørsnøs wrote: >> As this stands (modulo my other comments) this change is mostly OK. Using >> the SOFT_MAX value within java.base is fine. Using SOFT_MAX within >> java.base-related tests is a little suspicious, because it requires the >> addition of di

Re: RFR: 8341243: Use ArraySupport.SOFT_MAX_ARRAY_LENGTH for max array size in java.base [v2]

2024-10-01 Thread Stuart Marks
On Tue, 1 Oct 2024 05:39:09 GMT, Eirik Bjørsnøs wrote: >> Please review this cleanup PR which updates code and tests in `java.base` to >> consistently use `jdk.internal.util.ArraySupport.SOFT_MAX_ARRAY_LENGTH` >> when referring to the JVM's maximum array size implementation limit. >> Currentl

Re: RFR: 8309841: Jarsigner should print a warning if an entry is removed [v7]

2024-10-01 Thread Sean Mullan
On Mon, 30 Sep 2024 16:18:13 GMT, Weijun Wang wrote: >> There ~are two~ is one change~s~: >> >> 1. In `jarsigner -verify`, check a .SF file contains un-existing entries and >> print them out as >> >> Warning: nonexistent signed entries detected: [a] >> >> ~2. In `JarSigner::sign0`, when creat

Re: RFR: 8341243: Use ArraySupport.SOFT_MAX_ARRAY_LENGTH for max array size in java.base [v2]

2024-10-01 Thread Jaikiran Pai
On Tue, 1 Oct 2024 05:39:09 GMT, Eirik Bjørsnøs wrote: >> Please review this cleanup PR which updates code and tests in `java.base` to >> consistently use `jdk.internal.util.ArraySupport.SOFT_MAX_ARRAY_LENGTH` >> when referring to the JVM's maximum array size implementation limit. >> Currentl

RFR: 8340116: test/jdk/sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java can fail due to regex

2024-10-01 Thread Fernando Guallini
The test **sun/security/tools/jarsigner/PreserveRawManifestEntryAndDigest.java** may fail with the following exception: test PreserveRawManifestEntryAndDigest.testNameImmediatelyContinued(): failure java.lang.AssertionError: "s k 300 Tue Jun 25 10:20:16 GMT+07:00 2024 META-INF/MANIFEST.MF" sho