Re: RFR: 8339735: Remove references to Applet in core-libs/security APIs

2024-09-17 Thread Alan Bateman
On Tue, 17 Sep 2024 23:14:16 GMT, Justin Lu wrote: > Please review this PR which removes occurrences of 'applet' within the > corelibs specification. Applet has been deprecated since JDK9, and may be a > confusing term for new Java developers, so it should be removed from the > documentation.

Re: RFR: 8339735: Remove references to Applet in core-libs/security APIs

2024-09-17 Thread Alan Bateman
On Wed, 18 Sep 2024 06:25:57 GMT, Sean Coffey wrote: >> src/java.base/share/classes/java/lang/doc-files/threadPrimitiveDeprecation.html >> line 74: >> >>> 72: volatile (or access to the variable must be >>> 73: synchronized). >>> 74: For example, suppose your application contains the following

Re: RFR: 8339735: Remove references to Applet in core-libs/security APIs

2024-09-17 Thread Sean Coffey
On Tue, 17 Sep 2024 23:36:16 GMT, Naoto Sato wrote: >> Please review this PR which removes occurrences of 'applet' within the >> corelibs specification. Applet has been deprecated since JDK9, and may be a >> confusing term for new Java developers, so it should be removed from the >> documentat

Re: RFR: 8298420: PEM API: Implementation (Preview) [v5]

2024-09-17 Thread Anthony Scarpino
> Hi all, > > I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a format > for encoding and decoding cryptographic keys and certificates. It will be > integrated into JDK24 as a Preview Feature. Preview features does not > permanently define the API and it is subject to cha

Re: RFR: 8339735: Remove references to Applet in core-libs/security APIs

2024-09-17 Thread Naoto Sato
On Tue, 17 Sep 2024 23:14:16 GMT, Justin Lu wrote: > Please review this PR which removes occurrences of 'applet' within the > corelibs specification. Applet has been deprecated since JDK9, and may be a > confusing term for new Java developers, so it should be removed from the > documentation.

RFR: 8339735: Remove references to Applet in core-libs/security APIs

2024-09-17 Thread Justin Lu
Please review this PR which removes occurrences of 'applet' within the corelibs specification. Applet has been deprecated since JDK9, and may be a confusing term for new Java developers, so it should be removed from the documentation. Primarily, usages where 'applet' is used interchangeably with

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v33]

2024-09-17 Thread Kevin Driver
On Tue, 17 Sep 2024 20:34:17 GMT, Sean Mullan wrote: >> I can see your point; however, we are not saying "_L_ist of values", so we >> are discussing it in an abstract manner. Let's leave it "as-is", since it >> can be interpreted either way. > > The usage of "list" in specification could imply

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v43]

2024-09-17 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). > > Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). Kevin Driver

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v28]

2024-09-17 Thread Kevin Driver
On Mon, 16 Sep 2024 21:05:18 GMT, Sean Mullan wrote: >> @wangweij: No change necessary. Personal opinion. These comments are here to >> stave off reviewer comments that may suggest doing it differently and to >> reflect my choice to ease the job of backporters. > > This commentary about backpor

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v42]

2024-09-17 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). > > Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). Kevin Driver

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v37]

2024-09-17 Thread Kevin Driver
On Mon, 16 Sep 2024 22:23:56 GMT, Weijun Wang wrote: >> I may be wrong, but I think the final exception indicates a `Provider` >> couldn't be chosen, so I'm not sure we can "complete" the provider selection >> task. Maybe I misunderstood what you meant. > > My understanding is that there must b

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v36]

2024-09-17 Thread Kevin Driver
On Mon, 16 Sep 2024 22:32:15 GMT, Weijun Wang wrote: >> This newer wording more clearly reflects the original intent of this >> passage: >> https://github.com/openjdk/jdk/pull/20301/commits/ea5ba798819568ca86d639ba6c7a9489d4e66c95. > > Your previous sentence contains a very important informatio

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v41]

2024-09-17 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). > > Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). Kevin Driver

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v40]

2024-09-17 Thread Kevin Driver
On Tue, 17 Sep 2024 07:08:16 GMT, Viktor Klang wrote: >> src/java.base/share/classes/com/sun/crypto/provider/HKDFKeyDerivation.java >> line 86: >> >>> 84: } >>> 85: // added to enforce valid values at reviewer's request >>> 86: if (!Arrays.asList(SUPPORTED_HMAC_SIZES).co

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v33]

2024-09-17 Thread Sean Mullan
On Fri, 13 Sep 2024 22:06:17 GMT, Kevin Driver wrote: >> I still think appending to or creating a list is implementation detail. > > I can see your point; however, we are not saying "_L_ist of values", so we > are discussing it in an abstract manner. Let's leave it "as-is", since it can > be in

RFR: 8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server

2024-09-17 Thread Artur Barashev
https://bugs.openjdk.org/browse/JDK-8331682 - Commit messages: - 8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server Changes: https://git.openjdk.org/jdk/pull/21043/files Webrev: https://webrevs.openjdk.org/?repo

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v40]

2024-09-17 Thread Viktor Klang
On Tue, 17 Sep 2024 07:06:14 GMT, Viktor Klang wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> IDE formatting broke snippet > > src/java.base/share/classes/com/sun/crypto/provider/HKDFKeyDerivation.java > line 86:

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v40]

2024-09-17 Thread Viktor Klang
On Mon, 16 Sep 2024 19:21:13 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P