Re: RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK [v5]

2024-08-23 Thread Jaikiran Pai
On Sat, 24 Aug 2024 05:12:42 GMT, Julian Waters wrote: >> snprintf has been available for all officially and unofficially supported >> compilers for Windows, Visual Studio since version 2015 and gcc since, well, >> forever. snprintf is conforming to C99 since the start when compiling using >>

Re: RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK [v4]

2024-08-23 Thread Julian Waters
On Sat, 24 Aug 2024 05:06:18 GMT, Julian Waters wrote: >> snprintf has been available for all officially and unofficially supported >> compilers for Windows, Visual Studio since version 2015 and gcc since, well, >> forever. snprintf is conforming to C99 since the start when compiling using >>

Re: RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK [v5]

2024-08-23 Thread Julian Waters
> snprintf has been available for all officially and unofficially supported > compilers for Windows, Visual Studio since version 2015 and gcc since, well, > forever. snprintf is conforming to C99 since the start when compiling using > gcc, and 2015 when using Visual Studio. Since it conforms to

Re: RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK [v4]

2024-08-23 Thread Julian Waters
> snprintf has been available for all officially and unofficially supported > compilers for Windows, Visual Studio since version 2015 and gcc since, well, > forever. snprintf is conforming to C99 since the start when compiling using > gcc, and 2015 when using Visual Studio. Since it conforms to

Re: RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK [v3]

2024-08-23 Thread Julian Waters
On Tue, 16 Jul 2024 08:59:20 GMT, Julian Waters wrote: >> snprintf has been available for all officially and unofficially supported >> compilers for Windows, Visual Studio since version 2015 and gcc since, well, >> forever. snprintf is conforming to C99 since the start when compiling using >>

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v14]

2024-08-23 Thread Kevin Driver
On Wed, 21 Aug 2024 20:21:47 GMT, Valerie Peng wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> addresses delayed provider selection where parameters are involved > > test/jdk/com/sun/crypto/provider/KDF/Functions.j

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v15]

2024-08-23 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). > > Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). Kevin Driver

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v14]

2024-08-23 Thread Kevin Driver
On Fri, 23 Aug 2024 21:29:29 GMT, Kevin Driver wrote: >> test/jdk/com/sun/crypto/provider/KDF/TestHKDF.java line 187: >> >>> 185: actualPRK, testData.info, >>> 186: testData.outLen); >>> 187: actualOKM = kdfExpand.deriveKey("RAW", kdfParameterSpecExpand); >> >> W

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v14]

2024-08-23 Thread Weijun Wang
On Thu, 22 Aug 2024 21:13:08 GMT, Valerie Peng wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> addresses delayed provider selection where parameters are involved > > src/java.base/share/classes/javax/crypto/KDF.jav

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v14]

2024-08-23 Thread Kevin Driver
On Wed, 21 Aug 2024 20:58:35 GMT, Valerie Peng wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> addresses delayed provider selection where parameters are involved > > test/jdk/com/sun/crypto/provider/KDF/TestHKDF.ja

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v14]

2024-08-23 Thread Kevin Driver
On Wed, 21 Aug 2024 17:46:38 GMT, Valerie Peng wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> addresses delayed provider selection where parameters are involved > > test/jdk/javax/crypto/KDF/Threading.java line 63

Withdrawn: 8325513: Export method for Cipher

2024-08-23 Thread duke
On Wed, 20 Mar 2024 20:37:46 GMT, Weijun Wang wrote: > Add `Cipher::export` API. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/18409

Re: RFR: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI [v10]

2024-08-23 Thread Maurizio Cimadamore
> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting > the use of JNI in the following ways: > > * `System::load` and `System::loadLibrary` are now restricted methods > * `Runtime::load` and `Runtime::loadLibrary` are now restricted methods > * binding a JNI `native` metho