Re: RFR: 8335288: SunPKCS11 initialization will call C_GetMechanismInfo on unsupported mechanisms

2024-08-05 Thread Valerie Peng
On Wed, 17 Jul 2024 00:48:20 GMT, Valerie Peng wrote: > Can someone help review this fix? Changed the required-mechanism check by > checking if the particular mechanism is inside the list of enabled supported > mechanisms. This should be more reliable than calling C_GetMechanismInfo(..) > on t

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v9]

2024-08-05 Thread Sean Mullan
On Tue, 30 Jul 2024 16:04:25 GMT, Kevin Driver wrote: >> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line >> 328: >> >>> 326: } >>> 327: >>> 328: private Extract(List ikms, List salts) { >> >> Should it throw an exception if either or both of the lists

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-05 Thread Sean Mullan
On Fri, 2 Aug 2024 19:19:54 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR

RFR: 8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754

2024-08-05 Thread Jamil Nimeh
This proposed enhancement adds logging to the OCSPTimeout test, which is intermittently failing and difficult to reproduce. The hope is that with extra logging enabled that additional clues as to the cause of these rare failures will become apparent. JBS: https://bugs.openjdk.org/browse/JDK-83

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-05 Thread Sean Mullan
On Thu, 1 Aug 2024 21:05:08 GMT, Weijun Wang wrote: >> I was trying to convey that deriveKey|Data are not like doFinal in that they >> can be called more than once on a single instance. Is there a different way >> to word this? Or is it not important to mention here? > > Not sure. Maybe your se

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-05 Thread Sean Mullan
On Fri, 2 Aug 2024 19:19:54 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR

RFR: 8337723: Remove redundant tests from com/sun/security/sasl/gsskerb

2024-08-05 Thread Fernando Guallini
There are 3 manual GSS-API/Kerberos tests that require a manual setup and were added to the problem list years ago: - com/sun/security/sasl/gsskerb/**AuthOnly**-> Verifies that both client and server have completed the authentication process. - com/sun/security/sasl/gsskerb/**NoSecurityLayer** -