Re: RFR: 8298420: PEM API: Implementation (Preview)

2024-07-24 Thread ExE Boss
On Wed, 24 Jan 2024 00:01:06 GMT, Anthony Scarpino wrote: > Hi all, > > I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a format > for encoding and decoding cryptographic keys and certificates. It will be > integrated into JDK24 as a Preview Feature. Preview features do

Re: RFR: 8298420: PEM API: Implementation (Preview)

2024-07-24 Thread Anthony Scarpino
On Fri, 10 May 2024 23:51:36 GMT, ExE Boss wrote: >> Hi all, >> >> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a >> format for encoding and decoding cryptographic keys and certificates. It >> will be integrated into JDK24 as a Preview Feature. Preview features does

RFR: 8298420: PEM API: Implementation (Preview)

2024-07-24 Thread Anthony Scarpino
Hi all, I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a format for encoding and decoding cryptographic keys and certificates. It will be integrated into JDK24 as a Preview Feature. Preview features does not permanently define the API and it is subject to change in futur

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v6]

2024-07-24 Thread Martin Balao
On Wed, 24 Jul 2024 16:52:27 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used [v2]

2024-07-24 Thread Weijun Wang
On Wed, 24 Jul 2024 19:12:59 GMT, Weijun Wang wrote: >> There is an error in `jarsigner` on the "This JAR contains signed entries >> that aren't signed by alias in this keystore" warning. The exit code is >> determined by >> [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava

2024-07-24 Thread Brian Burkhalter
On Wed, 24 Jul 2024 19:11:42 GMT, Brian Burkhalter wrote: > This proposed change would move the native objects required for NIO file > interaction from the libnio native library to the libjava native library on > Linux, macOS, and Windows. This change passes CI tiers 1-5 jobs on all platforms.

RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava

2024-07-24 Thread Brian Burkhalter
This proposed change would move the native objects required for NIO file interaction from the libnio native library to the libjava native library on Linux, macOS, and Windows. - Commit messages: - 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava Cha

Re: RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used [v2]

2024-07-24 Thread Weijun Wang
On Wed, 24 Jul 2024 19:12:59 GMT, Weijun Wang wrote: >> There is an error in `jarsigner` on the "This JAR contains signed entries >> that aren't signed by alias in this keystore" warning. The exit code is >> determined by >> [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb

Re: RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used [v2]

2024-07-24 Thread Weijun Wang
> There is an error in `jarsigner` on the "This JAR contains signed entries > that aren't signed by alias in this keystore" warning. The exit code is > determined by > [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb38d2cc97f3862ef95a0d26ba49a7/src/jdk.jartool/share/classes/

Re: RFR: 8336667: IAE in DerInputStream.toByteArray

2024-07-24 Thread Valerie Peng
On Mon, 22 Jul 2024 21:28:07 GMT, Weijun Wang wrote: > When reading an indefinite BER `DerValue` from a `DerInputStream`, the > current position of the stream must be placed right after the BER. There is a > bug in the calculation. I will take a look. - PR Comment: https://git.op

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v6]

2024-07-24 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). > > Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). Kevin Driver

Re: RFR: 8336240: Test com/sun/crypto/provider/Cipher/DES/PerformanceTest.java fails with java.lang.ArithmeticException [v4]

2024-07-24 Thread Fernando Guallini
On Fri, 19 Jul 2024 20:32:23 GMT, Bradford Wetmore wrote: > I understand that the main purpose is to provide performance numbers and no > one will be watching it, but if it's not taking too much time, it's nice to > have the additional test for ensuring nothing went wrong when exercising the >

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic [v2]

2024-07-24 Thread dems54
On Thu, 27 Jun 2024 21:32:53 GMT, Valerie Peng wrote: >>> UP @valeriepeng possible to backport PKCS11 configuration attribute part on >>> JDK 17 or 21 ? >> >> I am not sure, let me check and get back to you. > >> UP @valeriepeng possible to backport PKCS11 configuration attribute part on >> JD