Integrated: 8336499: Failure when creating non-CRT RSA private keys in SunPKCS11

2024-07-23 Thread Martin Balao
On Tue, 16 Jul 2024 23:22:45 GMT, Martin Balao wrote: > Hi, > > I'd like to make a proposal to fix > [JDK-8336499](https://bugs.openjdk.org/browse/JDK-8336499). > > With the proposed change, a non-sensitive RSA private key is first > interpreted as a CRT key. If that fails (e.g. one of the at

Re: RFR: 8336499: Failure when creating non-CRT RSA private keys in SunPKCS11 [v2]

2024-07-23 Thread Valerie Peng
On Wed, 17 Jul 2024 16:32:09 GMT, Martin Balao wrote: >> Hi, >> >> I'd like to make a proposal to fix >> [JDK-8336499](https://bugs.openjdk.org/browse/JDK-8336499). >> >> With the proposed change, a non-sensitive RSA private key is first >> interpreted as a CRT key. If that fails (e.g. one of

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v5]

2024-07-23 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). > > Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). Kevin Driver

Integrated: 8322133: getParameterSpec(ECGenParameterSpec.class) on EC AlgorithmParameters does not return standard names

2024-07-23 Thread Ben Perez
On Wed, 3 Jul 2024 15:38:49 GMT, Ben Perez wrote: > 8322133: getParameterSpec(ECGenParameterSpec.class) on EC AlgorithmParameters > does not return standard names This pull request has now been integrated. Changeset: 4c91d5cb Author:Ben Perez Committer: Sean Mullan URL: https://g

Re: RFR: 8322133: getParameterSpec(ECGenParameterSpec.class) on EC AlgorithmParameters does not return standard names [v5]

2024-07-23 Thread duke
On Thu, 11 Jul 2024 20:42:24 GMT, Ben Perez wrote: >> 8322133: getParameterSpec(ECGenParameterSpec.class) on EC >> AlgorithmParameters does not return standard names > > Ben Perez has updated the pull request incrementally with one additional > commit since the last revision: > > fixed typo

Re: RFR: 8322133: getParameterSpec(ECGenParameterSpec.class) on EC AlgorithmParameters does not return standard names [v5]

2024-07-23 Thread Sean Mullan
On Thu, 11 Jul 2024 20:42:24 GMT, Ben Perez wrote: >> 8322133: getParameterSpec(ECGenParameterSpec.class) on EC >> AlgorithmParameters does not return standard names > > Ben Perez has updated the pull request incrementally with one additional > commit since the last revision: > > fixed typo

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v4]

2024-07-23 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). > > Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). Kevin Driver

Re: RFR: 8336240: Test com/sun/crypto/provider/Cipher/DES/PerformanceTest.java fails with java.lang.ArithmeticException [v4]

2024-07-23 Thread Bradford Wetmore
On Fri, 19 Jul 2024 20:32:23 GMT, Bradford Wetmore wrote: >>> While this should work for the systems we use, be aware that it's not >>> guaranteed by the Java API. >>> It's probably fine, or you could also use the !=0?end-start:1 hack as a >>> backup. >>> >>> Otherwise, LGTM. >> >> Thank you

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v3]

2024-07-23 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). > > Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). Kevin Driver

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v2]

2024-07-23 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). > > Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). Kevin Driver

RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview)

2024-07-23 Thread Kevin Driver
Introduce an API for Key Derivation Functions (KDFs), which are cryptographic algorithms for deriving additional keys from a secret key and other data. See [JEP 478](https://openjdk.org/jeps/478). Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). - Commit m

Withdrawn: 8331008: Implement JEP 478: Key Derivation Function API (Preview)

2024-07-23 Thread Kevin Driver
On Tue, 23 Apr 2024 20:42:51 GMT, Kevin Driver wrote: > Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). This pull request has been closed wit

Re: RFR: 8335182: Consolidate and streamline String concat code shapes [v3]

2024-07-23 Thread Claes Redestad
On Tue, 9 Jul 2024 21:16:33 GMT, Claes Redestad wrote: >> This PR attains a speed-up on some microbenchmarks by simplifying how we >> build up the MH combinator tree shape >> (only use prependers with prefix, always add a suffix to the newArray >> combinator), then simplifying/inlining some of

Integrated: 8335182: Consolidate and streamline String concat code shapes

2024-07-23 Thread Claes Redestad
On Thu, 27 Jun 2024 12:27:26 GMT, Claes Redestad wrote: > This PR attains a speed-up on some microbenchmarks by simplifying how we > build up the MH combinator tree shape > (only use prependers with prefix, always add a suffix to the newArray > combinator), then simplifying/inlining some of the