Re: RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout

2024-07-22 Thread SendaoYan
On Sat, 20 Jul 2024 15:32:37 GMT, SendaoYan wrote: > Hi all, > The testcase > `test/jdk/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#actalisauthenticationrootca` > run Error, because the `@run` set conflicted with `/manual` and `/timeout`. > I think the `/ti

Re: RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout

2024-07-22 Thread duke
On Sat, 20 Jul 2024 15:32:37 GMT, SendaoYan wrote: > Hi all, > The testcase > `test/jdk/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#actalisauthenticationrootca` > run Error, because the `@run` set conflicted with `/manual` and `/timeout`. > I think the `/ti

Re: RFR: 8336499: Failure when creating non-CRT RSA private keys in SunPKCS11 [v2]

2024-07-22 Thread Valerie Peng
On Wed, 17 Jul 2024 16:32:09 GMT, Martin Balao wrote: >> Hi, >> >> I'd like to make a proposal to fix >> [JDK-8336499](https://bugs.openjdk.org/browse/JDK-8336499). >> >> With the proposed change, a non-sensitive RSA private key is first >> interpreted as a CRT key. If that fails (e.g. one of

RFR: 8336934: Clean up JavaLangReflectAccess

2024-07-22 Thread Chen Liang
Removed redundant APIs in `JavaLangReflectAccess` and added general warning against using `SharedSecrets`. - Commit messages: - 8336934: Clean up JavaLangReflectAccess Changes: https://git.openjdk.org/jdk/pull/20290/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20290&ran

Re: RFR: 8335288: SunPKCS11 initialization will call C_GetMechanismInfo on unsupported mechanisms

2024-07-22 Thread Valerie Peng
On Wed, 17 Jul 2024 00:48:20 GMT, Valerie Peng wrote: > Can someone help review this fix? Changed the required-mechanism check by > checking if the particular mechanism is inside the list of enabled supported > mechanisms. This should be more reliable than calling C_GetMechanismInfo(..) > on t

Integrated: 8336935: Test sun/security/krb5/auto/RealmSpecificValues.java fails: java.lang.RuntimeException: Should not reach here

2024-07-22 Thread Weijun Wang
On Mon, 22 Jul 2024 21:40:15 GMT, Weijun Wang wrote: > The test sets system properties. Should run in `othervm`. This pull request has now been integrated. Changeset: d63d6e23 Author:Weijun Wang URL: https://git.openjdk.org/jdk/commit/d63d6e23d123e82cef1372aed31b5846fb6d23fd Stats:

Re: RFR: 8336935: Test sun/security/krb5/auto/RealmSpecificValues.java fails: java.lang.RuntimeException: Should not reach here

2024-07-22 Thread Weijun Wang
On Mon, 22 Jul 2024 22:12:53 GMT, David Holmes wrote: > Seems reasonable. I assume the actual conf file being written will be in the > test's scratch directory so no interference possible with other tests? Yes. - PR Comment: https://git.openjdk.org/jdk/pull/20284#issuecomment-2243

Re: RFR: 8336935: Test sun/security/krb5/auto/RealmSpecificValues.java fails: java.lang.RuntimeException: Should not reach here

2024-07-22 Thread David Holmes
On Mon, 22 Jul 2024 21:40:15 GMT, Weijun Wang wrote: > The test sets system properties. Should run in `othervm`. Seems reasonable. I assume the actual conf file being written will be in the test's scratch directory so no interference possible with other tests? - Marked as reviewed

Re: RFR: 8336935: Test sun/security/krb5/auto/RealmSpecificValues.java fails: java.lang.RuntimeException: Should not reach here

2024-07-22 Thread Hai-May Chao
On Mon, 22 Jul 2024 21:40:15 GMT, Weijun Wang wrote: > The test sets system properties. Should run in `othervm`. Marked as reviewed by hchao (Committer). - PR Review: https://git.openjdk.org/jdk/pull/20284#pullrequestreview-2192619833

RFR: 8336667: IAE in DerInputStream.toByteArray

2024-07-22 Thread Weijun Wang
When reading an indefinite BER `DerValue` from a `DerInputStream`, the current position of the stream must be placed right after the BER. There is a bug in the calculation. - Commit messages: - the fix Changes: https://git.openjdk.org/jdk/pull/20283/files Webrev: https://webrevs

RFR: 8336935: Test sun/security/krb5/auto/RealmSpecificValues.java fails: java.lang.RuntimeException: Should not reach here

2024-07-22 Thread Weijun Wang
The test sets system properties. Should run in `othervm`. - Commit messages: - the fix Changes: https://git.openjdk.org/jdk/pull/20284/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20284&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336935 Stats: 1 line in 1 fi

Re: RFR: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout

2024-07-22 Thread Rajan Halade
On Sat, 20 Jul 2024 15:32:37 GMT, SendaoYan wrote: > Hi all, > The testcase > `test/jdk/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#actalisauthenticationrootca` > run Error, because the `@run` set conflicted with `/manual` and `/timeout`. > I think the `/ti

Integrated: 8333772: Incorrect Kerberos behavior when udp_preference_limit = 0

2024-07-22 Thread Weijun Wang
On Mon, 10 Jun 2024 20:29:54 GMT, Weijun Wang wrote: > Allow `udp_preference_limit = 0` to force TCP. > > The reason for this bug is that it was read in a similar way as `kdc_timeout` > and `max_retries`, both must be positive to have effect. This pull request has now been integrated. Changes

Re: RFR: 8335791: Speed ​​up j.u.Formatter & String.format [v4]

2024-07-22 Thread Roger Riggs
On Sat, 6 Jul 2024 00:15:04 GMT, Shaojin Wen wrote: >> String.format is widely used, and improving its performance is very >> meaningful. This PR can significantly improve the performance of >> String.format. Sorry, there are many changes, which will take a lot of time. >> I hope you can revie

Integrated: 8336039: Doccheck: HTML warnings, broken links and missing files in java.base documentation

2024-07-22 Thread Nizar Benalla
On Fri, 19 Jul 2024 11:11:38 GMT, Nizar Benalla wrote: > Can I get a review for this change that fixes some broken links in javadoc > comments? The new docs are hosted > [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/). > > It's mostly fixing some relative links.

Re: RFR: 8336039: Doccheck: HTML warnings, broken links and missing files in java.base documentation [v5]

2024-07-22 Thread Nizar Benalla
On Sun, 21 Jul 2024 21:15:03 GMT, Nizar Benalla wrote: >> Can I get a review for this change that fixes some broken links in javadoc >> comments? The new docs are hosted >> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/). >> >> It's mostly fixing some relative li

Re: RFR: 8336039: Doccheck: HTML warnings, broken links and missing files in java.base documentation [v5]

2024-07-22 Thread duke
On Sun, 21 Jul 2024 21:15:03 GMT, Nizar Benalla wrote: >> Can I get a review for this change that fixes some broken links in javadoc >> comments? The new docs are hosted >> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/). >> >> It's mostly fixing some relative li

Re: RFR: 8336240: Test com/sun/crypto/provider/Cipher/DES/PerformanceTest.java fails with java.lang.ArithmeticException [v4]

2024-07-22 Thread Fernando Guallini
On Fri, 19 Jul 2024 20:32:23 GMT, Bradford Wetmore wrote: > Is it slow enough these days that we couldn't remove the `/manual`? How long > is the test taking? @bradfordwetmore It does not take much time, average ~12 seconds - PR Comment: https://git.openjdk.org/jdk/pull/20135#issu

Re: RFR: 8336039: Doccheck: HTML warnings, broken links and missing files in java.base documentation [v5]

2024-07-22 Thread Daniel Jeliński
On Sun, 21 Jul 2024 21:15:03 GMT, Nizar Benalla wrote: >> Can I get a review for this change that fixes some broken links in javadoc >> comments? The new docs are hosted >> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/). >> >> It's mostly fixing some relative li