Re: RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK [v3]

2024-07-16 Thread David Holmes
On Tue, 16 Jul 2024 08:59:20 GMT, Julian Waters wrote: >> snprintf has been available for all officially and unofficially supported >> compilers for Windows, Visual Studio since version 2015 and gcc since, well, >> forever. snprintf is conforming to C99 since the start when compiling using >>

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v3]

2024-07-16 Thread Anthony Scarpino
> Hi > > This change is to improve TLS 1.3 session resumption by allowing a TLS server > to send more than one resumption ticket per connection and clients to store > more. Resumption is a quick way to use an existing TLS session to establish > another session by avoiding the long TLS full han

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v2]

2024-07-16 Thread Anthony Scarpino
On Tue, 25 Jun 2024 09:57:46 GMT, Daniel Jeliński wrote: > Please add a test that starts multiple resumptions in parallel using the > tickets received in the first connection. The test should verify that: > > * each resumption uses a different ticket > > * all resumptions succeed > >

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v2]

2024-07-16 Thread Anthony Scarpino
On Mon, 24 Jun 2024 16:03:43 GMT, Anthony Scarpino wrote: >> Hi >> >> This change is to improve TLS 1.3 session resumption by allowing a TLS >> server to send more than one resumption ticket per connection and clients to >> store more. Resumption is a quick way to use an existing TLS session

RFR: 8335288: SunPKCS11 initialization will call C_GetMechanismInfo on unsupported mechanisms

2024-07-16 Thread Valerie Peng
Can someone help review this fix? Changed the required-mechanism check by checking if the particular mechanism is inside the list of enabled supported mechanisms. This should be more reliable than calling C_GetMechanismInfo(..) on the required mechanism given vendors may return various sorts of

Re: RFR: 8328723: IP Address error when client enables HTTPS endpoint check on server socket [v2]

2024-07-16 Thread Bradford Wetmore
On Tue, 9 Jul 2024 07:13:06 GMT, Prajwal Kumaraswamy wrote: >> The client identity checks when "HTTPS" endpoint identification algorithm is >> set on SSL server throws "java.security.cert.CertificateException: No >> subject alternative names present" when client certificate's SubjectAltName >

RFR: 8336499: Failure when creating non-CRT RSA private keys in SunPKCS11

2024-07-16 Thread Martin Balao
Hi, I'd like to make a proposal to fix [JDK-8336499](https://bugs.openjdk.org/browse/JDK-8336499). With the proposed change, a non-sensitive RSA private key is first interpreted as a CRT key. If that fails (e.g. one of the attributes is not available), a second attempt is made to interpret the

Re: RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v4]

2024-07-16 Thread Bradford Wetmore
On Thu, 6 Jun 2024 15:45:54 GMT, Fernando Guallini wrote: >> As highlighted in the bug description, The test >> **security/Security/SynchronizedAccess.java** have some issues: >> >> 1. it needs to implement the sigalg, otherwise it throws >> java.security.NoSuchAlgorithmException . Even thoug

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v86]

2024-07-16 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request with a new target base due to a merge or a rebase.

Re: RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK [v3]

2024-07-16 Thread Daniel Jeliński
On Tue, 16 Jul 2024 08:59:20 GMT, Julian Waters wrote: >> snprintf has been available for all officially and unofficially supported >> compilers for Windows, Visual Studio since version 2015 and gcc since, well, >> forever. snprintf is conforming to C99 since the start when compiling using >>

Re: RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK [v2]

2024-07-16 Thread Kim Barrett
On Tue, 16 Jul 2024 08:52:01 GMT, Julian Waters wrote: >> src/jdk.jdwp.agent/windows/native/libjdwp/util_md.h line 32: >> >>> 30: #include /* for _MAx_PATH */ >>> 31: >>> 32: typedef unsigned long long UNSIGNED_JLONG; >> >> This change has nothing to do with _sprintf. Not sure why it's

Re: RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK [v3]

2024-07-16 Thread Kim Barrett
On Tue, 16 Jul 2024 08:59:20 GMT, Julian Waters wrote: >> snprintf has been available for all officially and unofficially supported >> compilers for Windows, Visual Studio since version 2015 and gcc since, well, >> forever. snprintf is conforming to C99 since the start when compiling using >>

Re: RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK [v3]

2024-07-16 Thread Julian Waters
> snprintf has been available for all officially and unofficially supported > compilers for Windows, Visual Studio since version 2015 and gcc since, well, > forever. snprintf is conforming to C99 since the start when compiling using > gcc, and 2015 when using Visual Studio. Since it conforms to

Re: RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK [v2]

2024-07-16 Thread Julian Waters
On Mon, 15 Jul 2024 16:30:02 GMT, Kim Barrett wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> USe os::snprintf in HotSpot > > src/jdk.jdwp.agent/windows/native/libjdwp/util_md.h line 32: > >> 30: #include /