RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK

2024-07-11 Thread Julian Waters
snprintf has been available for all officially and unofficially supported compilers for Windows, Visual Studio since version 2015 and gcc since, well, forever. snprintf is conforming to C99 since the start when compiling using gcc, and 2015 when using Visual Studio. Since it conforms to C99 and

Re: RFR: 8335182: Consolidate and streamline String concat code shapes [v3]

2024-07-11 Thread Chen Liang
On Tue, 9 Jul 2024 21:16:33 GMT, Claes Redestad wrote: >> This PR attains a speed-up on some microbenchmarks by simplifying how we >> build up the MH combinator tree shape >> (only use prependers with prefix, always add a suffix to the newArray >> combinator), then simplifying/inlining some of

Re: RFR: 8322133: getParameterSpec(ECGenParameterSpec.class) on EC AlgorithmParameters does not return standard names [v5]

2024-07-11 Thread Ben Perez
> 8322133: getParameterSpec(ECGenParameterSpec.class) on EC AlgorithmParameters > does not return standard names Ben Perez has updated the pull request incrementally with one additional commit since the last revision: fixed typo - Changes: - all: https://git.openjdk.org/jdk/p

Re: RFR: 8322133: getParameterSpec(ECGenParameterSpec.class) on EC AlgorithmParameters does not return standard names [v4]

2024-07-11 Thread Sean Mullan
On Thu, 11 Jul 2024 20:25:35 GMT, Ben Perez wrote: >> 8322133: getParameterSpec(ECGenParameterSpec.class) on EC >> AlgorithmParameters does not return standard names > > Ben Perez has updated the pull request incrementally with one additional > commit since the last revision: > > Updated co

Re: RFR: 8322133: getParameterSpec(ECGenParameterSpec.class) on EC AlgorithmParameters does not return standard names [v4]

2024-07-11 Thread Ben Perez
> 8322133: getParameterSpec(ECGenParameterSpec.class) on EC AlgorithmParameters > does not return standard names Ben Perez has updated the pull request incrementally with one additional commit since the last revision: Updated copyrite, made curve selection more explicit - Chang

Re: RFR: 8319332: Security properties files inclusion [v17]

2024-07-11 Thread Francisco Ferrari Bihurriet
On Thu, 11 Jul 2024 19:41:56 GMT, Francisco Ferrari Bihurriet wrote: >> The implementation of this proposal is based on the requirements, >> specification and design choices described in the [JDK-8319332] ticket and >> its respective CSR [JDK-8319333]. What follows are implementation notes >>

Re: RFR: 8319332: Security properties files inclusion [v17]

2024-07-11 Thread Francisco Ferrari Bihurriet
> The implementation of this proposal is based on the requirements, > specification and design choices described in the [JDK-8319332] ticket and > its respective CSR [JDK-8319333]. What follows are implementation notes > organized per functional component, with the purpose of assisting to naviga

Re: RFR: 4966250: SSLSessionContext.setSessionTimeout() documentation could be updated [v3]

2024-07-11 Thread Mark Powers
On Wed, 29 May 2024 19:20:27 GMT, Sean Mullan wrote: >> Mark Powers has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Joe Darcy's comment > > src/java.base/share/classes/javax/net/ssl/SSLSessionContext.java line 92: > >> 90: * When t

RFR: 8336240: Test com/sun/crypto/provider/Cipher/DES/PerformanceTest.java fails with java.lang.ArithmeticException

2024-07-11 Thread Fernando Guallini
The manual test Cipher/DES/PerformanceTest.java fails with ArithmeticException due to potential division by zero. The issue arises when calculating the elapsed time using end - start, which could result in zero milliseconds if start and end are identical due to the high speed of execution. This