Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic [v2]

2024-06-27 Thread Valerie Peng
On Fri, 14 Jun 2024 18:56:12 GMT, Valerie Peng wrote: > UP @valeriepeng possible to backport PKCS11 configuration attribute part on > JDK 17 or 21 ? Based on the feedback that I got, it should be ok to backport the PKCS11 configuration attribute, separate CSRs would be needed for that though.

Re: RFR: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test [v2]

2024-06-27 Thread Weijun Wang
On Thu, 27 Jun 2024 15:37:45 GMT, Fernando Guallini wrote: >> The following test: >> **com/sun/security/auth/callback/TextCallbackHandler/Default.java** is >> currently marked to be run manually because user inputs are required in the >> console, but instead it can be automated by providing a

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v2]

2024-06-27 Thread Anthony Scarpino
On Tue, 25 Jun 2024 09:14:12 GMT, Daniel Jeliński wrote: >> Anthony Scarpino has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - remove frag issue >> - Comments, remove thread, set NST default to 1, allow 0 >> - comment cleanup > > src

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v2]

2024-06-27 Thread Anthony Scarpino
On Tue, 25 Jun 2024 09:38:04 GMT, Daniel Jeliński wrote: >> Anthony Scarpino has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - remove frag issue >> - Comments, remove thread, set NST default to 1, allow 0 >> - comment cleanup > > src

Re: RFR: 8335182: Consolidate and streamline String concat code shapes

2024-06-27 Thread Chen Liang
On Thu, 27 Jun 2024 12:27:26 GMT, Claes Redestad wrote: > This PR attains a speed-up on some microbenchmarks by simplifying how we > build up the MH combinator tree shape > (only use prependers with prefix, always add a suffix to the newArray > combinator), then simplifying/inlining some of the

Re: RFR: 8330842: Support AES CBC with Ciphertext Stealing (CTS) in SunPKCS11 [v10]

2024-06-27 Thread duke
On Fri, 7 Jun 2024 19:25:45 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, >> >> I would like to propose an implementation to support AES CBC with Ciphertext >> Stealing (CTS) in SunPKCS11, according to what has been specified in >> [JDK-8330843 CSR](https://bugs.openjdk.org/browse/JDK-833084

Re: RFR: 8335182: Consolidate and streamline String concat code shapes

2024-06-27 Thread Claes Redestad
On Thu, 27 Jun 2024 16:05:09 GMT, Chen Liang wrote: >> This PR attains a speed-up on some microbenchmarks by simplifying how we >> build up the MH combinator tree shape >> (only use prependers with prefix, always add a suffix to the newArray >> combinator), then simplifying/inlining some of the

Re: RFR: 8335182: Consolidate and streamline String concat code shapes

2024-06-27 Thread Chen Liang
On Thu, 27 Jun 2024 12:27:26 GMT, Claes Redestad wrote: > This PR attains a speed-up on some microbenchmarks by simplifying how we > build up the MH combinator tree shape > (only use prependers with prefix, always add a suffix to the newArray > combinator), then simplifying/inlining some of the

Re: RFR: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test [v2]

2024-06-27 Thread Fernando Guallini
On Thu, 27 Jun 2024 12:48:00 GMT, Weijun Wang wrote: >> @wangweij >> I was handling the callback in 2 separate calls because it was blocking and >> timing out while waiting for input. Now, using _HumanInputStream_ allows >> handling it in a single call. Unfortunately this class is not visible

Re: RFR: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test [v2]

2024-06-27 Thread Fernando Guallini
> The following test: > **com/sun/security/auth/callback/TextCallbackHandler/Default.java** is > currently marked to be run manually because user inputs are required in the > console, but instead it can be automated by providing a custom inputStream to > System.in in the actual test to simulate

Re: RFR: 8335182: Consolidate and streamline String concat code shapes

2024-06-27 Thread Jorn Vernee
On Thu, 27 Jun 2024 12:27:26 GMT, Claes Redestad wrote: > This PR attains a speed-up on some microbenchmarks by simplifying how we > build up the MH combinator tree shape > (only use prependers with prefix, always add a suffix to the newArray > combinator), then simplifying/inlining some of the

Integrated: 8330842: Support AES CBC with Ciphertext Stealing (CTS) in SunPKCS11

2024-06-27 Thread Francisco Ferrari Bihurriet
On Mon, 22 Apr 2024 18:31:37 GMT, Francisco Ferrari Bihurriet wrote: > Hi, > > I would like to propose an implementation to support AES CBC with Ciphertext > Stealing (CTS) in SunPKCS11, according to what has been specified in > [JDK-8330843 CSR](https://bugs.openjdk.org/browse/JDK-8330843).

[jdk23] Integrated: 8326705: Test CertMsgCheck.java fails to find alert certificate_required

2024-06-27 Thread Anthony Scarpino
On Wed, 26 Jun 2024 23:01:50 GMT, Anthony Scarpino wrote: > Hi, > > I need a review of this clean backport of this test fix to jdk23. > > Tony This pull request has now been integrated. Changeset: 98fd657c Author:Anthony Scarpino URL: https://git.openjdk.org/jdk/commit/98fd657cfa

Re: [jdk23] RFR: 8326705: Test CertMsgCheck.java fails to find alert certificate_required

2024-06-27 Thread Rajan Halade
On Wed, 26 Jun 2024 23:01:50 GMT, Anthony Scarpino wrote: > Hi, > > I need a review of this clean backport of this test fix to jdk23. > > Tony Marked as reviewed by rhalade (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19917#pullrequestreview-2145507373

Re: RFR: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test

2024-06-27 Thread Weijun Wang
On Thu, 27 Jun 2024 10:00:31 GMT, Fernando Guallini wrote: >> Try if this class works for you. >> https://github.com/openjdk/jdk/blob/45a616a891e4a4b0e77b1f2fa040522f4a99d172/test/jdk/sun/security/tools/keytool/KeyToolTest.java#L1885 > > @wangweij > I was handling the callback in 2 separate ca

RFR: 8335182: Consolidate and streamline String concat code shapes

2024-06-27 Thread Claes Redestad
This PR attains a speed-up on some microbenchmarks by simplifying how we build up the MH combinator tree shape (only use prependers with prefix, always add a suffix to the newArray combinator), then simplifying/inlining some of the code in the helper functions. Many simple concatenation expres

Re: RFR: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test

2024-06-27 Thread Fernando Guallini
On Wed, 26 Jun 2024 16:11:52 GMT, Weijun Wang wrote: >> test/jdk/com/sun/security/auth/callback/TextCallbackHandler/Default.java >> line 80: >> >>> 78: pipedOut.write("-1\n".getBytes()); >>> 79: pipedOut.flush(); >>> 80: textHandler.handle(new Callback[]{callback}); >>