Re: RFR: 8326705: Test CertMsgCheck.java fails to find alert certificate_required

2024-06-20 Thread Sibabrata Sahoo
On Wed, 5 Jun 2024 02:57:41 GMT, Anthony Scarpino wrote: > Hi, > > I need a review for this simple change to fix a threading problem with the > test. The server thread was not completing before the check occurred on the > main thread. The failure showed up in windows and macos, but not linux.

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-20 Thread Anthony Scarpino
On Thu, 20 Jun 2024 05:15:10 GMT, John Jiang wrote: > This enhancement allows the server side to send multiple tickets and the > client side to store multiple ones. However, how does the client side use the > tickets in the cache? Yes > > This PR just takes the client side to find the first

Re: RFR: 8248981: Specify list of standard message digest and mgf algorithms for RSASSA-PSS signature

2024-06-20 Thread Valerie Peng
On Fri, 14 Jun 2024 15:32:15 GMT, Sean Mullan wrote: > Added links from the `PSSParameterSpec` API to new section in Standard > Algorithm Names specification for PSSParameterSpec (changes for that are in > closed repo). Also made a couple of links to the Standard Algorithm Names > specificatio

Re: RFR: 8248981: Specify list of standard message digest and mgf algorithms for RSASSA-PSS signature

2024-06-20 Thread Valerie Peng
On Fri, 14 Jun 2024 15:32:15 GMT, Sean Mullan wrote: > Added links from the `PSSParameterSpec` API to new section in Standard > Algorithm Names specification for PSSParameterSpec (changes for that are in > closed repo). Also made a couple of links to the Standard Algorithm Names > specificatio

Re: RFR: 8333364: Minor cleanup could be done in com.sun.crypto.provider [v4]

2024-06-20 Thread Mark Powers
On Fri, 14 Jun 2024 13:11:06 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-864 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > move variables to above try block Thanks for the review Valerie! I just ra

RFR: 8334441: Mark tests in jdk_security_infra group as manual

2024-06-20 Thread Rajan Halade
Updated all the tests that depend on external infrastructure services as manual. These tests may fail with external reasons, for instance - change in CA test portal, certificate status updates, or network issues. - Commit messages: - Update comments - comment explaining why these

Re: RFR: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538 [v3]

2024-06-20 Thread Volodymyr Paprotski
On Mon, 17 Jun 2024 16:38:55 GMT, Volodymyr Paprotski wrote: >> This fix recovers XDH performance but removes some of the P256 gains >> (~-8-14%). Still faster, but not as much. >> >> The fix is to undo 'int' return type on mult()/square(), which allowed to >> return partially reduced result (

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v80]

2024-06-20 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). Kevin Driver has updated the pull request with a new target base due to a merge or a rebase.

Re: RFR: 8334201: Exclude CAInterop.java#certignarootca

2024-06-20 Thread Rajan Halade
On Wed, 19 Jun 2024 15:57:31 GMT, Thomas Stuefe wrote: > What is the point of stalling this PR? The test causes test errors, so it > should be problemlisted. And if https://bugs.openjdk.org/browse/JDK-8331883 > is urgent, it should be worked on with high priority. But surely there is no > need

Re: RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v4]

2024-06-20 Thread Fernando Guallini
On Thu, 6 Jun 2024 15:45:54 GMT, Fernando Guallini wrote: >> As highlighted in the bug description, The test >> **security/Security/SynchronizedAccess.java** have some issues: >> >> 1. it needs to implement the sigalg, otherwise it throws >> java.security.NoSuchAlgorithmException . Even thoug

Re: RFR: 8333364: Minor cleanup could be done in com.sun.crypto.provider [v4]

2024-06-20 Thread Valerie Peng
On Fri, 14 Jun 2024 13:11:06 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-864 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > move variables to above try block Marked as reviewed by valeriep (Reviewer)