Re: RFR: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538 [v2]

2024-06-14 Thread Sandhya Viswanathan
On Fri, 14 Jun 2024 22:01:44 GMT, Volodymyr Paprotski wrote: >> This fix recovers XDH performance but removes some of the P256 gains >> (~-8-14%). Still faster, but not as much. >> >> The fix is to undo 'int' return type on mult()/square(), which allowed to >> return partially reduced result (

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-14 Thread Anthony Scarpino
On Fri, 14 Jun 2024 18:51:02 GMT, Daniel Jeliński wrote: >> This is a low level networking error beyond my control. All this code can >> do is accept that the operating system has sent it a fatal error that has >> blocked the servers ability to read data from the socket on data that was by >>

Re: RFR: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538 [v2]

2024-06-14 Thread Volodymyr Paprotski
> This fix recovers XDH performance but removes some of the P256 gains > (~-8-14%). Still faster, but not as much. > > The fix is to undo 'int' return type on mult()/square(), which allowed to > return partially reduced result (e.g. this avoids extra reductions when > mult() result is fed into

Re: RFR: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538

2024-06-14 Thread Volodymyr Paprotski
On Fri, 14 Jun 2024 20:23:04 GMT, Volodymyr Paprotski wrote: > This fix recovers XDH performance but removes some of the P256 gains > (~-8-14%). Still faster, but not as much. > > The fix is to undo 'int' return type on mult()/square(), which allowed to > return partially reduced result (i.e.

RFR: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538

2024-06-14 Thread Volodymyr Paprotski
This fix recovers XDH performance but removes some of the P256 gains (~-8-14%). Still faster, but not as much. The fix is to undo 'int' return type on mult()/square(), which allowed to return partially reduced result (i.e. this avoids extra reductions when mult() result is fed into addition). T

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic [v2]

2024-06-14 Thread Valerie Peng
On Tue, 16 Apr 2024 22:30:57 GMT, Valerie Peng wrote: >> What about testing? > > @mcpowers I am about to leave for vacation. Will wait for your review and > resume on this PR after I return. Thanks! > UP @valeriepeng possible to backport PKCS11 configuration attribute part on > JDK 17 or 21 ?

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-14 Thread Daniel Jeliński
On Fri, 14 Jun 2024 16:44:42 GMT, Anthony Scarpino wrote: >> And your suggestion would be? > > This is a low level networking error beyond my control. All this code can do > is accept that the operating system has sent it a fatal error that has > blocked the servers ability to read data from

Re: RFR: 8333867: SHA3 performance can be improved [v3]

2024-06-14 Thread Valerie Peng
On Fri, 14 Jun 2024 10:39:45 GMT, Ferenc Rakoczi wrote: >> This PR removes some unnecessary conversions between byte arrays and long >> arrays during SHA3 digest computations. > > Ferenc Rakoczi has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: 8333867: SHA3 performance can be improved [v3]

2024-06-14 Thread Valerie Peng
On Fri, 14 Jun 2024 10:39:45 GMT, Ferenc Rakoczi wrote: >> This PR removes some unnecessary conversions between byte arrays and long >> arrays during SHA3 digest computations. > > Ferenc Rakoczi has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: 8333867: SHA3 performance can be improved [v2]

2024-06-14 Thread Valerie Peng
On Fri, 14 Jun 2024 09:47:31 GMT, Ferenc Rakoczi wrote: >> src/java.base/share/classes/sun/security/provider/SHA3.java line 73: >> >>> 71: // The following array is allocated to size WIDTH bytes, but we only >>> 72: // ever use the first blockSize bytes it (for bytes <-> long >>> conver

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-14 Thread Anthony Scarpino
On Fri, 14 Jun 2024 07:46:19 GMT, Daniel Jeliński wrote: >> Hi >> >> This change is to improve TLS 1.3 session resumption by allowing a TLS >> server to send more than one resumption ticket per connection and clients to >> store more. Resumption is a quick way to use an existing TLS session t

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-14 Thread Anthony Scarpino
On Fri, 14 Jun 2024 01:14:55 GMT, Jamil Nimeh wrote: >> Hi >> >> This change is to improve TLS 1.3 session resumption by allowing a TLS >> server to send more than one resumption ticket per connection and clients to >> store more. Resumption is a quick way to use an existing TLS session to >

Re: [jdk23] RFR: 8333724: Problem list security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#teliasonerarootcav1

2024-06-14 Thread Christoph Langer
On Thu, 13 Jun 2024 13:07:23 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of > [JDK-8333724](https://bugs.openjdk.org/browse/JDK-8333724), commit > [8ffc35d1](https://github.com/openjdk/jdk/commit/8ffc35d117846a7a2aa08afed662273d2f887770) > from the [openjd

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-14 Thread Anthony Scarpino
On Fri, 14 Jun 2024 09:09:58 GMT, Daniel Jeliński wrote: >> Hi >> >> This change is to improve TLS 1.3 session resumption by allowing a TLS >> server to send more than one resumption ticket per connection and clients to >> store more. Resumption is a quick way to use an existing TLS session t

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-14 Thread Anthony Scarpino
On Fri, 14 Jun 2024 16:18:07 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/sun/security/ssl/NewSessionTicket.java line 388: >> >>> 386: /* >>> 387: * This thread addresses a Windows only networking issue >>> found with >>> 388: * SSLSocketBru

Re: [jdk23] RFR: 8333724: Problem list security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#teliasonerarootcav1

2024-06-14 Thread Sean Mullan
On Thu, 13 Jun 2024 13:24:19 GMT, Christoph Langer wrote: >> Hi all, >> >> This pull request contains a backport of >> [JDK-8333724](https://bugs.openjdk.org/browse/JDK-8333724), commit >> [8ffc35d1](https://github.com/openjdk/jdk/commit/8ffc35d117846a7a2aa08afed662273d2f887770) >> from the [

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-14 Thread Anthony Scarpino
On Fri, 14 Jun 2024 08:42:23 GMT, Daniel Jeliński wrote: >> Hi >> >> This change is to improve TLS 1.3 session resumption by allowing a TLS >> server to send more than one resumption ticket per connection and clients to >> store more. Resumption is a quick way to use an existing TLS session t

RFR: 8248981: Specify list of standard message digest and mgf algorithms for RSASSA-PSS signature

2024-06-14 Thread Sean Mullan
Added links from the `PSSParameterSpec` API to new section in Standard Algorithm Names specification for PSSParameterSpec (changes for that are in closed repo). Also made a couple of links to the Standard Algorithm Names specification in `ECGenParameterSpec` and `NamedParameterSpec` more specifi

Re: RFR: 8333364: Minor cleanup could be done in com.sun.crypto.provider [v4]

2024-06-14 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-864 Mark Powers has updated the pull request incrementally with one additional commit since the last revision: move variables to above try block - Changes: - all: https://git.openjdk.org/jdk/pull/19535/files - new: https://git.openjdk

Re: RFR: 8333477: Delete extra empty spaces in Makefiles [v2]

2024-06-14 Thread Chen Liang
On Fri, 14 Jun 2024 10:52:40 GMT, Magnus Ihse Bursie wrote: >> Ah, I had not realized that there was more than 1 newline. GitHub's UI >> confused me here, so we're good to go > > GitHub's UI assumes the final line has an line break. If it is missing, it > displays a red 🚫 at the end of the last

Re: RFR: 8333477: Delete extra empty spaces in Makefiles [v2]

2024-06-14 Thread Magnus Ihse Bursie
On Fri, 7 Jun 2024 13:34:45 GMT, Julian Waters wrote: >> I find the extra trailing newlines through below shell command: >> >> for i in `find . -iname "Makefile*" | sed "/./build/d"` ; do tail -n 2 $i | >> grep -c "^$" | grep -q "^1$" ; if [[ 0 -eq $? ]] ; then echo $i ; fi ; done >> >> >> Th

Re: RFR: 8333867: SHA3 performance can be improved [v3]

2024-06-14 Thread Ferenc Rakoczi
> This PR removes some unnecessary conversions between byte arrays and long > arrays during SHA3 digest computations. Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision: Accept more review suggestions - Changes: - all:

Re: RFR: 8333867: SHA3 performance can be improved [v2]

2024-06-14 Thread Ferenc Rakoczi
On Fri, 14 Jun 2024 05:56:05 GMT, Andrey Turbanov wrote: >> Ferenc Rakoczi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix clone(), accept review suggestions. > > src/java.base/share/classes/sun/security/provider/SHA3.java line 152:

Re: RFR: 8333867: SHA3 performance can be improved [v2]

2024-06-14 Thread Ferenc Rakoczi
On Thu, 13 Jun 2024 20:25:22 GMT, Valerie Peng wrote: >> Ferenc Rakoczi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix clone(), accept review suggestions. > > src/java.base/share/classes/sun/security/provider/SHA3.java line 73: > >

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-14 Thread Daniel Jeliński
On Wed, 29 May 2024 18:53:55 GMT, Anthony Scarpino wrote: > Hi > > This change is to improve TLS 1.3 session resumption by allowing a TLS server > to send more than one resumption ticket per connection and clients to store > more. Resumption is a quick way to use an existing TLS session to e

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-14 Thread Daniel Jeliński
On Wed, 29 May 2024 18:53:55 GMT, Anthony Scarpino wrote: > Hi > > This change is to improve TLS 1.3 session resumption by allowing a TLS server > to send more than one resumption ticket per connection and clients to store > more. Resumption is a quick way to use an existing TLS session to e