On Fri, 14 Jun 2024 06:23:32 GMT, Sibabrata Sahoo wrote:
> Tests added against ECDSA and ECDH NIST Test vector.
test/jdk/sun/security/ec/ECDSAPrimitive.java line 255:
> 253: MutablePoint R = ecOps.multiply(publicKeyPoint, u2Bytes);
> 254: AffinePoint a1 = ops.basePointMultiply(u
On Fri, 14 Jun 2024 06:23:32 GMT, Sibabrata Sahoo wrote:
> Tests added against ECDSA and ECDH NIST Test vector.
test/jdk/sun/security/ec/ECDHPrimitive.java line 33:
> 31: import javax.crypto.*;
> 32:
> 33: import jdk.test.lib.Asserts;
Usage of Asserts and removed corresponding local code
tes
Tests added against ECDSA and ECDH NIST Test vector.
-
Commit messages:
- 8333754: Add a Test against ECDSA and ECDH NIST Test vector
- 8333754: Add ECDSAPrimitive.java to open repo
Changes: https://git.openjdk.org/jdk/pull/19715/files
Webrev: https://webrevs.openjdk.org/?repo=jd
On Wed, 12 Jun 2024 14:08:43 GMT, Ferenc Rakoczi wrote:
>> This PR removes some unnecessary conversions between byte arrays and long
>> arrays during SHA3 digest computations.
>
> Ferenc Rakoczi has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Wed, 29 May 2024 18:53:55 GMT, Anthony Scarpino
wrote:
> Hi
>
> This change is to improve TLS 1.3 session resumption by allowing a TLS server
> to send more than one resumption ticket per connection and clients to store
> more. Resumption is a quick way to use an existing TLS session to e
On Thu, 13 Jun 2024 12:32:58 GMT, SendaoYan wrote:
> Hi all,
> Test
> `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5`
> report failure as failed to validate, before the validate issue has been
> fixed, should we problem list the testcase.
On Thu, 13 Jun 2024 14:38:08 GMT, SendaoYan wrote:
>> SendaoYan has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Merge branch 'jbs8334106' of github.com:sendaoYan/jdk-ysd into jbs8334106
>> - add whitespaces for alignment
>
> Thanks fo
On Thu, 13 Jun 2024 20:56:52 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-864
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> join two lines
Updates look good.
-
PR Review: https://git.op
On Thu, 13 Jun 2024 21:23:27 GMT, Valerie Peng wrote:
>> No. The two variables wouldn't be in scope for the `finally` block on line
>> 276.
>
> How about right above the block where they are assigned? The reason that I
> suggested this is that it's easier to see why no default value needed when
On Thu, 13 Jun 2024 13:18:10 GMT, Mark Powers wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/TlsKeyMaterialGenerator.java
>> line 109:
>>
>>> 107: SecretKey serverMacKey = null;
>>> 108: SecretKey clientCipherKey;
>>> 109: SecretKey serverCipherKey;
>>
>>
> https://bugs.openjdk.org/browse/JDK-864
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
join two lines
-
Changes:
- all: https://git.openjdk.org/jdk/pull/19535/files
- new: https://git.openjdk.org/jdk/pull/19535
On Wed, 12 Jun 2024 04:15:44 GMT, Valerie Peng wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> join two lines
>
> src/java.base/share/classes/com/sun/crypto/provider/CipherCore.java line 969:
>
>> 967: private
On Wed, 12 Jun 2024 14:08:43 GMT, Ferenc Rakoczi wrote:
>> This PR removes some unnecessary conversions between byte arrays and long
>> arrays during SHA3 digest computations.
>
> Ferenc Rakoczi has updated the pull request incrementally with one additional
> commit since the last revision:
>
Hi
This change is to improve TLS 1.3 session resumption by allowing a TLS server
to send more than one resumption ticket per connection and clients to store
more. Resumption is a quick way to use an existing TLS session to establish
another session by avoiding the long TLS full handshake proce
On Wed, 29 May 2024 18:53:55 GMT, Anthony Scarpino
wrote:
> Hi
>
> This change is to improve TLS 1.3 session resumption by allowing a TLS server
> to send more than one resumption ticket per connection and clients to store
> more. Resumption is a quick way to use an existing TLS session to e
On Tue, 4 Jun 2024 15:04:56 GMT, Jamil Nimeh wrote:
>> Hi
>>
>> This change is to improve TLS 1.3 session resumption by allowing a TLS
>> server to send more than one resumption ticket per connection and clients to
>> store more. Resumption is a quick way to use an existing TLS session to
>>
On Thu, 13 Jun 2024 09:25:11 GMT, Christoph Langer wrote:
> Let's exclude these CAInterop tests until the problem is fixed.
Seems fine to me.
-
Marked as reviewed by sgehwolf (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19690#pullrequestreview-2116347370
On Thu, 13 Jun 2024 12:32:58 GMT, SendaoYan wrote:
> Hi all,
> Test
> `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5`
> report failure as failed to validate, before the validate issue has been
> fixed, should we problem list the testcase.
On Thu, 13 Jun 2024 14:38:08 GMT, SendaoYan wrote:
>> SendaoYan has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Merge branch 'jbs8334106' of github.com:sendaoYan/jdk-ysd into jbs8334106
>> - add whitespaces for alignment
>
> Thanks fo
On Thu, 13 Jun 2024 14:01:55 GMT, Weijun Wang wrote:
> There is an error in `jarsigner` on the "This JAR contains signed entries
> that aren't signed by alias in this keystore" warning. The exit code is
> determined by
> [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb38d2
On Thu, 13 Jun 2024 15:45:41 GMT, Anthony Scarpino
wrote:
>> There is an error in `jarsigner` on the "This JAR contains signed entries
>> that aren't signed by alias in this keystore" warning. The exit code is
>> determined by
>> [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0
On Thu, 13 Jun 2024 14:01:55 GMT, Weijun Wang wrote:
> There is an error in `jarsigner` on the "This JAR contains signed entries
> that aren't signed by alias in this keystore" warning. The exit code is
> determined by
> [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb38d2
On Thu, 13 Jun 2024 12:21:23 GMT, SendaoYan wrote:
>> Hi all,
>> Test
>> `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3`
>> report failure as `failed to validate`, before the validate issue has been
>> fixed, should we problem list the te
There is an error in `jarsigner` on the "This JAR contains signed entries that
aren't signed by alias in this keystore" warning. The exit code is determined
by
[`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb38d2cc97f3862ef95a0d26ba49a7/src/jdk.jartool/share/classes/sun/secu
On Thu, 13 Jun 2024 13:07:23 GMT, Christoph Langer wrote:
> Hi all,
>
> This pull request contains a backport of
> [JDK-8333724](https://bugs.openjdk.org/browse/JDK-8333724), commit
> [8ffc35d1](https://github.com/openjdk/jdk/commit/8ffc35d117846a7a2aa08afed662273d2f887770)
> from the [openjd
On Thu, 6 Jun 2024 20:10:10 GMT, Valerie Peng wrote:
>> https://bugs.openjdk.org/browse/JDK-864
>
> src/java.base/share/classes/com/sun/crypto/provider/AESKeyWrap.java line 121:
>
>> 119: @Override
>> 120: int encrypt(byte[] pt, int ptOfs, int ptLen, byte[] ct, int ctOfs) {
>> 121:
> https://bugs.openjdk.org/browse/JDK-864
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
comments from Valerie
-
Changes:
- all: https://git.openjdk.org/jdk/pull/19535/files
- new: https://git.openjdk.org/jdk/pul
On Thu, 13 Jun 2024 13:07:23 GMT, Christoph Langer wrote:
> Hi all,
>
> This pull request contains a backport of
> [JDK-8333724](https://bugs.openjdk.org/browse/JDK-8333724), commit
> [8ffc35d1](https://github.com/openjdk/jdk/commit/8ffc35d117846a7a2aa08afed662273d2f887770)
> from the [openjd
On Thu, 13 Jun 2024 12:21:23 GMT, SendaoYan wrote:
>> Hi all,
>> Test
>> `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3`
>> report failure as `failed to validate`, before the validate issue has been
>> fixed, should we problem list the te
On Thu, 13 Jun 2024 13:07:23 GMT, Christoph Langer wrote:
> Hi all,
>
> This pull request contains a backport of
> [JDK-8333724](https://bugs.openjdk.org/browse/JDK-8333724), commit
> [8ffc35d1](https://github.com/openjdk/jdk/commit/8ffc35d117846a7a2aa08afed662273d2f887770)
> from the [openjd
Hi all,
This pull request contains a backport of
[JDK-8333724](https://bugs.openjdk.org/browse/JDK-8333724), commit
[8ffc35d1](https://github.com/openjdk/jdk/commit/8ffc35d117846a7a2aa08afed662273d2f887770)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backpo
Hi all,
Test
`security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5`
report failure as failed to validate, before the validate issue has been
fixed, should we problem list the testcase.
-
Commit messages:
- 8333938: Exclude CAInterop
> Hi all,
> Test
> `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3`
> report failure as `failed to validate`, before the validate issue has been
> fixed, should we problem list the testcase.
SendaoYan has updated the pull request incrementa
On Thu, 13 Jun 2024 11:55:34 GMT, Sean Mullan wrote:
> Please wait for @rhalade to review.
Will do. There's also #19685 and #19690. These are somewhat annoying and I'd
prefer if we could exclude them for the time being.
-
PR Comment: https://git.openjdk.org/jdk/pull/19689#issuecom
On Thu, 13 Jun 2024 09:32:28 GMT, SendaoYan wrote:
> let's wait a bit with integration before the security folks had a chance to
> look at this...
Thanks. Please wait for @rhalade to review.
-
PR Comment: https://git.openjdk.org/jdk/pull/19685#issuecomment-2165456827
On Thu, 13 Jun 2024 09:05:07 GMT, Christoph Langer wrote:
> The test is failing currently and the JBS issue could not be resolved since
> about a month, so let's exclude the test for now.
Please wait for @rhalade to review.
-
PR Comment: https://git.openjdk.org/jdk/pull/19689#issu
On Thu, 13 Jun 2024 09:05:07 GMT, Christoph Langer wrote:
> The test is failing currently and the JBS issue could not be resolved since
> about a month, so let's exclude the test for now.
+1
-
Marked as reviewed by stuefe (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19
Let's exclude these CAInterop tests until the problem is fixed.
-
Commit messages:
- JDK-8334202
Changes: https://git.openjdk.org/jdk/pull/19690/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19690&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8334202
Stats: 2 li
On Thu, 13 Jun 2024 09:21:41 GMT, Christoph Langer wrote:
> let's wait a bit with integration before the security folks had a chance to
> look at this...
Okey.
-
PR Comment: https://git.openjdk.org/jdk/pull/19685#issuecomment-2165126505
On Thu, 13 Jun 2024 01:20:55 GMT, SendaoYan wrote:
> Hi all,
> Test
> `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3`
> report failure as `failed to validate`, before the validate issue has been
> fixed, should we problem list the testcas
On Thu, 13 Jun 2024 01:20:55 GMT, SendaoYan wrote:
> Hi all,
> Test
> `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3`
> report failure as `failed to validate`, before the validate issue has been
> fixed, should we problem list the testcas
The test is failing currently and the JBS issue could not be resolved since
about a month, so let's exclude the test for now.
-
Commit messages:
- JDK-8334201
Changes: https://git.openjdk.org/jdk/pull/19689/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19689&range=00
I
On Thu, 13 Jun 2024 01:20:55 GMT, SendaoYan wrote:
> Hi all,
> Test
> `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3`
> report failure as `failed to validate`, before the validate issue has been
> fixed, should we problem list the testcas
43 matches
Mail list logo
