Re: RFR: 8333772: Incorrect Kerberos behavior when udp_preference_limit = 0

2024-06-10 Thread Sibabrata Sahoo
On Mon, 10 Jun 2024 20:29:54 GMT, Weijun Wang wrote: > Allow `udp_preference_limit = 0` to force TCP. > > The reason for this bug is that it was read in a similar way as `kdc_timeout` > and `max_retries`, both must be positive to have effect. Marked as reviewed by ssahoo (Committer).

Integrated: 8330205: Initial troff manpage generation for JDK 24

2024-06-10 Thread David Holmes
On Mon, 10 Jun 2024 02:31:00 GMT, David Holmes wrote: > Sets the version to 24/24-ea and the copyright year to 2025. > > Content changes related to the start of release (e.g. for removed options in > java.1) are handled separately. > > This initial generation also picks up the unpublished chan

Re: RFR: 8330205: Initial troff manpage generation for JDK 24 [v3]

2024-06-10 Thread David Holmes
On Mon, 10 Jun 2024 17:27:18 GMT, Iris Clark wrote: >> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Regenerated after merge > > Marked as reviewed by iris (Reviewer). Thanks for the review @irisclark . I've merged in th

Re: RFR: 8333364: Minor cleanup could be done in com.sun.crypto.provider

2024-06-10 Thread Valerie Peng
On Tue, 4 Jun 2024 02:32:31 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-864 src/java.base/share/classes/com/sun/crypto/provider/ChaCha20Cipher.java line 764: > 762: @Override > 763: protected int engineDoFinal(byte[] in, int inOfs, int inLen, byte[] > out, > 764:

Re: RFR: 8330205: Initial troff manpage generation for JDK 24 [v3]

2024-06-10 Thread David Holmes
> Sets the version to 24/24-ea and the copyright year to 2025. > > Content changes related to the start of release (e.g. for removed options in > java.1) are handled separately. > > This initial generation also picks up the unpublished changes from: > > - JDK-8330807: Update Manpage for obsole

Re: RFR: 8330205: Initial troff manpage generation for JDK 24 [v2]

2024-06-10 Thread David Holmes
> Sets the version to 24/24-ea and the copyright year to 2025. > > Content changes related to the start of release (e.g. for removed options in > java.1) are handled separately. > > This initial generation also picks up the unpublished changes from: > > - JDK-8330807: Update Manpage for obsole

Re: RFR: 8333364: Minor cleanup could be done in com.sun.crypto.provider

2024-06-10 Thread Valerie Peng
On Tue, 4 Jun 2024 02:32:31 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-864 src/java.base/share/classes/com/sun/crypto/provider/ChaCha20Cipher.java line 678: > 676: protected int engineUpdate(byte[] in, int inOfs, int inLen, > 677: byte[] out, int outOfs)

Re: RFR: 8333867: SHA3 performance can be improved

2024-06-10 Thread Ferenc Rakoczi
On Mon, 10 Jun 2024 18:43:49 GMT, Vladimir Kozlov wrote: >> This PR removes some unnecessary conversions between byte arrays and long >> arrays during SHA3 digest computations. > > src/java.base/share/classes/sun/security/provider/SHA3.java line 100: > >> 98: b2lLittle(b, ofs, longBuf,

RFR: 8333772: Incorrect Kerberos behavior when udp_preference_limit = 0

2024-06-10 Thread Weijun Wang
Allow `udp_preference_limit = 0` to force TCP. The reason for this bug is that it was read in a similar way as `kdc_timeout` and `max_retries`, both must be positive to have effect. - Commit messages: - the fix Changes: https://git.openjdk.org/jdk/pull/19638/files Webrev: https:

Re: RFR: 8333772: Incorrect Kerberos behavior when udp_preference_limit = 0

2024-06-10 Thread Weijun Wang
On Mon, 10 Jun 2024 20:29:54 GMT, Weijun Wang wrote: > Allow `udp_preference_limit = 0` to force TCP. > > The reason for this bug is that it was read in a similar way as `kdc_timeout` > and `max_retries`, both must be positive to have effect. This code change introduce a behavior change that m

Re: RFR: 8333867: SHA3 performance can be improved

2024-06-10 Thread Vladimir Kozlov
On Mon, 10 Jun 2024 15:01:55 GMT, Ferenc Rakoczi wrote: > This PR removes some unnecessary conversions between byte arrays and long > arrays during SHA3 digest computations. src/java.base/share/classes/sun/security/provider/SHA3.java line 100: > 98: b2lLittle(b, ofs, longBuf, 0, blockS

Re: RFR: 8333867: SHA3 performance can be improved

2024-06-10 Thread Vladimir Kozlov
On Mon, 10 Jun 2024 17:29:31 GMT, Ferenc Rakoczi wrote: >> src/java.base/share/classes/sun/security/provider/SHA3.java line 98: >> >>> 96: @IntrinsicCandidate >>> 97: private void implCompress0(byte[] b, int ofs) { >>> 98: b2lLittle(b, ofs, longBuf, 0, blockSize); >> >> What abo

Re: RFR: 8333867: SHA3 performance can be improved

2024-06-10 Thread Ferenc Rakoczi
On Mon, 10 Jun 2024 17:25:21 GMT, Vladimir Kozlov wrote: >> This PR removes some unnecessary conversions between byte arrays and long >> arrays during SHA3 digest computations. > > src/java.base/share/classes/sun/security/provider/SHA3.java line 98: > >> 96: @IntrinsicCandidate >> 97: p

Re: RFR: 8330205: Initial troff manpage generation for JDK 24

2024-06-10 Thread Iris Clark
On Mon, 10 Jun 2024 02:31:00 GMT, David Holmes wrote: > Sets the version to 24/24-ea and the copyright year to 2025. > > Content changes related to the start of release (e.g. for removed options in > java.1) are handled separately. > > This initial generation also picks up the unpublished chan

Re: RFR: 8333867: SHA3 performance can be improved

2024-06-10 Thread Vladimir Kozlov
On Mon, 10 Jun 2024 15:01:55 GMT, Ferenc Rakoczi wrote: > This PR removes some unnecessary conversions between byte arrays and long > arrays during SHA3 digest computations. src/java.base/share/classes/sun/security/provider/SHA3.java line 98: > 96: @IntrinsicCandidate > 97: private voi

Integrated: 8333829: ProblemList sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java due to JDK-8333317

2024-06-10 Thread Matthew Donovan
On Mon, 10 Jun 2024 13:56:07 GMT, Matthew Donovan wrote: > In this PR, I updated the ProblemList entry for ClientJSSEServerJSSE.java for > all architectures. > > JDK-817 documents an intermittent failure which may be resolved by a fix > in NSS: https://bugzilla.mozilla.org/show_bug.cgi?id

Re: RFR: 8333829: ProblemList sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java due to JDK-8333317

2024-06-10 Thread Sean Mullan
On Mon, 10 Jun 2024 13:56:07 GMT, Matthew Donovan wrote: > In this PR, I updated the ProblemList entry for ClientJSSEServerJSSE.java for > all architectures. > > JDK-817 documents an intermittent failure which may be resolved by a fix > in NSS: https://bugzilla.mozilla.org/show_bug.cgi?id

RFR: 8333867: SHA3 performance can be improved

2024-06-10 Thread Ferenc Rakoczi
This PR removes some unnecessary conversions between byte arrays and long arrays during SHA3 digest computations. - Commit messages: - 8333867: SHA3 performance can be improved Changes: https://git.openjdk.org/jdk/pull/19632/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=

RFR: 8333829: ProblemList sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java due to JDK-8333317

2024-06-10 Thread Matthew Donovan
In this PR, I updated the ProblemList entry for ClientJSSEServerJSSE.java for all architectures. JDK-817 documents an intermittent failure which may be resolved by a fix in NSS: https://bugzilla.mozilla.org/show_bug.cgi?id=1893404 - Commit messages: - 8333829: ProblemList sun

Re: RFR: 8330205: Initial troff manpage generation for JDK 24

2024-06-10 Thread David Holmes
On Mon, 10 Jun 2024 07:15:51 GMT, Alan Bateman wrote: >> Sets the version to 24/24-ea and the copyright year to 2025. >> >> Content changes related to the start of release (e.g. for removed options in >> java.1) are handled separately. >> >> This initial generation also picks up the unpublishe

Re: RFR: 8330205: Initial troff manpage generation for JDK 24

2024-06-10 Thread Alan Bateman
On Mon, 10 Jun 2024 02:31:00 GMT, David Holmes wrote: > Sets the version to 24/24-ea and the copyright year to 2025. > > Content changes related to the start of release (e.g. for removed options in > java.1) are handled separately. > > This initial generation also picks up the unpublished chan