On Fri, 7 Jun 2024 19:25:45 GMT, Francisco Ferrari Bihurriet
wrote:
>> Hi,
>>
>> I would like to propose an implementation to support AES CBC with Ciphertext
>> Stealing (CTS) in SunPKCS11, according to what has been specified in
>> [JDK-8330843 CSR](https://bugs.openjdk.org/browse/JDK-833084
> Hi,
>
> I would like to propose an implementation to support AES CBC with Ciphertext
> Stealing (CTS) in SunPKCS11, according to what has been specified in
> [JDK-8330843 CSR](https://bugs.openjdk.org/browse/JDK-8330843).
>
> What follows are implementation notes that describe the most releva
On Fri, 7 Jun 2024 16:10:09 GMT, Martin Balao wrote:
>>> I created the release-note and doc sub-task for this RFE. Please take a
>>> look.
>>
>> They look good to me, I just removed two extra white spaces around the
>> closing parenthesis in
>> [JDK-8333760](https://bugs.openjdk.org/browse/JD
On Fri, 7 Jun 2024 13:33:55 GMT, Francisco Ferrari Bihurriet
wrote:
>> I created the release-note and doc sub-task for this RFE. Please take a look.
>> As for the code change, the rest looks fine to me.
>> Thanks,
>> Valerie
>
>> I created the release-note and doc sub-task for this RFE. Please t
On Fri, 7 Jun 2024 13:03:27 GMT, Francisco Ferrari Bihurriet
wrote:
>> Hi,
>>
>> I would like to propose an implementation to support AES CBC with Ciphertext
>> Stealing (CTS) in SunPKCS11, according to what has been specified in
>> [JDK-8330843 CSR](https://bugs.openjdk.org/browse/JDK-833084
On Fri, 7 Jun 2024 07:29:39 GMT, SendaoYan wrote:
>> Hi all,
>> This PR several extra empty spaces and extra empty lines in several
>> Makefiles. It's trivial fix, no risk.
>>
>> Thanks.
>
> SendaoYan has updated the pull request incrementally with one additional
> commit since the last revi
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote:
> Hi all,
> This PR several extra empty spaces and extra empty lines in several
> Makefiles. It's trivial fix, no risk.
>
> Thanks.
This pull request has now been integrated.
Changeset: d130d2f4
Author:SendaoYan
Committer: Julian Waters
On Fri, 7 Jun 2024 13:01:15 GMT, SendaoYan wrote:
>> As confusing as they are, unfortunately GitHub UI does not render extra
>> trailing newlines. This is the only one I could find with grepWin.
>
> I find the extra trailing newlines through below shell command:
>
> for i in `find . -iname "Mak
On Fri, 7 Jun 2024 02:02:38 GMT, Valerie Peng wrote:
> I created the release-note and doc sub-task for this RFE. Please take a look.
They look good to me, I just removed two extra white spaces around the closing
parenthesis in [JDK-8333760](https://bugs.openjdk.org/browse/JDK-8333760).
> As fo
On Fri, 7 Jun 2024 12:53:46 GMT, Chen Liang wrote:
>> No, it's an extra newline. A file should end with a newline but one is
>> enough.
>
> As confusing as they are, unfortunately GitHub UI does not render extra
> trailing newlines. This is the only one I could find with grepWin.
I find the ex
> Hi,
>
> I would like to propose an implementation to support AES CBC with Ciphertext
> Stealing (CTS) in SunPKCS11, according to what has been specified in
> [JDK-8330843 CSR](https://bugs.openjdk.org/browse/JDK-8330843).
>
> What follows are implementation notes that describe the most releva
On Fri, 7 Jun 2024 12:47:39 GMT, Erik Joelsson wrote:
>> test/jdk/java/rmi/reliability/benchmark/bench/Makefile line 50:
>>
>>> 48: clean:
>>> 49: rm -f *.class .classes
>>> 50:
>>
>> Hmm, shouldn't this newline at EOF be kept? Asking @ all the people who've
>> reviewed this so far, n
On Fri, 7 Jun 2024 12:37:48 GMT, Julian Waters wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> delete extra empty trailing blank line in
>> test/jdk/java/rmi/reliability/benchmark/bench/Makefile
>
> test/jdk/java/rmi
On Fri, 7 Jun 2024 07:29:39 GMT, SendaoYan wrote:
>> Hi all,
>> This PR several extra empty spaces and extra empty lines in several
>> Makefiles. It's trivial fix, no risk.
>>
>> Thanks.
>
> SendaoYan has updated the pull request incrementally with one additional
> commit since the last revi
On Fri, 7 Jun 2024 07:29:39 GMT, SendaoYan wrote:
>> Hi all,
>> This PR several extra empty spaces and extra empty lines in several
>> Makefiles. It's trivial fix, no risk.
>>
>> Thanks.
>
> SendaoYan has updated the pull request incrementally with one additional
> commit since the last revi
On Fri, 7 Jun 2024 07:26:39 GMT, SendaoYan wrote:
>> test/jdk/java/rmi/reliability/benchmark/bench/rmi/Makefile line 1:
>>
>>> 1: #
>>
>> This file change is dubious:
>> 1. It does not have any trailing whitespace that can fail the skara checks.
>> 2. If the duplicate blank lines in the end of
On Fri, 7 Jun 2024 07:29:39 GMT, SendaoYan wrote:
>> Hi all,
>> This PR several extra empty spaces and extra empty lines in several
>> Makefiles. It's trivial fix, no risk.
>>
>> Thanks.
>
> SendaoYan has updated the pull request incrementally with one additional
> commit since the last revi
On Fri, 7 Jun 2024 07:29:39 GMT, SendaoYan wrote:
>> Hi all,
>> This PR several extra empty spaces and extra empty lines in several
>> Makefiles. It's trivial fix, no risk.
>>
>> Thanks.
>
> SendaoYan has updated the pull request incrementally with one additional
> commit since the last revi
> Hi all,
> This PR several extra empty spaces and extra empty lines in several
> Makefiles. It's trivial fix, no risk.
>
> Thanks.
SendaoYan has updated the pull request incrementally with one additional commit
since the last revision:
delete extra empty trailing blank line in
test/jdk/j
On Thu, 6 Jun 2024 17:49:08 GMT, Chen Liang wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> delete extra empty trailing blank line in
>> test/jdk/java/rmi/reliability/benchmark/bench/Makefile
>
> test/jdk/java/rmi/re
20 matches
Mail list logo
