Integrated: 8333046: Clean codes in sun.security.util.math

2024-05-31 Thread John Jiang
On Tue, 28 May 2024 14:42:13 GMT, John Jiang wrote: > A simple cleanup on the changes introduced by JDK-8329538. This pull request has now been integrated. Changeset: c0ce7d87 Author:John Jiang URL: https://git.openjdk.org/jdk/commit/c0ce7d871f09df6bf4a21be3579f3f39a49a77bd Stats:

Re: RFR: 8333046: Clean codes in sun.security.util.math

2024-05-31 Thread John Jiang
On Fri, 31 May 2024 13:53:18 GMT, Weijun Wang wrote: >> A simple cleanup on the changes introduced by JDK-8329538. > > Looks good. Thanks for the cleanup. @wangweij Thanks for your review! - PR Comment: https://git.openjdk.org/jdk/pull/19429#issuecomment-2143311471

Re: RFR: 4966250: SSLSessionContext.setSessionTimeout() documentation could be updated [v3]

2024-05-31 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-4966250 Mark Powers has updated the pull request incrementally with one additional commit since the last revision: Joe Darcy's comment - Changes: - all: https://git.openjdk.org/jdk/pull/19458/files - new: https://git.openjdk.org/jdk/pull/

Re: Missing element-list for https://docs.oracle.com/javase/8/docs/jre/api/security/jgss/spec

2024-05-31 Thread Jonathan Gibbons
Michael, There is no `element-list` file for any version of JDK before JDK 9.    Before JDK 9, the appropriate information was in the `package-list` file. In JDK 9, with the introduction of modules, the format of the file was updated to include modules, and because this was an incompatible ch

Re: Missing element-list for https://docs.oracle.com/javase/8/docs/jre/api/security/jgss/spec

2024-05-31 Thread Wei-Jun Wang
Adding javadoc-...@openjdk.org , but I heard "element-list" only came in with modules in JDK 9. --Weijun > On May 31, 2024, at 5:51 AM, Osipov, Michael (IN IT IN) > wrote: > > Guys, > > can someone upload element-list for that API? Javadoc fails to link to it:

Missing element-list for https://docs.oracle.com/javase/8/docs/jre/api/security/jgss/spec

2024-05-31 Thread Osipov, Michael (IN IT IN)
Guys, can someone upload element-list for that API? Javadoc fails to link to it: warning: URL https://docs.oracle.com/javase/8/docs/jre/api/security/jgss/spec/element-list was redirected to https://docs.oracle.com/en/java/javase/22/ -- Update the command-line options to suppress this warning

Re: [External] : Re: PEM API github repo

2024-05-31 Thread Karl Scheibelhofer
Hi Tonay, in https://github.com/KarlScheibelhofer/jdk/tree/pem-keystore-2-pem-api you can find a PEM keystore implementation with tests. It is based on the latest https://github.com/ascarpino/jdk/tree/pem branch. I made these two modifications ( https://github.com/KarlScheibelhofer/jdk/commit/4d8

Re: [External] : Re: PEM API github repo

2024-05-31 Thread Karl Scheibelhofer
Hi Tony, today, I had a look at the recent sources of the PEM API implementation - i.e. https://github.com/ascarpino/jdk/commits/pem It seems that the PEM API Tests are out of sync. They fail with JT Harness : Tests that failed java/security/PEM/PEMDecoderTest.java: Testing PEM decodings java/s

Re: RFR: 8333046: Clean codes in sun.security.util.math

2024-05-31 Thread Weijun Wang
On Tue, 28 May 2024 14:42:13 GMT, John Jiang wrote: > A simple cleanup on the changes introduced by JDK-8329538. Looks good. Thanks for the cleanup. - Marked as reviewed by weijun (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19429#pullrequestreview-2090895326